diff mbox series

[v3,02/10] firmware: ti_sci: Add No-OP for "RX_FL_CFG"

Message ID 20240705045030.1141934-3-c-vankar@ti.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Add support for Ethernet Boot on SK-AM62 | expand

Commit Message

Chintan Vankar July 5, 2024, 4:50 a.m. UTC
From: Kishon Vijay Abraham I <kishon@ti.com>

RX_FL_CFG message should not be forwarded to TIFS and should be
handled within R5 SPL (when DM services are not available). Add
a no-op function to not handle RX_FL_CFG messages.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Chintan Vankar <c-vankar@ti.com>
---

Link to v2:
https://lore.kernel.org/r/20240425120822.2048012-3-c-vankar@ti.com/

Changes from v2 to v3:
- No changes.

 drivers/firmware/ti_sci.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Sverdlin, Alexander Aug. 16, 2024, 12:28 p.m. UTC | #1
On Fri, 2024-07-05 at 10:20 +0530, Chintan Vankar wrote:
> From: Kishon Vijay Abraham I <kishon@ti.com>
> 
> RX_FL_CFG message should not be forwarded to TIFS and should be
> handled within R5 SPL (when DM services are not available). Add
> a no-op function to not handle RX_FL_CFG messages.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

> ---
> 
> Link to v2:
> https://lore.kernel.org/r/20240425120822.2048012-3-c-vankar@ti.com/
> 
> Changes from v2 to v3:
> - No changes.
> 
>  drivers/firmware/ti_sci.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 8ce0f46e70..346656c028 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -2451,6 +2451,12 @@ fail:
>  	return ret;
>  }
>  
> +static int ti_sci_cmd_rm_udmap_rx_flow_cfg_noop(const struct ti_sci_handle *handle,
> +						const struct ti_sci_msg_rm_udmap_flow_cfg *params)
> +{
> +	return 0;
> +}
> +
>  /**
>   * ti_sci_cmd_set_fwl_region() - Request for configuring a firewall region
>   * @handle:    pointer to TI SCI handle
> @@ -2896,7 +2902,7 @@ static __maybe_unused int ti_sci_dm_probe(struct udevice *dev)
>  	udmap_ops = &ops->rm_udmap_ops;
>  	udmap_ops->tx_ch_cfg = ti_sci_cmd_rm_udmap_tx_ch_cfg;
>  	udmap_ops->rx_ch_cfg = ti_sci_cmd_rm_udmap_rx_ch_cfg;
> -	udmap_ops->rx_flow_cfg = ti_sci_cmd_rm_udmap_rx_flow_cfg;
> +	udmap_ops->rx_flow_cfg = ti_sci_cmd_rm_udmap_rx_flow_cfg_noop;
>  
>  	return ret;
>  }
diff mbox series

Patch

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 8ce0f46e70..346656c028 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -2451,6 +2451,12 @@  fail:
 	return ret;
 }
 
+static int ti_sci_cmd_rm_udmap_rx_flow_cfg_noop(const struct ti_sci_handle *handle,
+						const struct ti_sci_msg_rm_udmap_flow_cfg *params)
+{
+	return 0;
+}
+
 /**
  * ti_sci_cmd_set_fwl_region() - Request for configuring a firewall region
  * @handle:    pointer to TI SCI handle
@@ -2896,7 +2902,7 @@  static __maybe_unused int ti_sci_dm_probe(struct udevice *dev)
 	udmap_ops = &ops->rm_udmap_ops;
 	udmap_ops->tx_ch_cfg = ti_sci_cmd_rm_udmap_tx_ch_cfg;
 	udmap_ops->rx_ch_cfg = ti_sci_cmd_rm_udmap_rx_ch_cfg;
-	udmap_ops->rx_flow_cfg = ti_sci_cmd_rm_udmap_rx_flow_cfg;
+	udmap_ops->rx_flow_cfg = ti_sci_cmd_rm_udmap_rx_flow_cfg_noop;
 
 	return ret;
 }