diff mbox series

[3/5] hw/ppc/Kconfig: Add missing SERIAL_ISA dependency to POWERNV machine

Message ID 20240814181534.218964-4-shentey@gmail.com
State New
Headers show
Series Serial device cleanup | expand

Commit Message

Bernhard Beschow Aug. 14, 2024, 6:15 p.m. UTC 
The machine calls serial_hds_isa_init() which is provided by serial-isa.c,
guarded by SERIAL_ISA.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/ppc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Mathieu-Daudé Aug. 16, 2024, 9:18 a.m. UTC | #1 
On 14/8/24 20:15, Bernhard Beschow wrote:
> The machine calls serial_hds_isa_init() which is provided by serial-isa.c,
> guarded by SERIAL_ISA.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Mark Cave-Ayland Aug. 21, 2024, 2:42 p.m. UTC | #2 
On 14/08/2024 19:15, Bernhard Beschow wrote:

> The machine calls serial_hds_isa_init() which is provided by serial-isa.c,
> guarded by SERIAL_ISA.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index c235519881..5addad1124 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -39,6 +39,7 @@ config POWERNV
>       select PCI_POWERNV
>       select PCA9552
>       select PCA9554
> +    select SERIAL_ISA
>       select SSI
>       select SSI_M25P80
>       select PNV_SPI

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
diff mbox series

Patch

diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index c235519881..5addad1124 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -39,6 +39,7 @@  config POWERNV
     select PCI_POWERNV
     select PCA9552
     select PCA9554
+    select SERIAL_ISA
     select SSI
     select SSI_M25P80
     select PNV_SPI