diff mbox series

[v3,5/7] arm: mach-k3: j721s2_init: Initialize AVS Class 0

Message ID 20240813-b4-upstream-j721s2-avs-v3-5-5115d93cdeb2@ti.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Add AVS support for J721S2 | expand

Commit Message

Manorit Chawdhry Aug. 13, 2024, 6:10 a.m. UTC 
Initialize AVS Class 0.

Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
 arch/arm/mach-k3/j721s2/j721s2_init.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Kumar, Udit Aug. 15, 2024, 3:16 a.m. UTC | #1 
On 8/13/2024 11:40 AM, Manorit Chawdhry wrote:
> Initialize AVS Class 0.
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
>   arch/arm/mach-k3/j721s2/j721s2_init.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/mach-k3/j721s2/j721s2_init.c b/arch/arm/mach-k3/j721s2/j721s2_init.c
> index 05453fcad41a..5f5961a2c17a 100644
> --- a/arch/arm/mach-k3/j721s2/j721s2_init.c
> +++ b/arch/arm/mach-k3/j721s2/j721s2_init.c
> @@ -315,6 +315,9 @@ void do_dt_magic(void)
>   #ifdef CONFIG_SPL_BUILD
>   void board_init_f(ulong dummy)
>   {
> +	struct udevice *dev;
> +	int ret;
> +
>   	k3_spl_init();
>   #if defined(CONFIG_SPL_OF_LIST) && defined(CONFIG_TI_I2C_BOARD_DETECT)
>   	do_dt_magic();
> @@ -325,6 +328,13 @@ void board_init_f(ulong dummy)
>   		setup_navss_nb();
>   
>   	setup_qos();
> +
> +	if (IS_ENABLED(CONFIG_CPU_V7R) && IS_ENABLED(CONFIG_K3_AVS0)) {
> +		ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(k3_avs),
> +						  &dev);

Can we remove this ret, Something like


if (uclass_get_device_by_driver....)

printf();

if you think, ok to change

> +		if (ret)
> +			printf("AVS init failed: %d\n", ret);
> +	}
>   }
>   #endif
>   
>
diff mbox series

Patch

diff --git a/arch/arm/mach-k3/j721s2/j721s2_init.c b/arch/arm/mach-k3/j721s2/j721s2_init.c
index 05453fcad41a..5f5961a2c17a 100644
--- a/arch/arm/mach-k3/j721s2/j721s2_init.c
+++ b/arch/arm/mach-k3/j721s2/j721s2_init.c
@@ -315,6 +315,9 @@  void do_dt_magic(void)
 #ifdef CONFIG_SPL_BUILD
 void board_init_f(ulong dummy)
 {
+	struct udevice *dev;
+	int ret;
+
 	k3_spl_init();
 #if defined(CONFIG_SPL_OF_LIST) && defined(CONFIG_TI_I2C_BOARD_DETECT)
 	do_dt_magic();
@@ -325,6 +328,13 @@  void board_init_f(ulong dummy)
 		setup_navss_nb();
 
 	setup_qos();
+
+	if (IS_ENABLED(CONFIG_CPU_V7R) && IS_ENABLED(CONFIG_K3_AVS0)) {
+		ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(k3_avs),
+						  &dev);
+		if (ret)
+			printf("AVS init failed: %d\n", ret);
+	}
 }
 #endif