| Message ID | 20240731222831.14895-2-james.quinlan@broadcom.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | PCI: brcnstb: Enable STB 7712 SOC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 7/31/24 15:28, Jim Quinlan wrote: > o Change order of the compatible strings to be alphabetical > o Use "maxItems" where needed. > o Change maintainer: Nicolas has not been active for a while. It also > makes sense for a Broadcom employee to be the maintainer as many of the > details are privy to Broadcom. > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 01/08/2024 00:28, Jim Quinlan wrote: > o Change order of the compatible strings to be alphabetical > o Use "maxItems" where needed. I asked at v3 and then in v4 about splitting this. You never responded to that comment, so sorry I won't be repeating the same thing in v5. NAK. Best regards, Krzysztof
On Fri, Aug 2, 2024 at 2:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 01/08/2024 00:28, Jim Quinlan wrote: > > o Change order of the compatible strings to be alphabetical > > o Use "maxItems" where needed. > > I asked at v3 and then in v4 about splitting this. You never responded > to that comment, so sorry I won't be repeating the same thing in v5. I'm sorry Krzyszof, but I just reviewed your responses in V3 and V4 and I can't find you saying anything about splitting off the above two bullet points. Perhaps I am somehow losing email responses but all I see is this in V3 is the following, where you ask me to do a squash, not a commit: [JQ] o Change order of the compatible strings to be alphabetical []KK] That's a cleanup. You can squash it with a previous patch. Now you did say in V3 [JQ] o Describe resets/reset-names before using them in rules [KK] That's a new commit. but this bullet item does not relate to the bullet points you have highlighted in this email. As for your responses to V4, I don't see anything about splitting anything. Again, perhaps I have somehow missed an email. Rather than do more round trips of email, can you confirm that this is what you want: A new "dt bindings" commit that only includes the changes of o Change order of the compatible strings to be alphabetical o Use "maxItems" where needed. If the above is not what you want, please tell me unequivocally what you would like changed, even if you think you are repeating yourself. Regards and thanks, Jim Quinlan Broadcom STB/CM > > NAK. > > Best regards, > Krzysztof >
On 13/08/2024 00:07, Jim Quinlan wrote: > On Fri, Aug 2, 2024 at 2:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 01/08/2024 00:28, Jim Quinlan wrote: >>> o Change order of the compatible strings to be alphabetical >>> o Use "maxItems" where needed. >> >> I asked at v3 and then in v4 about splitting this. You never responded >> to that comment, so sorry I won't be repeating the same thing in v5. > > I'm sorry Krzyszof, but I just reviewed your responses in V3 and V4 > and I can't find you saying anything about splitting off the above two > bullet points. Perhaps I am somehow losing email responses but all I > see is this in V3 is the following, where you ask me to do a squash, > not a commit: > > [JQ] o Change order of the compatible strings to be alphabetical > []KK] That's a cleanup. You can squash it with a previous patch. > > Now you did say in V3 > > [JQ] o Describe resets/reset-names before using them in rules > [KK] That's a new commit. > > but this bullet item does not relate to the bullet points you have > highlighted in this email. As for your responses to V4, I don't see It exactly relates to the quoted part. The comment is ALWAYS under exact part of your patch being questioned/commented. So first I said one part is cleanup and should be moved away. Then I explained that this part is a NEW COMMIT. New, so one more, different. I understand that this was not clear, but you never came with a question what did I mean. Best regards, Krzysztof
On Tue, Aug 13, 2024 at 4:27 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 13/08/2024 00:07, Jim Quinlan wrote: > > On Fri, Aug 2, 2024 at 2:43 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On 01/08/2024 00:28, Jim Quinlan wrote: > >>> o Change order of the compatible strings to be alphabetical > >>> o Use "maxItems" where needed. > >> > >> I asked at v3 and then in v4 about splitting this. You never responded > >> to that comment, so sorry I won't be repeating the same thing in v5. > > > > I'm sorry Krzyszof, but I just reviewed your responses in V3 and V4 > > and I can't find you saying anything about splitting off the above two > > bullet points. Perhaps I am somehow losing email responses but all I > > see is this in V3 is the following, where you ask me to do a squash, > > not a commit: > > > > [JQ] o Change order of the compatible strings to be alphabetical > > []KK] That's a cleanup. You can squash it with a previous patch. > > > > Now you did say in V3 > > > > [JQ] o Describe resets/reset-names before using them in rules > > [KK] That's a new commit. > > > > but this bullet item does not relate to the bullet points you have > > highlighted in this email. As for your responses to V4, I don't see > > It exactly relates to the quoted part. The comment is ALWAYS under exact > part of your patch being questioned/commented. > > So first I said one part is cleanup and should be moved away. Then I > explained that this part is a NEW COMMIT. New, so one more, different. > > I understand that this was not clear, but you never came with a question > what did I mean. Hello Krzysztof, Sorry to bother you again but I want this to be clear. This commit contains the changes: 1. alphabetical order of compatible strings 2. maxItems 3. maintainer change Do you want me to split off 3 since it is not a "cleanup"? If not, please specify. Regards, Jim Quinlan Broadcom STB/CM > > Best regards, > Krzysztof >
On 14/08/2024 19:35, Jim Quinlan wrote: >> I understand that this was not clear, but you never came with a question >> what did I mean. > > Hello Krzysztof, > > Sorry to bother you again but I want this to be clear. This commit > contains the changes: > > 1. alphabetical order of compatible strings > 2. maxItems Only this one to new commit, because this is a functional change. > 3. maintainer change All others are rather trivial or organizational, so they could stay in one commit. > > Do you want me to split off 3 since it is not a "cleanup"? If not, > please specify. > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 11f8ea33240c..7d2552192153 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Brcmstb PCIe Host Controller maintainers: - - Nicolas Saenz Julienne <nsaenzjulienne@suse.de> + - Jim Quinlan <james.quinlan@broadcom.com> properties: compatible: @@ -16,11 +16,11 @@ properties: - brcm,bcm2711-pcie # The Raspberry Pi 4 - brcm,bcm4908-pcie - brcm,bcm7211-pcie # Broadcom STB version of RPi4 - - brcm,bcm7278-pcie # Broadcom 7278 Arm - brcm,bcm7216-pcie # Broadcom 7216 Arm - - brcm,bcm7445-pcie # Broadcom 7445 Arm + - brcm,bcm7278-pcie # Broadcom 7278 Arm - brcm,bcm7425-pcie # Broadcom 7425 MIPs - brcm,bcm7435-pcie # Broadcom 7435 MIPs + - brcm,bcm7445-pcie # Broadcom 7445 Arm reg: maxItems: 1 @@ -95,6 +95,12 @@ properties: minItems: 1 maxItems: 3 + resets: + maxItems: 1 + + reset-names: + maxItems: 1 + required: - compatible - reg @@ -118,8 +124,7 @@ allOf: then: properties: resets: - items: - - description: reset controller handling the PERST# signal + maxItems: 1 reset-names: items: @@ -136,8 +141,7 @@ allOf: then: properties: resets: - items: - - description: phandle pointing to the RESCAL reset controller + maxItems: 1 reset-names: items:
o Change order of the compatible strings to be alphabetical o Use "maxItems" where needed. o Change maintainer: Nicolas has not been active for a while. It also makes sense for a Broadcom employee to be the maintainer as many of the details are privy to Broadcom. Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com> --- .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)