| Message ID | 20240713054213.228070-2-heiko.thiery@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pkg-cmake CMAKE_ASM_COMPILER override | expand |
>>>>> "Heiko" == Heiko Thiery <heiko.thiery@gmail.com> writes: > Overriding the ASM is wrong and leads to failures e.g. for the llvm > package. Therefore the ASM compiler was overwritten there. > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > package/pkg-cmake.mk | 1 - > 1 file changed, 1 deletion(-) > diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk > index 8f391eb4c9..c7032312fb 100644 > --- a/package/pkg-cmake.mk > +++ b/package/pkg-cmake.mk > @@ -147,7 +147,6 @@ define $(2)_CONFIGURE_CMDS > -DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \ > -DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \ > -DCMAKE_SHARED_LINKER_FLAGS="$$(HOST_LDFLAGS)" \ > - -DCMAKE_ASM_COMPILER="$$(HOSTAS)" \ > -DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \ > -DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \ > $(if $$(CMAKE_HOST_C_COMPILER_LAUNCHER),\ Committed to 2024.02.x and 2024.05.x, thanks.
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 8f391eb4c9..c7032312fb 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -147,7 +147,6 @@ define $(2)_CONFIGURE_CMDS -DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \ -DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \ -DCMAKE_SHARED_LINKER_FLAGS="$$(HOST_LDFLAGS)" \ - -DCMAKE_ASM_COMPILER="$$(HOSTAS)" \ -DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \ -DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \ $(if $$(CMAKE_HOST_C_COMPILER_LAUNCHER),\
Overriding the ASM is wrong and leads to failures e.g. for the llvm package. Therefore the ASM compiler was overwritten there. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- package/pkg-cmake.mk | 1 - 1 file changed, 1 deletion(-)