| Message ID | ZrL7Ovbl+xTX+KX/@waldemar-brodkorb.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/libjcat: fix linking, add missing intl library | expand |
Hello Waldemar, On Wed, 7 Aug 2024 06:42:34 +0200 Waldemar Brodkorb <wbx@openadk.org> wrote: > +ifneq ($(BR2_TOOLCHAIN_USES_GLIBC),y) > +LIBJCAT_LDFLAGS += -lintl > +endif Thanks, but this is not the correct way to deal with libintl issues. See the Buildroot manual at https://buildroot.org/downloads/manual/manual.html#_gettext_integration_and_interaction_with_packages. You need to use $(TARGET_NLS_DEPENDENCIES) and $(TARGET_NLS_LIBS) to have a correct behavior in all situations. You can grep for TARGET_NLS_DEPENDENCIES and TARGET_NLS_LIBS in other packages to see how they are being used. Could you look into this and send a v2? Thanks a lot! Thomas
diff --git a/package/libjcat/libjcat.mk b/package/libjcat/libjcat.mk index e13e5dbfb7..222e8ff72b 100644 --- a/package/libjcat/libjcat.mk +++ b/package/libjcat/libjcat.mk @@ -40,4 +40,8 @@ else LIBJCAT_CONF_OPTS += -Dpkcs7=false endif +ifneq ($(BR2_TOOLCHAIN_USES_GLIBC),y) +LIBJCAT_LDFLAGS += -lintl +endif + $(eval $(meson-package))
For musl/uClibc-ng toolchains we need to explicitely link libintl. The problem exist since the addition of the package in commit e52605c092d8eaa926da8720ae498a38eddb5205. Fixes: - http://autobuild.buildroot.net/results/58c/58c7ecbcfab96ebbc7a20291d4712cf64094b9f7/ - http://autobuild.buildroot.net/results/5d7/5d7c5dea0213f5a24489c397c5703c0601b2f12d/ Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> --- package/libjcat/libjcat.mk | 4 ++++ 1 file changed, 4 insertions(+)