| Message ID | 20240731074544.208411-1-animeshagarwal28@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: timer: nxp,lpc3220-timer: Convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 55 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, 31 Jul 2024 13:15:40 +0530, Animesh Agarwal wrote: > Convert the NXP LPC3220 timer bindings to yaml format. > Add missing resets property as it is already being used in dts. > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > --- > .../bindings/timer/nxp,lpc3220-timer.txt | 26 --------- > .../bindings/timer/nxp,lpc3220-timer.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 26 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt > create mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On 7/31/24 10:45, Animesh Agarwal wrote: > Convert the NXP LPC3220 timer bindings to yaml format. > Add missing resets property as it is already being used in dts. > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > --- > .../bindings/timer/nxp,lpc3220-timer.txt | 26 --------- > .../bindings/timer/nxp,lpc3220-timer.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 26 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt > create mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml > > diff --git a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt > deleted file mode 100644 > index 51b05a0e70d1..000000000000 > --- a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt > +++ /dev/null > @@ -1,26 +0,0 @@ > -* NXP LPC3220 timer > - > -The NXP LPC3220 timer is used on a wide range of NXP SoCs. This > -includes LPC32xx, LPC178x, LPC18xx and LPC43xx parts. > - > -Required properties: > -- compatible: > - Should be "nxp,lpc3220-timer". > -- reg: > - Address and length of the register set. > -- interrupts: > - Reference to the timer interrupt > -- clocks: > - Should contain a reference to timer clock. > -- clock-names: > - Should contain "timerclk". > - > -Example: > - > -timer1: timer@40085000 { > - compatible = "nxp,lpc3220-timer"; > - reg = <0x40085000 0x1000>; > - interrupts = <13>; > - clocks = <&ccu1 CLK_CPU_TIMER1>; > - clock-names = "timerclk"; > -}; > diff --git a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml > new file mode 100644 > index 000000000000..3ae2eb0625da > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/nxp,lpc3220-timer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP LPC3220 timer > + > +maintainers: > + - Animesh Agarwal <animeshagarwal28@gmail.com> > + > +description: | > + The NXP LPC3220 timer is used on a wide range of NXP SoCs. This includes > + LPC32xx, LPC178x, LPC18xx and LPC43xx parts. > + > +properties: > + compatible: > + const: nxp,lpc3220-timer > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: timerclk > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names Since there is always just a single supply clock, there is no need to specify "clock-names" as a required one, please change it. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/lpc32xx-clock.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + timer@4004c000 { > + compatible = "nxp,lpc3220-timer"; > + reg = <0x4004c000 0x1000>; > + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&clk LPC32XX_CLK_TIMER1>; > + clock-names = "timerclk"; > + }; I would appreciate, if you can use scripts/get_maintainer.pl in future. -- Best wishes, Vladimir
On 06/08/2024 22:13, Vladimir Zapolskiy wrote: >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + const: timerclk >> + >> + resets: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names > > Since there is always just a single supply clock, there is no need to > specify "clock-names" as a required one, please change it. ??? That's a conversion. Why do you expect changing several DTS files and maybe also driver? That's not needed for conversion. No. Best regards, Krzysztof
On 06/08/2024 22:13, Vladimir Zapolskiy wrote: >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/lpc32xx-clock.h> >> + #include <dt-bindings/interrupt-controller/irq.h> >> + >> + timer@4004c000 { >> + compatible = "nxp,lpc3220-timer"; >> + reg = <0x4004c000 0x1000>; >> + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; >> + clocks = <&clk LPC32XX_CLK_TIMER1>; >> + clock-names = "timerclk"; >> + }; > > I would appreciate, if you can use scripts/get_maintainer.pl in future. It was used and everything is fine. What are you complaining here about? Best regards, Krzysztof
On 8/7/24 09:01, Krzysztof Kozlowski wrote: > On 06/08/2024 22:13, Vladimir Zapolskiy wrote: >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + clocks: >>> + maxItems: 1 >>> + >>> + clock-names: >>> + const: timerclk >>> + >>> + resets: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >>> + - clocks >>> + - clock-names >> >> Since there is always just a single supply clock, there is no need to >> specify "clock-names" as a required one, please change it. > > ??? That's a conversion. Why do you expect changing several DTS files > and maybe also driver? That's not needed for conversion. No. I do not expect changing any DTS files, why? But I would be glad to see that the clock-names property becomes optional in the first place and therefore before the conversion. -- Best wishes, Vladimir
On 8/7/24 09:02, Krzysztof Kozlowski wrote: > On 06/08/2024 22:13, Vladimir Zapolskiy wrote: >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include <dt-bindings/clock/lpc32xx-clock.h> >>> + #include <dt-bindings/interrupt-controller/irq.h> >>> + >>> + timer@4004c000 { >>> + compatible = "nxp,lpc3220-timer"; >>> + reg = <0x4004c000 0x1000>; >>> + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; >>> + clocks = <&clk LPC32XX_CLK_TIMER1>; >>> + clock-names = "timerclk"; >>> + }; >> >> I would appreciate, if you can use scripts/get_maintainer.pl in future. > > It was used and everything is fine. What are you complaining here about? This makes sense, sorry for the noise, and thank you for the correction! -- Best wishes, Vladimir
On 07/08/2024 10:41, Vladimir Zapolskiy wrote: > On 8/7/24 09:01, Krzysztof Kozlowski wrote: >> On 06/08/2024 22:13, Vladimir Zapolskiy wrote: >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + maxItems: 1 >>>> + >>>> + clock-names: >>>> + const: timerclk >>>> + >>>> + resets: >>>> + maxItems: 1 >>>> + >>>> +required: >>>> + - compatible >>>> + - reg >>>> + - interrupts >>>> + - clocks >>>> + - clock-names >>> >>> Since there is always just a single supply clock, there is no need to >>> specify "clock-names" as a required one, please change it. >> >> ??? That's a conversion. Why do you expect changing several DTS files >> and maybe also driver? That's not needed for conversion. No. > > I do not expect changing any DTS files, why? But I would be glad to see that > the clock-names property becomes optional in the first place and therefore > before the conversion. OK, DTS does not have to be changed, but: 1. Old binding said it is required. 2. Kernel depends on this being required. Best regards, Krzysztof
On Wed, 31 Jul 2024 13:15:40 +0530, Animesh Agarwal wrote: > Convert the NXP LPC3220 timer bindings to yaml format. > Add missing resets property as it is already being used in dts. > > Cc: Daniel Baluta <daniel.baluta@nxp.com> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > --- > .../bindings/timer/nxp,lpc3220-timer.txt | 26 --------- > .../bindings/timer/nxp,lpc3220-timer.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 26 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt > create mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt deleted file mode 100644 index 51b05a0e70d1..000000000000 --- a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt +++ /dev/null @@ -1,26 +0,0 @@ -* NXP LPC3220 timer - -The NXP LPC3220 timer is used on a wide range of NXP SoCs. This -includes LPC32xx, LPC178x, LPC18xx and LPC43xx parts. - -Required properties: -- compatible: - Should be "nxp,lpc3220-timer". -- reg: - Address and length of the register set. -- interrupts: - Reference to the timer interrupt -- clocks: - Should contain a reference to timer clock. -- clock-names: - Should contain "timerclk". - -Example: - -timer1: timer@40085000 { - compatible = "nxp,lpc3220-timer"; - reg = <0x40085000 0x1000>; - interrupts = <13>; - clocks = <&ccu1 CLK_CPU_TIMER1>; - clock-names = "timerclk"; -}; diff --git a/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml new file mode 100644 index 000000000000..3ae2eb0625da --- /dev/null +++ b/Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/nxp,lpc3220-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP LPC3220 timer + +maintainers: + - Animesh Agarwal <animeshagarwal28@gmail.com> + +description: | + The NXP LPC3220 timer is used on a wide range of NXP SoCs. This includes + LPC32xx, LPC178x, LPC18xx and LPC43xx parts. + +properties: + compatible: + const: nxp,lpc3220-timer + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: timerclk + + resets: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/lpc32xx-clock.h> + #include <dt-bindings/interrupt-controller/irq.h> + + timer@4004c000 { + compatible = "nxp,lpc3220-timer"; + reg = <0x4004c000 0x1000>; + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; + clocks = <&clk LPC32XX_CLK_TIMER1>; + clock-names = "timerclk"; + };
Convert the NXP LPC3220 timer bindings to yaml format. Add missing resets property as it is already being used in dts. Cc: Daniel Baluta <daniel.baluta@nxp.com> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> --- .../bindings/timer/nxp,lpc3220-timer.txt | 26 --------- .../bindings/timer/nxp,lpc3220-timer.yaml | 55 +++++++++++++++++++ 2 files changed, 55 insertions(+), 26 deletions(-) delete mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/nxp,lpc3220-timer.yaml