| Message ID | 20240806160726.3814576-1-patrick@rivosinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | RISC-V: Fix format-diag warning from improperly formatted url | expand |
On Tue, 06 Aug 2024 09:07:26 PDT (-0700), Patrick O'Neill wrote: > gcc/ChangeLog: > > PR target/116152 > * config/riscv/riscv.cc (riscv_option_override): Fix url > formatting. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/predef-9.c: Update testcase. > > Co-authored-by: Jakub Jelinek <jakub@redhat.com> > Signed-off-by: Patrick O'Neill <patrick@rivosinc.com> > --- > Tested using rv64gc. > --- > gcc/config/riscv/riscv.cc | 4 ++-- > gcc/testsuite/gcc.target/riscv/predef-9.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index b005af62e61..3f7eec8d69e 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -9826,8 +9826,8 @@ riscv_option_override (void) > if (riscv_abi == ABI_LP64E) > { > if (warning (OPT_Wdeprecated, "LP64E ABI is marked for deprecation in GCC")) > - inform (UNKNOWN_LOCATION, "If you need LP64E please notify the GCC " > - "project via https://gcc.gnu.org/PR116152"); > + inform (UNKNOWN_LOCATION, "if you need LP64E please notify the GCC " > + "project via %{PR116152%}", "https://gcc.gnu.org/PR116152"); > } > > /* Zfinx require abi ilp32, ilp32e, lp64 or lp64e. */ > diff --git a/gcc/testsuite/gcc.target/riscv/predef-9.c b/gcc/testsuite/gcc.target/riscv/predef-9.c > index 0d9488529ea..b173d5df57f 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-9.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-9.c > @@ -1,7 +1,7 @@ > /* { dg-do compile } */ > /* { dg-options "-march=rv64em -mabi=lp64e -mno-div -mcmodel=medlow" } */ > /* { dg-warning "LP64E ABI is marked for deprecation in GCC" "" { target *-*-* } 0 } */ > -/* { dg-note "If you need LP64E please notify the GCC project via https://gcc.gnu.org/PR116152" "" { target *-*-* } 0 } */ > +/* { dg-note "if you need LP64E please notify the GCC project via PR116152" "" { target *-*-* } 0 } */ > > int main () { > #if !defined(__riscv) Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com> Thanks!
On 8/6/24 09:12, Palmer Dabbelt wrote: > On Tue, 06 Aug 2024 09:07:26 PDT (-0700), Patrick O'Neill wrote: >> gcc/ChangeLog: >> >> PR target/116152 >> * config/riscv/riscv.cc (riscv_option_override): Fix url >> formatting. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/riscv/predef-9.c: Update testcase. >> >> Co-authored-by: Jakub Jelinek <jakub@redhat.com> >> Signed-off-by: Patrick O'Neill <patrick@rivosinc.com> >> --- >> Tested using rv64gc. >> --- >> gcc/config/riscv/riscv.cc | 4 ++-- >> gcc/testsuite/gcc.target/riscv/predef-9.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc >> index b005af62e61..3f7eec8d69e 100644 >> --- a/gcc/config/riscv/riscv.cc >> +++ b/gcc/config/riscv/riscv.cc >> @@ -9826,8 +9826,8 @@ riscv_option_override (void) >> if (riscv_abi == ABI_LP64E) >> { >> if (warning (OPT_Wdeprecated, "LP64E ABI is marked for >> deprecation in GCC")) >> - inform (UNKNOWN_LOCATION, "If you need LP64E please notify the >> GCC " >> - "project via https://gcc.gnu.org/PR116152"); >> + inform (UNKNOWN_LOCATION, "if you need LP64E please notify the >> GCC " >> + "project via %{PR116152%}", "https://gcc.gnu.org/PR116152"); >> } >> >> /* Zfinx require abi ilp32, ilp32e, lp64 or lp64e. */ >> diff --git a/gcc/testsuite/gcc.target/riscv/predef-9.c >> b/gcc/testsuite/gcc.target/riscv/predef-9.c >> index 0d9488529ea..b173d5df57f 100644 >> --- a/gcc/testsuite/gcc.target/riscv/predef-9.c >> +++ b/gcc/testsuite/gcc.target/riscv/predef-9.c >> @@ -1,7 +1,7 @@ >> /* { dg-do compile } */ >> /* { dg-options "-march=rv64em -mabi=lp64e -mno-div -mcmodel=medlow" >> } */ >> /* { dg-warning "LP64E ABI is marked for deprecation in GCC" "" { >> target *-*-* } 0 } */ >> -/* { dg-note "If you need LP64E please notify the GCC project via >> https://gcc.gnu.org/PR116152" "" { target *-*-* } 0 } */ >> +/* { dg-note "if you need LP64E please notify the GCC project via >> PR116152" "" { target *-*-* } 0 } */ >> >> int main () { >> #if !defined(__riscv) > > Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > Thanks! Committed - thanks! Patrick
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index b005af62e61..3f7eec8d69e 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -9826,8 +9826,8 @@ riscv_option_override (void) if (riscv_abi == ABI_LP64E) { if (warning (OPT_Wdeprecated, "LP64E ABI is marked for deprecation in GCC")) - inform (UNKNOWN_LOCATION, "If you need LP64E please notify the GCC " - "project via https://gcc.gnu.org/PR116152"); + inform (UNKNOWN_LOCATION, "if you need LP64E please notify the GCC " + "project via %{PR116152%}", "https://gcc.gnu.org/PR116152"); } /* Zfinx require abi ilp32, ilp32e, lp64 or lp64e. */ diff --git a/gcc/testsuite/gcc.target/riscv/predef-9.c b/gcc/testsuite/gcc.target/riscv/predef-9.c index 0d9488529ea..b173d5df57f 100644 --- a/gcc/testsuite/gcc.target/riscv/predef-9.c +++ b/gcc/testsuite/gcc.target/riscv/predef-9.c @@ -1,7 +1,7 @@ /* { dg-do compile } */ /* { dg-options "-march=rv64em -mabi=lp64e -mno-div -mcmodel=medlow" } */ /* { dg-warning "LP64E ABI is marked for deprecation in GCC" "" { target *-*-* } 0 } */ -/* { dg-note "If you need LP64E please notify the GCC project via https://gcc.gnu.org/PR116152" "" { target *-*-* } 0 } */ +/* { dg-note "if you need LP64E please notify the GCC project via PR116152" "" { target *-*-* } 0 } */ int main () { #if !defined(__riscv)
gcc/ChangeLog: PR target/116152 * config/riscv/riscv.cc (riscv_option_override): Fix url formatting. gcc/testsuite/ChangeLog: * gcc.target/riscv/predef-9.c: Update testcase. Co-authored-by: Jakub Jelinek <jakub@redhat.com> Signed-off-by: Patrick O'Neill <patrick@rivosinc.com> --- Tested using rv64gc. --- gcc/config/riscv/riscv.cc | 4 ++-- gcc/testsuite/gcc.target/riscv/predef-9.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.34.1