Message ID | 20240213120452.2465425-1-buildroot@bubu1.eu |
---|---|
State | Accepted |
Headers | show |
Series | package/nethogs: new package | expand |
On 13.02.24 13:04, Marcus Hoffmann via buildroot wrote: > Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> > --- > package/Config.in | 1 + > package/nethogs/Config.in | 10 ++++++++++ > package/nethogs/nethogs.hash | 3 +++ > package/nethogs/nethogs.mk | 21 +++++++++++++++++++++ > 4 files changed, 35 insertions(+) > create mode 100644 package/nethogs/Config.in > create mode 100644 package/nethogs/nethogs.hash > create mode 100644 package/nethogs/nethogs.mk > > diff --git a/package/Config.in b/package/Config.in > index bf0fe078b9..2d352dd8cc 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -2476,6 +2476,7 @@ endif > source "package/ndisc6/Config.in" > source "package/net-tools/Config.in" > source "package/netatalk/Config.in" > + source "package/nethogs/Config.in" Oops, that is not quite alphabetically sorted here... > source "package/netcalc/Config.in" > source "package/netcat/Config.in" > source "package/netcat-openbsd/Config.in" > diff --git a/package/nethogs/Config.in b/package/nethogs/Config.in > new file mode 100644 > index 0000000000..2d6b44739c > --- /dev/null > +++ b/package/nethogs/Config.in > @@ -0,0 +1,10 @@ > +config BR2_PACKAGE_NETHOGS > + bool "nethogs" > + select BR2_PACKAGE_LIBPCAP > + select BR2_PACKAGE_NCURSES > + help > + NetHogs is a small 'net top' tool. Instead of breaking the > + traffic down per protocol or per subnet, like most tools > + do, it groups bandwidth by process. > + > + https://github.com/raboof/nethogs > diff --git a/package/nethogs/nethogs.hash b/package/nethogs/nethogs.hash > new file mode 100644 > index 0000000000..fd1f236250 > --- /dev/null > +++ b/package/nethogs/nethogs.hash > @@ -0,0 +1,3 @@ > +# Locally computed > +sha256 957d6afcc220dfbba44c819162f44818051c5b4fb793c47ba98294393986617d nethogs-0.8.7.tar.gz > +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING > diff --git a/package/nethogs/nethogs.mk b/package/nethogs/nethogs.mk > new file mode 100644 > index 0000000000..69dabda191 > --- /dev/null > +++ b/package/nethogs/nethogs.mk > @@ -0,0 +1,21 @@ > +################################################################################ > +# > +# nethogs > +# > +################################################################################ > + > +NETHOGS_VERSION = 0.8.7 > +NETHOGS_SITE = $(call github,raboof,nethogs,v$(NETHOGS_VERSION)) > +NETHOGS_LICENSE = GPL-2.0 > +NETHOGS_LICENSE_FILES = COPYING > +NETHOGS_DEPENDENCIES = libpcap ncurses > + > +define NETHOGS_BUILD_CMDS > + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) nethogs > +endef > + > +define NETHOGS_INSTALL_TARGET_CMDS > + $(INSTALL) -D -m 0755 $(@D)/src/nethogs $(TARGET_DIR)/usr/sbin > +endef > + > +$(eval $(generic-package))
Hello Marcus, On Tue, 13 Feb 2024 13:04:51 +0100 Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote: > Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> Thanks for the patch, which I have applied, after making a few changes. See below. > --- > package/Config.in | 1 + > package/nethogs/Config.in | 10 ++++++++++ > package/nethogs/nethogs.hash | 3 +++ > package/nethogs/nethogs.mk | 21 +++++++++++++++++++++ > 4 files changed, 35 insertions(+) Entry in the DEVELOPERS file was missing. > diff --git a/package/Config.in b/package/Config.in > index bf0fe078b9..2d352dd8cc 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -2476,6 +2476,7 @@ endif > source "package/ndisc6/Config.in" > source "package/net-tools/Config.in" > source "package/netatalk/Config.in" > + source "package/nethogs/Config.in" > source "package/netcalc/Config.in" > source "package/netcat/Config.in" > source "package/netcat-openbsd/Config.in" As you noted in your replied, alphabetic ordering was not correct here. > +NETHOGS_VERSION = 0.8.7 > +NETHOGS_SITE = $(call github,raboof,nethogs,v$(NETHOGS_VERSION)) > +NETHOGS_LICENSE = GPL-2.0 License is GPL-2.0+ (they use the "or later") > +NETHOGS_LICENSE_FILES = COPYING > +NETHOGS_DEPENDENCIES = libpcap ncurses > + > +define NETHOGS_BUILD_CMDS > + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) nethogs > +endef > + > +define NETHOGS_INSTALL_TARGET_CMDS > + $(INSTALL) -D -m 0755 $(@D)/src/nethogs $(TARGET_DIR)/usr/sbin $(TARGET_DIR)/usr/sbin should have been $(TARGET_DIR)/usr/sbin/nethogs, to avoid having 'nethogs' installed as a file called 'sbin' in $(TARGET_DIR)/usr if by lack of luck $(TARGET_DIR)/usr/sbin doesn't already exist as a directory. Thanks a lot for this contribution! Thomas
diff --git a/package/Config.in b/package/Config.in index bf0fe078b9..2d352dd8cc 100644 --- a/package/Config.in +++ b/package/Config.in @@ -2476,6 +2476,7 @@ endif source "package/ndisc6/Config.in" source "package/net-tools/Config.in" source "package/netatalk/Config.in" + source "package/nethogs/Config.in" source "package/netcalc/Config.in" source "package/netcat/Config.in" source "package/netcat-openbsd/Config.in" diff --git a/package/nethogs/Config.in b/package/nethogs/Config.in new file mode 100644 index 0000000000..2d6b44739c --- /dev/null +++ b/package/nethogs/Config.in @@ -0,0 +1,10 @@ +config BR2_PACKAGE_NETHOGS + bool "nethogs" + select BR2_PACKAGE_LIBPCAP + select BR2_PACKAGE_NCURSES + help + NetHogs is a small 'net top' tool. Instead of breaking the + traffic down per protocol or per subnet, like most tools + do, it groups bandwidth by process. + + https://github.com/raboof/nethogs diff --git a/package/nethogs/nethogs.hash b/package/nethogs/nethogs.hash new file mode 100644 index 0000000000..fd1f236250 --- /dev/null +++ b/package/nethogs/nethogs.hash @@ -0,0 +1,3 @@ +# Locally computed +sha256 957d6afcc220dfbba44c819162f44818051c5b4fb793c47ba98294393986617d nethogs-0.8.7.tar.gz +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING diff --git a/package/nethogs/nethogs.mk b/package/nethogs/nethogs.mk new file mode 100644 index 0000000000..69dabda191 --- /dev/null +++ b/package/nethogs/nethogs.mk @@ -0,0 +1,21 @@ +################################################################################ +# +# nethogs +# +################################################################################ + +NETHOGS_VERSION = 0.8.7 +NETHOGS_SITE = $(call github,raboof,nethogs,v$(NETHOGS_VERSION)) +NETHOGS_LICENSE = GPL-2.0 +NETHOGS_LICENSE_FILES = COPYING +NETHOGS_DEPENDENCIES = libpcap ncurses + +define NETHOGS_BUILD_CMDS + $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) nethogs +endef + +define NETHOGS_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/src/nethogs $(TARGET_DIR)/usr/sbin +endef + +$(eval $(generic-package))
Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> --- package/Config.in | 1 + package/nethogs/Config.in | 10 ++++++++++ package/nethogs/nethogs.hash | 3 +++ package/nethogs/nethogs.mk | 21 +++++++++++++++++++++ 4 files changed, 35 insertions(+) create mode 100644 package/nethogs/Config.in create mode 100644 package/nethogs/nethogs.hash create mode 100644 package/nethogs/nethogs.mk