mbox series

[linux,dev-6.6,v1,0/2] Add Nuvoton NPCM845 i3c master driver

Message ID 20240730062122.3781121-1-yschu@nuvoton.com
Headers show
Series Add Nuvoton NPCM845 i3c master driver | expand

Message

Stanley Chu July 30, 2024, 6:21 a.m. UTC 
This patchset adds i3c master support for the Nuvoton
Arbel NPCM8XX Board Management controller (BMC) SoC family.

The Nuvoton npcm845 i3c controller implements I3C master functionality
as defined in the MIPI Alliance Specification for I3C, Version 1.0.

The npcm845 i3c master driver is based on svc i3c master driver and
add platform specific support for the npcm845 hardware.

This patchset was tested on the Arbel NPCM8XX evaluation board.

We will contribute this patchset to torvalds upstream soon.

James Chiang (2):
  dt-bindings: i3c: Add NPCM845 i3c controller
  i3c: master: Add Nuvoton npcm845 i3c master driver

 .../bindings/i3c/nuvoton,i3c-master.yaml      |  113 +
 MAINTAINERS                                   |    7 +
 drivers/i3c/master/Kconfig                    |   14 +
 drivers/i3c/master/Makefile                   |    1 +
 drivers/i3c/master/npcm845-i3c-master.c       | 2372 +++++++++++++++++
 5 files changed, 2507 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i3c/nuvoton,i3c-master.yaml
 create mode 100644 drivers/i3c/master/npcm845-i3c-master.c

Comments

Andrew Jeffery July 31, 2024, 5:14 a.m. UTC | #1 
On Tue, 2024-07-30 at 14:21 +0800, Stanley Chu wrote:
> This patchset adds i3c master support for the Nuvoton
> Arbel NPCM8XX Board Management controller (BMC) SoC family.
> 
> The Nuvoton npcm845 i3c controller implements I3C master functionality
> as defined in the MIPI Alliance Specification for I3C, Version 1.0.
> 
> The npcm845 i3c master driver is based on svc i3c master driver and
> add platform specific support for the npcm845 hardware.
> 
> This patchset was tested on the Arbel NPCM8XX evaluation board.
> 
> We will contribute this patchset to torvalds upstream soon.

Please reply here with the appropriate lore[1] link once you've sent
the equivalent patches upstream. When you've done so, I'll look to
apply these patches to the OpenBMC tree based on the feedback, along
with the OpenBMC-Staging-Count tag.

Thanks,

Andrew

[1]: https://lore.kernel.org/
Andrew Jeffery Aug. 2, 2024, 12:34 a.m. UTC | #2 
On Wed, 2024-07-31 at 14:44 +0930, Andrew Jeffery wrote:
> On Tue, 2024-07-30 at 14:21 +0800, Stanley Chu wrote:
> > This patchset adds i3c master support for the Nuvoton
> > Arbel NPCM8XX Board Management controller (BMC) SoC family.
> > 
> > The Nuvoton npcm845 i3c controller implements I3C master functionality
> > as defined in the MIPI Alliance Specification for I3C, Version 1.0.
> > 
> > The npcm845 i3c master driver is based on svc i3c master driver and
> > add platform specific support for the npcm845 hardware.
> > 
> > This patchset was tested on the Arbel NPCM8XX evaluation board.
> > 
> > We will contribute this patchset to torvalds upstream soon.
> 
> Please reply here with the appropriate lore[1] link once you've sent
> the equivalent patches upstream. When you've done so, I'll look to
> apply these patches to the OpenBMC tree based on the feedback, along
> with the OpenBMC-Staging-Count tag.

Based on the feedback from the thread at [1], I'd prefer to wait until
you've got an Acked-by or Reviewed-by on from the DT maintainers on the
binding.

The driver is less concerning so I think it will be okay to apply that
and do some fixups later, but the binding issues need to be sorted
first.

Andrew

[1]: https://lore.kernel.org/lkml/20240801071946.43266-1-yschu@nuvoton.com/