| Message ID | 20240723092310.3565410-21-Delphine_CC_Chiu@wiwynn.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add i2c-mux and eeprom devices for Meta Yosemite 4 | expand |
On Tue, Jul 23, 2024 at 05:23:01PM +0800, Delphine CC Chiu wrote: > Add ina233/ina28 support for medusa board adc sensors > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 98eeee49b082..49500db53a13 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -915,6 +915,19 @@ power-sensor@40 { > reg = <0x40>; > }; > > + power-sensor@41 { > + compatible = "ti,ina233"; > + resistor-calibration = /bits/ 16 <0x0a00>; > + current-lsb= /bits/ 16 <0x0001>; > + reg = <0x41>; > + }; This depends on this unmerged patchset, right? https://lore.kernel.org/lkml/4a1cb223-448c-3e93-eb38-d86f543659e3@roeck-us.net/ Please resolve the issues Guenter raised. > + > + power-sensor@44 { > + compatible = "ti,ina238"; > + shunt-resistor = <1000>; > + reg = <0x44>; > + }; > + > temperature-sensor@48 { > compatible = "ti,tmp75"; > reg = <0x48>; > -- > 2.25.1 >
On Mon, 2024-07-29 at 17:12 -0500, Patrick Williams wrote: > On Tue, Jul 23, 2024 at 05:23:01PM +0800, Delphine CC Chiu wrote: > > Add ina233/ina28 support for medusa board adc sensors > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > > --- > > .../dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > index 98eeee49b082..49500db53a13 100644 > > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > @@ -915,6 +915,19 @@ power-sensor@40 { > > reg = <0x40>; > > }; > > > > + power-sensor@41 { > > + compatible = "ti,ina233"; > > + resistor-calibration = /bits/ 16 <0x0a00>; > > + current-lsb= /bits/ 16 <0x0001>; > > + reg = <0x41>; > > + }; > > This depends on this unmerged patchset, right? > > https://lore.kernel.org/lkml/4a1cb223-448c-3e93-eb38-d86f543659e3@roeck-us.net/ > > Please resolve the issues Guenter raised. Probably best to drop these nodes until those issues are resolved and the binding patch is merged. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index 98eeee49b082..49500db53a13 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -915,6 +915,19 @@ power-sensor@40 { reg = <0x40>; }; + power-sensor@41 { + compatible = "ti,ina233"; + resistor-calibration = /bits/ 16 <0x0a00>; + current-lsb= /bits/ 16 <0x0001>; + reg = <0x41>; + }; + + power-sensor@44 { + compatible = "ti,ina238"; + shunt-resistor = <1000>; + reg = <0x44>; + }; + temperature-sensor@48 { compatible = "ti,tmp75"; reg = <0x48>;
Add ina233/ina28 support for medusa board adc sensors Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- .../dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)