| Message ID | 20240726-s2r-cdns-v5-2-8664bfb032ac@bootlin.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Fix USB suspend on TI J7200 (cdns3-ti, cdns3, xhci) | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 26 Jul 2024 20:17:50 +0200, Théo Lebrun wrote: > On J7200, the controller & its wrapper are reset on resume. It has the > same behavior as ti,j721e-usb with a different SoC integration. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': [{'const': 'ti,am64-usb'}, {'const': 'ti,j7200-usb'}]}, {'const': 'ti,j721e-usb'}] is not of type 'object' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:1:items:0:enum: 'oneOf' conditional failed, one must be fixed: {'const': 'ti,am64-usb'} is not of type 'integer' {'const': 'ti,am64-usb'} is not of type 'string' {'const': 'ti,j7200-usb'} is not of type 'integer' {'const': 'ti,j7200-usb'} is not of type 'string' hint: "enum" must be an array of either integers or strings from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': [{'const': 'ti,am64-usb'}, {'const': 'ti,j7200-usb'}]}, {'const': 'ti,j721e-usb'}] is not of type 'object' {'const': 'ti,am64-usb'} is not of type 'string' {'const': 'ti,j7200-usb'} is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240726-s2r-cdns-v5-2-8664bfb032ac@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri Jul 26, 2024 at 9:26 PM CEST, Rob Herring (Arm) wrote: > On Fri, 26 Jul 2024 20:17:50 +0200, Théo Lebrun wrote: > > On J7200, the controller & its wrapper are reset on resume. It has the > > same behavior as ti,j721e-usb with a different SoC integration. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > --- > > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: Clearly this patch was wrong. Past me trusted future me to verify and future me trusted past me. Sorry! For reference, new patch content will look like below. This doesn't trigger a warning on: make dt_binding_check DT_SCHEMA_FILES=ti,j721e-usb ------------------------------------------------------------------------ diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml index 653a89586f4e..d14c18b64086 100644 --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml @@ -14,7 +14,9 @@ properties: oneOf: - const: ti,j721e-usb - items: - - const: ti,am64-usb + - enum: + - ti,am64-usb + - ti,j7200-usb - const: ti,j721e-usb reg: ------------------------------------------------------------------------ Regards, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml index 653a89586f4e..038fdf173841 100644 --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml @@ -14,7 +14,9 @@ properties: oneOf: - const: ti,j721e-usb - items: - - const: ti,am64-usb + - enum: + - const: ti,am64-usb + - const: ti,j7200-usb - const: ti,j721e-usb reg:
On J7200, the controller & its wrapper are reset on resume. It has the same behavior as ti,j721e-usb with a different SoC integration. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)