| Message ID | 20240723132958.41320-1-marek.vasut+renesas@mailbox.org |
|---|---|
| Headers | show |
| Series | genirq/msi: Silence set affinity failed warning | expand |
On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote: > Various PCIe controllers that mux MSIs onto single IRQ line produce these > "IRQ%d: set affinity failed" warnings when entering suspend. Remove the > .irq_set_affinity callbacks and make sure they are NULL in all affected > controllers, so this warning in kernel/irq/msi.c is not triggered. > > This has been compile-tested only on all but the R-Car PCI controller. > > The clean ups are done per-driver so they can be easily reverted in case > they break something. > Whole series looks good to me (PCI controller specific patches). FWIW, Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > Marek Vasut (15): > genirq/msi: Silence set affinity failed warning > PCI: aardvark: Silence set affinity failed warning > PCI: altera-msi: Silence set affinity failed warning > PCI: brcmstb: Silence set affinity failed warning > PCI: dwc: Silence set affinity failed warning > PCI: mediatek-gen3: Silence set affinity failed warning > PCI: mediatek: Silence set affinity failed warning > PCI: mobiveil: Silence set affinity failed warning > PCI: plda: Silence set affinity failed warning > PCI: rcar-host: Silence set affinity failed warning > PCI: tegra: Silence set affinity failed warning > PCI: vmd: Silence set affinity failed warning > PCI: xilinx-nwl: Silence set affinity failed warning > PCI: xilinx-xdma: Silence set affinity failed warning > PCI: xilinx: Silence set affinity failed warning > > drivers/pci/controller/dwc/pci-keystone.c | 7 ------- > drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++--------- > .../pci/controller/mobiveil/pcie-mobiveil-host.c | 11 ++--------- > drivers/pci/controller/pci-aardvark.c | 10 ++-------- > drivers/pci/controller/pci-tegra.c | 10 ++-------- > drivers/pci/controller/pcie-altera-msi.c | 11 ++--------- > drivers/pci/controller/pcie-brcmstb.c | 11 ++--------- > drivers/pci/controller/pcie-mediatek-gen3.c | 13 +++---------- > drivers/pci/controller/pcie-mediatek.c | 11 ++--------- > drivers/pci/controller/pcie-rcar-host.c | 10 ++-------- > drivers/pci/controller/pcie-xilinx-dma-pl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx.c | 9 ++------- > drivers/pci/controller/plda/pcie-plda-host.c | 11 ++--------- > drivers/pci/controller/vmd.c | 13 +------------ > include/linux/msi.h | 2 ++ > kernel/irq/msi.c | 2 +- > 17 files changed, 32 insertions(+), 133 deletions(-) > > Cc: "Krzysztof Wilczyński" <kw@linux.com> > Cc: "Pali Rohár" <pali@kernel.org> > Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> > Cc: Aleksandr Mishin <amishin@t-argos.ru> > Cc: Anna-Maria Behnsen <anna-maria@linutronix.de> > Cc: Anup Patel <apatel@ventanamicro.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> > Cc: Daire McNamara <daire.mcnamara@microchip.com> > Cc: Damien Le Moal <dlemoal@kernel.org> > Cc: Florian Fainelli <florian.fainelli@broadcom.com> > Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > Cc: Jianjun Wang <jianjun.wang@mediatek.com> > Cc: Jim Quinlan <jim2101024@gmail.com> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > Cc: Jon Hunter <jonathanh@nvidia.com> > Cc: Jonathan Derrick <jonathan.derrick@linux.dev> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Joyce Ooi <joyce.ooi@intel.com> > Cc: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in> > Cc: Kishon Vijay Abraham I <kishon@kernel.org> > Cc: Koichiro Den <den@valinux.co.jp> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Michal Simek <michal.simek@amd.com> > Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> > Cc: Niklas Cassel <cassel@kernel.org> > Cc: Nipun Gupta <nipun.gupta@amd.com> > Cc: Nirmal Patel <nirmal.patel@linux.intel.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Ryder Lee <ryder.lee@mediatek.com> > Cc: Shivamurthy Shastri <shivamurthy.shastri@linutronix.de> > Cc: Siddharth Vadapalli <s-vadapalli@ti.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-pci@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > > -- > 2.43.0 >
On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote: > Various PCIe controllers that mux MSIs onto single IRQ line produce these > "IRQ%d: set affinity failed" warnings when entering suspend. Remove the > .irq_set_affinity callbacks and make sure they are NULL in all affected > controllers, so this warning in kernel/irq/msi.c is not triggered. > > This has been compile-tested only on all but the R-Car PCI controller. > > The clean ups are done per-driver so they can be easily reverted in case > they break something. > > Marek Vasut (15): > genirq/msi: Silence set affinity failed warning > PCI: aardvark: Silence set affinity failed warning > PCI: altera-msi: Silence set affinity failed warning > PCI: brcmstb: Silence set affinity failed warning > PCI: dwc: Silence set affinity failed warning > PCI: mediatek-gen3: Silence set affinity failed warning > PCI: mediatek: Silence set affinity failed warning > PCI: mobiveil: Silence set affinity failed warning > PCI: plda: Silence set affinity failed warning > PCI: rcar-host: Silence set affinity failed warning > PCI: tegra: Silence set affinity failed warning > PCI: vmd: Silence set affinity failed warning > PCI: xilinx-nwl: Silence set affinity failed warning > PCI: xilinx-xdma: Silence set affinity failed warning > PCI: xilinx: Silence set affinity failed warning Happy to apply this series via the PCI tree given an ack from Thomas. In that event I would rewrap the commit logs to fit in 75 columns and include a note in the driver patches about what event causes the warning. No need to repost for that unless other changes are needed. Thanks for doing this work! Bjorn
On Wed, Jul 24 2024 at 10:43, Bjorn Helgaas wrote: > Happy to apply this series via the PCI tree given an ack from Thomas. Here you go: Acked-by: Thomas Gleixner <tglx@linutronix.de>
On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote: > Various PCIe controllers that mux MSIs onto single IRQ line produce these > "IRQ%d: set affinity failed" warnings when entering suspend. Remove the > .irq_set_affinity callbacks and make sure they are NULL in all affected > controllers, so this warning in kernel/irq/msi.c is not triggered. > > This has been compile-tested only on all but the R-Car PCI controller. > > The clean ups are done per-driver so they can be easily reverted in case > they break something. > > Marek Vasut (15): > genirq/msi: Silence set affinity failed warning > PCI: aardvark: Silence set affinity failed warning > PCI: altera-msi: Silence set affinity failed warning > PCI: brcmstb: Silence set affinity failed warning > PCI: dwc: Silence set affinity failed warning > PCI: mediatek-gen3: Silence set affinity failed warning > PCI: mediatek: Silence set affinity failed warning > PCI: mobiveil: Silence set affinity failed warning > PCI: plda: Silence set affinity failed warning > PCI: rcar-host: Silence set affinity failed warning > PCI: tegra: Silence set affinity failed warning > PCI: vmd: Silence set affinity failed warning > PCI: xilinx-nwl: Silence set affinity failed warning > PCI: xilinx-xdma: Silence set affinity failed warning > PCI: xilinx: Silence set affinity failed warning > > drivers/pci/controller/dwc/pci-keystone.c | 7 ------- > drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++--------- > .../pci/controller/mobiveil/pcie-mobiveil-host.c | 11 ++--------- > drivers/pci/controller/pci-aardvark.c | 10 ++-------- > drivers/pci/controller/pci-tegra.c | 10 ++-------- > drivers/pci/controller/pcie-altera-msi.c | 11 ++--------- > drivers/pci/controller/pcie-brcmstb.c | 11 ++--------- > drivers/pci/controller/pcie-mediatek-gen3.c | 13 +++---------- > drivers/pci/controller/pcie-mediatek.c | 11 ++--------- > drivers/pci/controller/pcie-rcar-host.c | 10 ++-------- > drivers/pci/controller/pcie-xilinx-dma-pl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- > drivers/pci/controller/pcie-xilinx.c | 9 ++------- > drivers/pci/controller/plda/pcie-plda-host.c | 11 ++--------- > drivers/pci/controller/vmd.c | 13 +------------ > include/linux/msi.h | 2 ++ > kernel/irq/msi.c | 2 +- > 17 files changed, 32 insertions(+), 133 deletions(-) Applied to pci/controller/affinity for v6.11, thank you very much for doing this work! I pushed this branch, but it won't show up in linux-next until after v6.12-rc1 is tagged.