| Message ID | 20240725153711.16101-3-five231003@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ti: davinci, keystone: txt to yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 52 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 25/07/2024 17:03, Kousik Sanagavarapu wrote: > Convert txt bindings of TI's DaVinci/Keystone Watchdog Timer Controller > to dtschema to allow for validation. > > While at it, change the order of the compatibles w.r.t. the txt binding > to stay in sync with the existing DTS. ... and add power-domains property, because it is used somwhere? > > Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com> > --- > .../bindings/watchdog/davinci-wdt.txt | 24 --------- > .../bindings/watchdog/ti,davinci-wdt.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 24 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > deleted file mode 100644 > index aa10b8ec36e2..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > +++ /dev/null > @@ -1,24 +0,0 @@ > -Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller > - ... > + - Kousik Sanagavarapu <five231003@gmail.com> > + > +description: | > + TI's Watchdog Timer Controller for DaVinci and Keystone Processors. > + > + Datasheets > + > + Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf > + Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + items: > + - const: ti,keystone-wdt > + - const: ti,davinci-wdt Validate the DTS - you will see this is wrong. You miss davinci standing alone (so oneOf). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt deleted file mode 100644 index aa10b8ec36e2..000000000000 --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt +++ /dev/null @@ -1,24 +0,0 @@ -Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller - -Required properties: -- compatible : Should be "ti,davinci-wdt", "ti,keystone-wdt" -- reg : Should contain WDT registers location and length - -Optional properties: -- timeout-sec : Contains the watchdog timeout in seconds -- clocks : the clock feeding the watchdog timer. - Needed if platform uses clocks. - See clock-bindings.txt - -Documentation: -Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf -Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf - -Examples: - -wdt: wdt@2320000 { - compatible = "ti,davinci-wdt"; - reg = <0x02320000 0x80>; - timeout-sec = <30>; - clocks = <&clkwdtimer0>; -}; diff --git a/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml new file mode 100644 index 000000000000..f1413e7370a1 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci/Keystone Watchdog Timer Controller + +maintainers: + - Kousik Sanagavarapu <five231003@gmail.com> + +description: | + TI's Watchdog Timer Controller for DaVinci and Keystone Processors. + + Datasheets + + Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf + Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + items: + - const: ti,keystone-wdt + - const: ti,davinci-wdt + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + wdt: watchdog@22f0080 { + compatible = "ti,keystone-wdt", "ti,davinci-wdt"; + reg = <0x022f0080 0x80>; + clocks = <&clkwdtimer0>; + }; + +...
Convert txt bindings of TI's DaVinci/Keystone Watchdog Timer Controller to dtschema to allow for validation. While at it, change the order of the compatibles w.r.t. the txt binding to stay in sync with the existing DTS. Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com> --- .../bindings/watchdog/davinci-wdt.txt | 24 --------- .../bindings/watchdog/ti,davinci-wdt.yaml | 52 +++++++++++++++++++ 2 files changed, 52 insertions(+), 24 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/davinci-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml