diff mbox series

[1/1] package/libressl: fix mips64el build

Message ID 20240725113943.1761962-1-fontaine.fabrice@gmail.com
State Changes Requested
Headers show
Series [1/1] package/libressl: fix mips64el build | expand

Commit Message

Fabrice Fontaine July 25, 2024, 11:39 a.m. UTC
Disable assembly with mips64el to avoid the following build failure
raised since bump to version 3.8.2 in commit
21eca49ed5110872407b76ab9337d2877c4cda24:

/home/autobuild/autobuild/instance-21/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-gnu/13.2.0/../../../../mips64el-buildroot-linux-gnu/bin/ld: ../../crypto/libcrypto.so.52.0.0: undefined reference to `bn_mul_words'

Fixes: 21eca49ed5110872407b76ab9337d2877c4cda24
 - http://autobuild.buildroot.org/results/09b86c95ea1054d5f54d4ef4a041eb105c3f4aa9

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libressl/libressl.mk | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni July 25, 2024, 3:41 p.m. UTC | #1
On Thu, 25 Jul 2024 13:39:43 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disable assembly with mips64el to avoid the following build failure
> raised since bump to version 3.8.2 in commit
> 21eca49ed5110872407b76ab9337d2877c4cda24:
> 
> /home/autobuild/autobuild/instance-21/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-gnu/13.2.0/../../../../mips64el-buildroot-linux-gnu/bin/ld: ../../crypto/libcrypto.so.52.0.0: undefined reference to `bn_mul_words'
> 
> Fixes: 21eca49ed5110872407b76ab9337d2877c4cda24
>  - http://autobuild.buildroot.org/results/09b86c95ea1054d5f54d4ef4a041eb105c3f4aa9
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Could you track down a bit more precisely what is going on, i.e which
upstream commit broke this? I don't immediately see something relevant.
6501696dd7669b3d20d69beffc508c46f0a807da was already in v3.7.3 that we
were using prior to the bump in
21eca49ed5110872407b76ab9337d2877c4cda24.

Do you have some evidence that only BR2_mips64el is impacted, and not
BR2_mips64 (i.e big endian MIPS64) ?

Thanks,

Thomas
diff mbox series

Patch

diff --git a/package/libressl/libressl.mk b/package/libressl/libressl.mk
index 1d90aa853d..edf3ef9d0e 100644
--- a/package/libressl/libressl.mk
+++ b/package/libressl/libressl.mk
@@ -19,4 +19,10 @@  endef
 LIBRESSL_POST_INSTALL_TARGET_HOOKS += LIBRESSL_REMOVE_BIN
 endif
 
+ifeq ($(BR2_mips64el),)
+LIBRESSL_CONF_OPTS += -DENABLE_ASM=ON
+else
+LIBRESSL_CONF_OPTS += -DENABLE_ASM=OFF
+endif
+
 $(eval $(cmake-package))