diff mbox series

[1/1] package/btrfs-progs: don't install host udev files

Message ID 20240724085302.1821942-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/btrfs-progs: don't install host udev files | expand

Commit Message

Fabrice Fontaine July 24, 2024, 8:53 a.m. UTC
Pass an empty value for udevdir to avoid the following host build
failure on one of the autobuilders:

/usr/bin/install -c -m755 -d /usr/lib/udev/rules.d
/usr/bin/install -c -m644 64-btrfs-dm.rules 64-btrfs-zoned.rules /usr/lib/udev/rules.d
/usr/bin/install: cannot create regular file '/usr/lib/udev/rules.d/64-btrfs-dm.rules': Permission denied
/usr/bin/install: cannot create regular file '/usr/lib/udev/rules.d/64-btrfs-zoned.rules': Permission denied

This build failure can be raised since the addition of the host variant
in commit ed69859a7261ee86e71aa666d30a28e374769e15. udev rules were
added by upstream in 2016 by
https://github.com/kdave/btrfs-progs/commit/62c0666378eb70285b6a3052bf4144d2132a5891

Fixes: ed69859a7261ee86e71aa666d30a28e374769e15
 - http://autobuild.buildroot.org/results/c46238afe8d23cf4bff4e7290a5eaebd0640eb6e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/btrfs-progs/btrfs-progs.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni July 24, 2024, 4:29 p.m. UTC | #1
On Wed, 24 Jul 2024 10:53:02 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Pass an empty value for udevdir to avoid the following host build
> failure on one of the autobuilders:
> 
> /usr/bin/install -c -m755 -d /usr/lib/udev/rules.d
> /usr/bin/install -c -m644 64-btrfs-dm.rules 64-btrfs-zoned.rules /usr/lib/udev/rules.d
> /usr/bin/install: cannot create regular file '/usr/lib/udev/rules.d/64-btrfs-dm.rules': Permission denied
> /usr/bin/install: cannot create regular file '/usr/lib/udev/rules.d/64-btrfs-zoned.rules': Permission denied
> 
> This build failure can be raised since the addition of the host variant
> in commit ed69859a7261ee86e71aa666d30a28e374769e15. udev rules were
> added by upstream in 2016 by
> https://github.com/kdave/btrfs-progs/commit/62c0666378eb70285b6a3052bf4144d2132a5891
> 
> Fixes: ed69859a7261ee86e71aa666d30a28e374769e15
>  - http://autobuild.buildroot.org/results/c46238afe8d23cf4bff4e7290a5eaebd0640eb6e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/btrfs-progs/btrfs-progs.mk | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas
Peter Korsgaard Aug. 31, 2024, 5:13 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Pass an empty value for udevdir to avoid the following host build
 > failure on one of the autobuilders:

 > /usr/bin/install -c -m755 -d /usr/lib/udev/rules.d
 > /usr/bin/install -c -m644 64-btrfs-dm.rules 64-btrfs-zoned.rules /usr/lib/udev/rules.d
 > /usr/bin/install: cannot create regular file '/usr/lib/udev/rules.d/64-btrfs-dm.rules': Permission denied
 > /usr/bin/install: cannot create regular file '/usr/lib/udev/rules.d/64-btrfs-zoned.rules': Permission denied

 > This build failure can be raised since the addition of the host variant
 > in commit ed69859a7261ee86e71aa666d30a28e374769e15. udev rules were
 > added by upstream in 2016 by
 > https://github.com/kdave/btrfs-progs/commit/62c0666378eb70285b6a3052bf4144d2132a5891

 > Fixes: ed69859a7261ee86e71aa666d30a28e374769e15
 >  - http://autobuild.buildroot.org/results/c46238afe8d23cf4bff4e7290a5eaebd0640eb6e

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x and 2024.05.x, thanks.
diff mbox series

Patch

diff --git a/package/btrfs-progs/btrfs-progs.mk b/package/btrfs-progs/btrfs-progs.mk
index 800c0e3082..69424a2d72 100644
--- a/package/btrfs-progs/btrfs-progs.mk
+++ b/package/btrfs-progs/btrfs-progs.mk
@@ -62,5 +62,7 @@  HOST_BTRFS_PROGS_CONF_OPTS = \
 	--disable-python \
 	--disable-convert
 
+HOST_BTRFS_PROGS_INSTALL_OPTS = udevdir= install
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))