| Message ID | 20240719120853.1924771-7-m.majewski2@samsung.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add initial Exynos 850 support to the thermal driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 13 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Jul 19, 2024 at 7:10 AM Mateusz Majewski <m.majewski2@samsung.com> wrote: > > This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use > set_trips ops"). > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > .../bindings/thermal/samsung,exynos-thermal.yaml | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > index 4363ee625339..5a82764a4dbb 100644 > --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > @@ -40,11 +40,8 @@ properties: > interrupts: > description: | > The Exynos TMU supports generating interrupts when reaching given > - temperature thresholds. Number of supported thermal trip points depends > - on the SoC (only first trip points defined in DT will be configured):: > - - most of SoC: 4 > - - samsung,exynos5433-tmu: 8 > - - samsung,exynos7-tmu: 8 > + temperature thresholds. The trip points will be set dynamically in > + runtime, which means there is no limit on the number of trip points. > maxItems: 1 > > reg: > -- > 2.45.1 > >
On Fri, Jul 19, 2024 at 02:08:50PM +0200, Mateusz Majewski wrote: > This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use > set_trips ops"). > > Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> > --- > .../bindings/thermal/samsung,exynos-thermal.yaml | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > index 4363ee625339..5a82764a4dbb 100644 > --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml > @@ -40,11 +40,8 @@ properties: > interrupts: > description: | > The Exynos TMU supports generating interrupts when reaching given > - temperature thresholds. Number of supported thermal trip points depends > - on the SoC (only first trip points defined in DT will be configured):: > - - most of SoC: 4 > - - samsung,exynos5433-tmu: 8 > - - samsung,exynos7-tmu: 8 > + temperature thresholds. The trip points will be set dynamically in > + runtime, which means there is no limit on the number of trip points. How can the hardware change how many trip points it supports? > maxItems: 1 > > reg: > -- > 2.45.1 >
Hi :) > > + temperature thresholds. The trip points will be set dynamically in > > + runtime, which means there is no limit on the number of trip points. > > How can the hardware change how many trip points it supports? Would just removing the whole "The trip points..." sentence be ok? I see how it is more confusing than helpful.
On Tue, Jul 23, 2024 at 04:17:14PM +0200, Mateusz Majewski wrote: > Hi :) > > > > + temperature thresholds. The trip points will be set dynamically in > > > + runtime, which means there is no limit on the number of trip points. > > > > How can the hardware change how many trip points it supports? > > Would just removing the whole "The trip points..." sentence be ok? I see > how it is more confusing than helpful. If the old text had nothing to do with the h/w, then I suppose so. I would have assumed the h/w supports some number of thresholds causing some action whether an interrupt or some sort of shutdown. Rob
> If the old text had nothing to do with the h/w, then I suppose so. I > would have assumed the h/w supports some number of thresholds causing > some action whether an interrupt or some sort of shutdown. That is true, but after the mentioned change only 3 are used at the time: one lower than current temperature, one higher than current temperature, and one for the critical temperature. So, from the perspective of somebody writing the devicetree source file this limit is probably irrelevant?
diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml index 4363ee625339..5a82764a4dbb 100644 --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml @@ -40,11 +40,8 @@ properties: interrupts: description: | The Exynos TMU supports generating interrupts when reaching given - temperature thresholds. Number of supported thermal trip points depends - on the SoC (only first trip points defined in DT will be configured):: - - most of SoC: 4 - - samsung,exynos5433-tmu: 8 - - samsung,exynos7-tmu: 8 + temperature thresholds. The trip points will be set dynamically in + runtime, which means there is no limit on the number of trip points. maxItems: 1 reg:
This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use set_trips ops"). Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> --- .../bindings/thermal/samsung,exynos-thermal.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)