Message ID | ZpY3X1tggZC3s_1X@shikoro |
---|---|
State | Rejected |
Headers | show |
Series | [PULL,REQUEST] i2c-for-6.11-rc1 | expand |
On Tue, 16 Jul 2024 at 02:03, Wolfram Sang <wsa@kernel.org> wrote: > > Most changes are in the merged requests for I2C host drivers and the > at24 eeprom driver with their own explanations there. Please don't do this. What's the point of saying "all the explanations are somewhere else". That's not the point of a pull request. *I NEED TO KNOW*. The explanation is why I would pull - without that explanation, why should I bother with a deficient pull request? Because this all is the whole point of a pull request, for chrissake! You are requesting me to pull, and dammit, that means that you should explain *WHY* I should pull. Not this "there's an explanation for this elsewhere" crap. That just makes me go "ok, so what, this pull request is garbage". I have looked up said explanations, but next time I need to go look for explanations I'm just going to ignore the pull request as clearly just not worth bothering with. Because I'm not AT ALL interested in getting pull requests that basically say "I'm not going to even bother telling you why to pull". And if you can't see that, I don't know what to say. Linus
On Wed, 17 Jul 2024 at 17:22, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > I have looked up said explanations, but next time I need to go look > for explanations I'm just going to ignore the pull request as clearly > just not worth bothering with. Actually, I looked more, and that's just part of it. There are other merges in there too, and this just pisses me off. If you can't be bothered to then write a summary for what the different merges do, I can't be bothered to pull it all. Linus
Linus, > > I have looked up said explanations, but next time I need to go look > > for explanations I'm just going to ignore the pull request as clearly > > just not worth bothering with. Okay, I got the first part. My reasoning was that the summaries from the merges I pulled in were excellent and I could not add something to it *plus* I was assuming you skim through the patches you pull anyhow. But I can see that you want to know *before* you pull something. I will send you an updated PR. > There are other merges in there too, and this just pisses me off. That part I do not get: $ git log --pretty=oneline master..i2c/for-mergewindow | grep Merge 479f18ccca110b727d99c2db60d769736bf390e6 Merge tag 'i2c-host-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux into i2c/for-mergewindow 711703013e340caac3e4a6a3a605324691292621 Merge tag 'at24-updates-for-v6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux into i2c/for-mergewindow These two merges I mentioned. What others are in there? Regards, Wolfram
On Wed, 17 Jul 2024 at 23:16, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > > There are other merges in there too, and this just pisses me off. > > That part I do not get: That was me having looked at the list in one of the merges, getting ready to try to sort it out, and then noticing that there was *another* set of changes entirely (admittedly apparently much smaller). And at that point just going "I have another 50 pull requests pending, I'm going to skip having to figure this one out". Linus
The pull request you sent on Tue, 16 Jul 2024 11:03:27 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git tags/i2c-for-6.11-rc1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ef035628c326af9aa645af1b91fbb72fdfec874e
Thank you!