diff mbox series

[1/3] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02

Message ID 20240718184434.6307-1-robdclark@gmail.com
State Superseded
Headers show
Series [1/3] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied fail build log

Commit Message

Rob Clark July 18, 2024, 6:44 p.m. UTC 
From: Rob Clark <robdclark@chromium.org>

The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the
existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml   | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dmitry Baryshkov July 18, 2024, 9:35 p.m. UTC | #1 
On Thu, Jul 18, 2024 at 11:44:32AM GMT, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the
> existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>  .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
> index d668e8d0d296..284a4ee79bbf 100644
> --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
> @@ -19,6 +19,8 @@ properties:
>        - samsung,atna33xc20
>        # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel
>        - samsung,atna45af01
> +      # Samsung 14.5" 3K (2944x1840 pixels) eDP AMOLED panel
> +      - samsung,atna45dc02

This makes me wonder if we should define a cover compatible like
samsung,amoled-edp-panel.

>  
>    enable-gpios: true
>    port: true
> -- 
> 2.45.2
>
Konrad Dybcio July 18, 2024, 10:36 p.m. UTC | #2 
On 18.07.2024 8:44 PM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> Use the correct panel compatible, and wire up enable-gpio.  It is wired
> up in the same way as the x1e80100-crd.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Doug Anderson July 18, 2024, 11:09 p.m. UTC | #3 
Hi,

On Thu, Jul 18, 2024 at 2:36 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Thu, Jul 18, 2024 at 11:44:32AM GMT, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the
> > existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> >  .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml   | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
> > index d668e8d0d296..284a4ee79bbf 100644
> > --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
> > @@ -19,6 +19,8 @@ properties:
> >        - samsung,atna33xc20
> >        # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel
> >        - samsung,atna45af01
> > +      # Samsung 14.5" 3K (2944x1840 pixels) eDP AMOLED panel
> > +      - samsung,atna45dc02

Please follow what we decided in Stephan Gerhold's case and use a
fallback compatible. In other words: your patch seems to be based on
his v1 and not his v2.

> This makes me wonder if we should define a cover compatible like
> samsung,amoled-edp-panel.

I will bow to the wisdom of the DT folks, but my understanding is that
we shouldn't do that. The fallback compatible can just be the
compatible of the first panel that we supported that used the same
interface.

-Doug
Doug Anderson July 18, 2024, 11:11 p.m. UTC | #4 
Hi,

On Thu, Jul 18, 2024 at 11:44 AM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> Use the correct panel compatible, and wire up enable-gpio.  It is wired
> up in the same way as the x1e80100-crd.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>  .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index f569f0fbd1fc..37ef05f8c7e0 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -592,9 +592,13 @@ &mdss_dp3 {
>
>         aux-bus {
>                 panel {
> -                       compatible = "edp-panel";
> +                       compatible = "samsung,atna45dc02";

Instead of the above, I believe you should use:

compatible = "samsung,atna45dc02", "samsung,atna33xc20";

...which makes the dts work without any code changes. This is what we
decided upon for Stephen's panel [0]

[0] https://lore.kernel.org/r/20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org/

-Doug
Rob Clark July 19, 2024, 2:31 a.m. UTC | #5 
On Thu, Jul 18, 2024 at 4:12 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Thu, Jul 18, 2024 at 11:44 AM Rob Clark <robdclark@gmail.com> wrote:
> >
> > From: Rob Clark <robdclark@chromium.org>
> >
> > Use the correct panel compatible, and wire up enable-gpio.  It is wired
> > up in the same way as the x1e80100-crd.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> >  .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > index f569f0fbd1fc..37ef05f8c7e0 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> > @@ -592,9 +592,13 @@ &mdss_dp3 {
> >
> >         aux-bus {
> >                 panel {
> > -                       compatible = "edp-panel";
> > +                       compatible = "samsung,atna45dc02";
>
> Instead of the above, I believe you should use:
>
> compatible = "samsung,atna45dc02", "samsung,atna33xc20";
>
> ...which makes the dts work without any code changes. This is what we
> decided upon for Stephen's panel [0]

sure, that sounds reasonable.. I only saw the first version because
that is what is in the x1e80100-next branch atm

BR,
-R

> [0] https://lore.kernel.org/r/20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org/
>
> -Doug
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
index d668e8d0d296..284a4ee79bbf 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
@@ -19,6 +19,8 @@  properties:
       - samsung,atna33xc20
       # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel
       - samsung,atna45af01
+      # Samsung 14.5" 3K (2944x1840 pixels) eDP AMOLED panel
+      - samsung,atna45dc02
 
   enable-gpios: true
   port: true