mbox series

[SRU,jammy:linux-xilinx-zynqmp,0/1] Revert DMA locking fix in favor of upstream commit

Message ID 20240716181232.72155-1-portia.stephens@canonical.com
Headers show
Series Revert DMA locking fix in favor of upstream commit | expand

Message

Portia Stephens July 16, 2024, 6:12 p.m. UTC
[ Impact ]
* The KV260 is currently unable to boot, this will allow the board to boot.

[ Test Plan ]
* Normal certification and kernel regression testing will be run on all GM'd
platforms. The failure was catestrophic and was easily caught.

[ Where problems could occur ]
* Xilinx has changes to the dmaengine driver that have not been upstreamed,:
specifically adding support for cyclic dma mode.  There is a risk that these
non-upstreamed changes have not been tested with this change.

[ Other Info ]
* BugLink: https://bugs.launchpad.net/bugs/2072456
* Upstream state in original commit was incorrect.
* Upstream commit "dma: xilinx_dpdma: Fix locking"

Portia Stephens (1):
  Revert "dmaengine: xilinx: dpdma: Fix race condition in vsync IRQ"

 drivers/dma/xilinx/xilinx_dpdma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kevin Becker July 16, 2024, 7:11 p.m. UTC | #1
On Tue, Jul 16, 2024 at 2:13 PM Portia Stephens
<portia.stephens@canonical.com> wrote:
>
> [ Impact ]
> * The KV260 is currently unable to boot, this will allow the board to boot.
>
> [ Test Plan ]
> * Normal certification and kernel regression testing will be run on all GM'd
> platforms. The failure was catestrophic and was easily caught.
>
> [ Where problems could occur ]
> * Xilinx has changes to the dmaengine driver that have not been upstreamed,:
> specifically adding support for cyclic dma mode.  There is a risk that these
> non-upstreamed changes have not been tested with this change.
>
> [ Other Info ]
> * BugLink: https://bugs.launchpad.net/bugs/2072456
> * Upstream state in original commit was incorrect.
> * Upstream commit "dma: xilinx_dpdma: Fix locking"
>
> Portia Stephens (1):
>   Revert "dmaengine: xilinx: dpdma: Fix race condition in vsync IRQ"
>
>  drivers/dma/xilinx/xilinx_dpdma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> --

Acked-by: Kevin Becker <kevin.becker@canonical.com>
Manuel Diewald July 16, 2024, 7:15 p.m. UTC | #2
On Tue, Jul 16, 2024 at 02:12:31PM -0400, Portia Stephens wrote:
> [ Impact ]
> * The KV260 is currently unable to boot, this will allow the board to boot.
> 
> [ Test Plan ]
> * Normal certification and kernel regression testing will be run on all GM'd
> platforms. The failure was catestrophic and was easily caught.
> 
> [ Where problems could occur ]
> * Xilinx has changes to the dmaengine driver that have not been upstreamed,:
> specifically adding support for cyclic dma mode.  There is a risk that these
> non-upstreamed changes have not been tested with this change.
> 
> [ Other Info ]
> * BugLink: https://bugs.launchpad.net/bugs/2072456
> * Upstream state in original commit was incorrect.
> * Upstream commit "dma: xilinx_dpdma: Fix locking"
> 
> Portia Stephens (1):
>   Revert "dmaengine: xilinx: dpdma: Fix race condition in vsync IRQ"
> 
>  drivers/dma/xilinx/xilinx_dpdma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Upstream commit came with v5.15.158 upstream stable update.

Please copy the SRU template from the cover letter to the launchpad bug.

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Portia Stephens July 17, 2024, 5:01 p.m. UTC | #3
On Tue, Jul 16, 2024 at 3:15 PM Manuel Diewald
<manuel.diewald@canonical.com> wrote:
>
> On Tue, Jul 16, 2024 at 02:12:31PM -0400, Portia Stephens wrote:
> > [ Impact ]
> > * The KV260 is currently unable to boot, this will allow the board to boot.
> >
> > [ Test Plan ]
> > * Normal certification and kernel regression testing will be run on all GM'd
> > platforms. The failure was catestrophic and was easily caught.
> >
> > [ Where problems could occur ]
> > * Xilinx has changes to the dmaengine driver that have not been upstreamed,:
> > specifically adding support for cyclic dma mode.  There is a risk that these
> > non-upstreamed changes have not been tested with this change.
> >
> > [ Other Info ]
> > * BugLink: https://bugs.launchpad.net/bugs/2072456
> > * Upstream state in original commit was incorrect.
> > * Upstream commit "dma: xilinx_dpdma: Fix locking"
> >
> > Portia Stephens (1):
> >   Revert "dmaengine: xilinx: dpdma: Fix race condition in vsync IRQ"
> >
> >  drivers/dma/xilinx/xilinx_dpdma.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > --
> > 2.34.1
> >
> >
> > --
> > kernel-team mailing list
> > kernel-team@lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
> Upstream commit came with v5.15.158 upstream stable update.
>
> Please copy the SRU template from the cover letter to the launchpad bug.

Done.

>
> Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
>
> --
>  Manuel
Portia Stephens July 17, 2024, 5:03 p.m. UTC | #4
On Tue, Jul 16, 2024 at 2:12 PM Portia Stephens
<portia.stephens@canonical.com> wrote:
>
> [ Impact ]
> * The KV260 is currently unable to boot, this will allow the board to boot.
>
> [ Test Plan ]
> * Normal certification and kernel regression testing will be run on all GM'd
> platforms. The failure was catestrophic and was easily caught.
>
> [ Where problems could occur ]
> * Xilinx has changes to the dmaengine driver that have not been upstreamed,:
> specifically adding support for cyclic dma mode.  There is a risk that these
> non-upstreamed changes have not been tested with this change.
>
> [ Other Info ]
> * BugLink: https://bugs.launchpad.net/bugs/2072456
> * Upstream state in original commit was incorrect.
> * Upstream commit "dma: xilinx_dpdma: Fix locking"
>
> Portia Stephens (1):
>   Revert "dmaengine: xilinx: dpdma: Fix race condition in vsync IRQ"
>
>  drivers/dma/xilinx/xilinx_dpdma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> --
> 2.34.1
>