diff mbox series

[v1,2/2] odroid: Fix target platform compilation issue on Odroid-XU3

Message ID 20240626151522.83561-2-linux.amoon@gmail.com
State Accepted
Commit eebfbe1be72941b67e36d8a870cf636ecfbacb37
Delegated to: Minkyu Kang
Headers show
Series [v1,1/2] dm: exynos: Correct CONFIG_SYS_BOARD setting for Odroid XU3 boards | expand

Commit Message

Anand Moon June 26, 2024, 3:15 p.m. UTC
Resolved a compilation issue where the build system attempted
to compile for the Odroid-XU3 platform instead of the specified
Exynos4412 platform due to an incorrect CONFIG_SYS_BOARD setting.
Updated the Makefile to ensure that compilation only occurs for
the Odroid-XU3 specified target platform.

Now, object files will be generated only when building for the
TARGET_ODROID platform.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Tested om Odroid-U3 and Odroid-XU4.
---
 board/samsung/odroid/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sam Protsenko June 26, 2024, 3:39 p.m. UTC | #1
On Wed, Jun 26, 2024 at 10:15 AM Anand Moon <linux.amoon@gmail.com> wrote:
>
> Resolved a compilation issue where the build system attempted
> to compile for the Odroid-XU3 platform instead of the specified
> Exynos4412 platform due to an incorrect CONFIG_SYS_BOARD setting.
> Updated the Makefile to ensure that compilation only occurs for
> the Odroid-XU3 specified target platform.
>
> Now, object files will be generated only when building for the
> TARGET_ODROID platform.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> Tested om Odroid-U3 and Odroid-XU4.
> ---
>  board/samsung/odroid/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/samsung/odroid/Makefile b/board/samsung/odroid/Makefile
> index 5bf48313de..615c99f501 100644
> --- a/board/samsung/odroid/Makefile
> +++ b/board/samsung/odroid/Makefile
> @@ -3,4 +3,4 @@
>  # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
>  # Przemyslaw Marczak <p.marczak@samsung.com>
>
> -obj-y  := odroid.o
> +obj-$(CONFIG_TARGET_ODROID)    := odroid.o
> --
> 2.44.0
>
Minkyu Kang July 17, 2024, 2:24 a.m. UTC | #2
Hi,


2024년 6월 27일 (목) 00:41, Anand Moon <linux.amoon@gmail.com>님이 작성:

> Resolved a compilation issue where the build system attempted
> to compile for the Odroid-XU3 platform instead of the specified
> Exynos4412 platform due to an incorrect CONFIG_SYS_BOARD setting.
> Updated the Makefile to ensure that compilation only occurs for
> the Odroid-XU3 specified target platform.
>
> Now, object files will be generated only when building for the
> TARGET_ODROID platform.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Tested om Odroid-U3 and Odroid-XU4.
> ---
>  board/samsung/odroid/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/samsung/odroid/Makefile b/board/samsung/odroid/Makefile
> index 5bf48313de..615c99f501 100644
> --- a/board/samsung/odroid/Makefile
> +++ b/board/samsung/odroid/Makefile
> @@ -3,4 +3,4 @@
>  # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
>  # Przemyslaw Marczak <p.marczak@samsung.com>
>
> -obj-y  := odroid.o
> +obj-$(CONFIG_TARGET_ODROID)    := odroid.o
> --
> 2.44.0
>

applied to u-boot-samsung.

Thanks.
Minkyu Kang.
diff mbox series

Patch

diff --git a/board/samsung/odroid/Makefile b/board/samsung/odroid/Makefile
index 5bf48313de..615c99f501 100644
--- a/board/samsung/odroid/Makefile
+++ b/board/samsung/odroid/Makefile
@@ -3,4 +3,4 @@ 
 # Copyright (c) 2014 Samsung Electronics Co., Ltd. All rights reserved.
 # Przemyslaw Marczak <p.marczak@samsung.com>
 
-obj-y	:= odroid.o
+obj-$(CONFIG_TARGET_ODROID)	:= odroid.o