mbox series

[v1,0/7] pinctrl: npcm8xx: pin configuration changes

Message ID 20240711193749.2397471-1-tmaimon77@gmail.com
Headers show
Series pinctrl: npcm8xx: pin configuration changes | expand

Message

Tomer Maimon July 11, 2024, 7:37 p.m. UTC 
This patch set addresses various pin configuration changes for the 
Nuvoton NPCM8XX BMC SoC. The patches aim to enhance functionality, 
remove unused pins, and improve overall pin management. 

Tomer Maimon (7):
  pinctrl: nuvoton: npcm8xx: clear polarity before set both edge
  pinctrl: nuvoton: npcm8xx: add gpi35 and gpi36
  pinctrl: nuvoton: npcm8xx: add pin 250 to DDR pins group
  pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function
  pinctrl: nuvoton: npcm8xx: remove unused lpcclk pin, group, function
  pinctrl: nuvoton: npcm8xx: modify clkrun and serirq pin configuration
  pinctrl: nuvoton: npcm8xx: modify pins flags

 drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 64 +++++++++++------------
 1 file changed, 31 insertions(+), 33 deletions(-)

Comments

Jonas Gorski July 13, 2024, 12:35 p.m. UTC | #1 
Hi,

On Fri, 12 Jul 2024 at 02:48, Tomer Maimon <tmaimon77@gmail.com> wrote:
>
> This patch set addresses various pin configuration changes for the
> Nuvoton NPCM8XX BMC SoC. The patches aim to enhance functionality,
> remove unused pins, and improve overall pin management.
>
> Tomer Maimon (7):
>   pinctrl: nuvoton: npcm8xx: clear polarity before set both edge
>   pinctrl: nuvoton: npcm8xx: add gpi35 and gpi36
>   pinctrl: nuvoton: npcm8xx: add pin 250 to DDR pins group
>   pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function
>   pinctrl: nuvoton: npcm8xx: remove unused lpcclk pin, group, function
>   pinctrl: nuvoton: npcm8xx: modify clkrun and serirq pin configuration
>   pinctrl: nuvoton: npcm8xx: modify pins flags

You also need to update
Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
for any changes that affect the device tree bindings (e.g.
adding/removing functions/groups).

Best Regards,
Jonas
Tomer Maimon July 16, 2024, 2:24 p.m. UTC | #2 
Hi Jonas,

Thanks for your comment, will be addressed in next version.

Thanks,

Tomer

On Sat, 13 Jul 2024 at 15:35, Jonas Gorski <jonas.gorski@gmail.com> wrote:
>
> Hi,
>
> On Fri, 12 Jul 2024 at 02:48, Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > This patch set addresses various pin configuration changes for the
> > Nuvoton NPCM8XX BMC SoC. The patches aim to enhance functionality,
> > remove unused pins, and improve overall pin management.
> >
> > Tomer Maimon (7):
> >   pinctrl: nuvoton: npcm8xx: clear polarity before set both edge
> >   pinctrl: nuvoton: npcm8xx: add gpi35 and gpi36
> >   pinctrl: nuvoton: npcm8xx: add pin 250 to DDR pins group
> >   pinctrl: nuvoton: npcm8xx: remove unused smb4den pin, group, function
> >   pinctrl: nuvoton: npcm8xx: remove unused lpcclk pin, group, function
> >   pinctrl: nuvoton: npcm8xx: modify clkrun and serirq pin configuration
> >   pinctrl: nuvoton: npcm8xx: modify pins flags
>
> You also need to update
> Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml
> for any changes that affect the device tree bindings (e.g.
> adding/removing functions/groups).
>
> Best Regards,
> Jonas