| Message ID | 20240715091707.83910-1-amusil@redhat.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [ovs-dev] tests: Do not use check in VXLAN mode disable test. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
Thanks. (Confirmed the other test case that covers tunnel exhaustion scenarios already uses `eval`.) Reviewed-By: Ihar Hrachyshka <ihar@redhat.com> On Mon, Jul 15, 2024 at 5:17 AM Ales Musil <amusil@redhat.com> wrote: > The test tries to setup 4097 LSs via single ovn-nbctl command, > this is fine however it might lead to "Unreasonably long Xms poll > interval" on slower systems thus failing the test. Remove the check > as the test still checks if all switches were created right under > so it should be completely fine and this should avoid faliures > on slower systems. > > Fixes: 7e99500e60bf ("northd: Add support for disabling vxlan mode.") > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > tests/ovn-northd.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at > index a389d1988..49a145e7d 100644 > --- a/tests/ovn-northd.at > +++ b/tests/ovn-northd.at > @@ -2887,7 +2887,7 @@ for i in {1..4097..1}; do > cmd="${cmd} -- ls-add lsw-${i}" > done > > -check $cmd > +eval $cmd > > check_row_count nb:Logical_Switch 4097 > wait_row_count sb:Datapath_Binding 4095 > -- > 2.45.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index a389d1988..49a145e7d 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -2887,7 +2887,7 @@ for i in {1..4097..1}; do cmd="${cmd} -- ls-add lsw-${i}" done -check $cmd +eval $cmd check_row_count nb:Logical_Switch 4097 wait_row_count sb:Datapath_Binding 4095
The test tries to setup 4097 LSs via single ovn-nbctl command, this is fine however it might lead to "Unreasonably long Xms poll interval" on slower systems thus failing the test. Remove the check as the test still checks if all switches were created right under so it should be completely fine and this should avoid faliures on slower systems. Fixes: 7e99500e60bf ("northd: Add support for disabling vxlan mode.") Signed-off-by: Ales Musil <amusil@redhat.com> --- tests/ovn-northd.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)