| Message ID | 20240213114933.2444440-2-buildroot@bubu1.eu |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/2] package/tio: install bash-completions | expand |
Hello Marcus, On Tue, 13 Feb 2024 12:49:32 +0100 Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote: > Remove the man subdir from inclusion in the main meson.build file. > > Reported upstream to get an option to disable this properly: > https://github.com/tio/tio/issues/222 > > Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> I did not apply this patch. Indeed, man pages are anyway removed at the end of the build, so we don't really care that much if they are installed. Of course, if there's a convenient option to disable installing manpages we can use it (and upstream has added one following your bug report, and therefore once we upgrade to a newer release that has this option, we can use it). But when we don't go through great lengths to disable manpages otherwise, *except* if building the manpages requires some additional tools that would bring in extra dependencies into the build. So I've marked your patch as Rejected. Feel free to use the new option to disable manpages at the next version bump of tio. Thanks! Thomas
diff --git a/package/tio/tio.mk b/package/tio/tio.mk index a7d3537850..66ce69db2f 100644 --- a/package/tio/tio.mk +++ b/package/tio/tio.mk @@ -16,4 +16,10 @@ else TIO_CONF_OPTS +=-Dbashcompletiondir=no endif +define TIO_DISABLE_BUILDING_MAN_PAGE + sed -i -e "/subdir('man')/d" $(@D)/meson.build +endef + +TIO_POST_PATCH_HOOKS += TIO_DISABLE_BUILDING_MAN_PAGE + $(eval $(meson-package))
Remove the man subdir from inclusion in the main meson.build file. Reported upstream to get an option to disable this properly: https://github.com/tio/tio/issues/222 Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu> --- package/tio/tio.mk | 6 ++++++ 1 file changed, 6 insertions(+)