mbox series

[0/2] pkg-cmake CMAKE_ASM_COMPILER override

Message ID 20240713054213.228070-1-heiko.thiery@gmail.com
Headers show
Series pkg-cmake CMAKE_ASM_COMPILER override | expand

Message

Heiko Thiery July 13, 2024, 5:42 a.m. UTC 
While I was adding a new host package (blake3) I got an error
with the selection of the ASM compiler. The error could be fixed
by using -DCMAKE_ASM_COMPILER="$(CMAKE_HOST_C_COMPILER). During
the review it was noticed that the value DCMAKE_ASM_COMPILER was
incorrectly set in the pkg-cmake infra. After this was fixed,
the workaround for this could be removed in the blake3 package.

This workaround is also present in the llvm package and now
can also be removed.

Heiko Thiery (2):
  package/pkg-cmake: remove override of CMAKE_ASM_COMPILER
  package/llvm-project/llvm: remove overriding the ASM compiler

 package/llvm-project/llvm/llvm.mk | 6 +++---
 package/pkg-cmake.mk              | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)

Comments

Arnout Vandecappelle July 13, 2024, 8:23 p.m. UTC | #1 
On 13/07/2024 07:42, Heiko Thiery wrote:
> While I was adding a new host package (blake3) I got an error
> with the selection of the ASM compiler. The error could be fixed
> by using -DCMAKE_ASM_COMPILER="$(CMAKE_HOST_C_COMPILER). During
> the review it was noticed that the value DCMAKE_ASM_COMPILER was
> incorrectly set in the pkg-cmake infra. After this was fixed,
> the workaround for this could be removed in the blake3 package.
> 
> This workaround is also present in the llvm package and now
> can also be removed.

  Applied both to master, thanks, after extending the commit message a little 
like you asked.

  Regards,
  Arnout

> 
> Heiko Thiery (2):
>    package/pkg-cmake: remove override of CMAKE_ASM_COMPILER
>    package/llvm-project/llvm: remove overriding the ASM compiler
> 
>   package/llvm-project/llvm/llvm.mk | 6 +++---
>   package/pkg-cmake.mk              | 1 -
>   2 files changed, 3 insertions(+), 4 deletions(-)
>