| Message ID | or7cdsjc7h.fsf@lxoliva.fsfla.org |
|---|---|
| State | New |
| Headers | show |
| Series | [libstdc++,testsuite] require dfprt on some tests | expand |
On Thu, 11 Jul 2024 at 14:22, Alexandre Oliva <oliva@adacore.com> wrote: > > > On a target that doesn't enable decimal float components in libgcc > (because the libc doens't define all required FE_* macros), but whose > compiler supports _Decimal* types, the effective target requirement > dfp passes, but several tests won't link because the runtime support > they depend on is missing. State their dfprt requirement. > > Regstrapped on x86_64-linux-gnu, also tested with gcc-13 targeting > aarch64. Ok to install? OK, thanks. > > > for libstdc++-v3/ChangeLog > > * testsuite/decimal/binary-arith.cc: Require dfprt. > * testsuite/decimal/comparison.cc: Likewise. > * testsuite/decimal/compound-assignment-memfunc.cc: Likewise. > * testsuite/decimal/make-decimal.cc: Likewise. > * testsuite/decimal/pr54036-1.cc: Likewise. > * testsuite/decimal/pr54036-2.cc: Likewise. > * testsuite/decimal/pr54036-3.cc: Likewise. > * testsuite/decimal/unary-arith.cc: Likewise. > --- > libstdc++-v3/testsuite/decimal/binary-arith.cc | 2 +- > libstdc++-v3/testsuite/decimal/comparison.cc | 2 +- > .../decimal/compound-assignment-memfunc.cc | 2 +- > .../testsuite/decimal/compound-assignment.cc | 2 +- > libstdc++-v3/testsuite/decimal/make-decimal.cc | 2 +- > libstdc++-v3/testsuite/decimal/pr54036-1.cc | 2 +- > libstdc++-v3/testsuite/decimal/pr54036-2.cc | 2 +- > libstdc++-v3/testsuite/decimal/pr54036-3.cc | 2 +- > libstdc++-v3/testsuite/decimal/unary-arith.cc | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libstdc++-v3/testsuite/decimal/binary-arith.cc b/libstdc++-v3/testsuite/decimal/binary-arith.cc > index c10a8b6466cb0..3eeed7ea97501 100644 > --- a/libstdc++-v3/testsuite/decimal/binary-arith.cc > +++ b/libstdc++-v3/testsuite/decimal/binary-arith.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > // ISO/IEC TR 24733 3.2.8 Binary arithmetic operators. > > diff --git a/libstdc++-v3/testsuite/decimal/comparison.cc b/libstdc++-v3/testsuite/decimal/comparison.cc > index cf34c8d74badc..424dd8bd26659 100644 > --- a/libstdc++-v3/testsuite/decimal/comparison.cc > +++ b/libstdc++-v3/testsuite/decimal/comparison.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > // ISO/IEC TR 24733 3.2.9 Comparison operators. > > diff --git a/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc b/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc > index 817d4bb10b1e9..d520af9a68d49 100644 > --- a/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc > +++ b/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > // ISO/IEC TR 24733 3.2.2.6 Compound assignment (decimal32). > // ISO/IEC TR 24733 3.2.3.6 Compound assignment (decimal64). > diff --git a/libstdc++-v3/testsuite/decimal/compound-assignment.cc b/libstdc++-v3/testsuite/decimal/compound-assignment.cc > index 2d3e325856988..5aa87e78a739a 100644 > --- a/libstdc++-v3/testsuite/decimal/compound-assignment.cc > +++ b/libstdc++-v3/testsuite/decimal/compound-assignment.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > // ISO/IEC TR 24733 3.2.2.6 Compound assignment (decimal32). > // ISO/IEC TR 24733 3.2.3.6 Compound assignment (decimal64). > diff --git a/libstdc++-v3/testsuite/decimal/make-decimal.cc b/libstdc++-v3/testsuite/decimal/make-decimal.cc > index aa75ac89d4792..560196cb305e1 100644 > --- a/libstdc++-v3/testsuite/decimal/make-decimal.cc > +++ b/libstdc++-v3/testsuite/decimal/make-decimal.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > // { dg-options "-Wno-pedantic" } > > // ISO/IEC TR 24733 3.2.5 Initialization from coefficient and exponent. > diff --git a/libstdc++-v3/testsuite/decimal/pr54036-1.cc b/libstdc++-v3/testsuite/decimal/pr54036-1.cc > index 508738701ca01..a07e4c351651c 100644 > --- a/libstdc++-v3/testsuite/decimal/pr54036-1.cc > +++ b/libstdc++-v3/testsuite/decimal/pr54036-1.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > #include <decimal/decimal> > #include <testsuite_hooks.h> > diff --git a/libstdc++-v3/testsuite/decimal/pr54036-2.cc b/libstdc++-v3/testsuite/decimal/pr54036-2.cc > index cb9e8c5932adb..e0a5797a25d49 100644 > --- a/libstdc++-v3/testsuite/decimal/pr54036-2.cc > +++ b/libstdc++-v3/testsuite/decimal/pr54036-2.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > #include <decimal/decimal> > #include <testsuite_hooks.h> > diff --git a/libstdc++-v3/testsuite/decimal/pr54036-3.cc b/libstdc++-v3/testsuite/decimal/pr54036-3.cc > index f27b48991c85e..75fcb2f27bed0 100644 > --- a/libstdc++-v3/testsuite/decimal/pr54036-3.cc > +++ b/libstdc++-v3/testsuite/decimal/pr54036-3.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > #include <decimal/decimal> > #include <testsuite_hooks.h> > diff --git a/libstdc++-v3/testsuite/decimal/unary-arith.cc b/libstdc++-v3/testsuite/decimal/unary-arith.cc > index b3352ac3656d4..5f75af1439b87 100644 > --- a/libstdc++-v3/testsuite/decimal/unary-arith.cc > +++ b/libstdc++-v3/testsuite/decimal/unary-arith.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // <http://www.gnu.org/licenses/>. > > -// { dg-require-effective-target dfp } > +// { dg-require-effective-target dfprt } > > // ISO/IEC TR 24733 3.2.7 Unary arithmetic operators. > > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive >
On Thu, 11 Jul 2024 at 15:28, Jonathan Wakely <jwakely@redhat.com> wrote: > > On Thu, 11 Jul 2024 at 14:22, Alexandre Oliva <oliva@adacore.com> wrote: > > > > > > On a target that doesn't enable decimal float components in libgcc > > (because the libc doens't define all required FE_* macros), but whose > > compiler supports _Decimal* types, the effective target requirement > > dfp passes, but several tests won't link because the runtime support > > they depend on is missing. State their dfprt requirement. > > > > Regstrapped on x86_64-linux-gnu, also tested with gcc-13 targeting > > aarch64. Ok to install? > > OK, thanks. btw, you touched it last, so now you own the decimal floating-point code ;-) > > > > > > > > for libstdc++-v3/ChangeLog > > > > * testsuite/decimal/binary-arith.cc: Require dfprt. > > * testsuite/decimal/comparison.cc: Likewise. > > * testsuite/decimal/compound-assignment-memfunc.cc: Likewise. > > * testsuite/decimal/make-decimal.cc: Likewise. > > * testsuite/decimal/pr54036-1.cc: Likewise. > > * testsuite/decimal/pr54036-2.cc: Likewise. > > * testsuite/decimal/pr54036-3.cc: Likewise. > > * testsuite/decimal/unary-arith.cc: Likewise. > > --- > > libstdc++-v3/testsuite/decimal/binary-arith.cc | 2 +- > > libstdc++-v3/testsuite/decimal/comparison.cc | 2 +- > > .../decimal/compound-assignment-memfunc.cc | 2 +- > > .../testsuite/decimal/compound-assignment.cc | 2 +- > > libstdc++-v3/testsuite/decimal/make-decimal.cc | 2 +- > > libstdc++-v3/testsuite/decimal/pr54036-1.cc | 2 +- > > libstdc++-v3/testsuite/decimal/pr54036-2.cc | 2 +- > > libstdc++-v3/testsuite/decimal/pr54036-3.cc | 2 +- > > libstdc++-v3/testsuite/decimal/unary-arith.cc | 2 +- > > 9 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/libstdc++-v3/testsuite/decimal/binary-arith.cc b/libstdc++-v3/testsuite/decimal/binary-arith.cc > > index c10a8b6466cb0..3eeed7ea97501 100644 > > --- a/libstdc++-v3/testsuite/decimal/binary-arith.cc > > +++ b/libstdc++-v3/testsuite/decimal/binary-arith.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > // ISO/IEC TR 24733 3.2.8 Binary arithmetic operators. > > > > diff --git a/libstdc++-v3/testsuite/decimal/comparison.cc b/libstdc++-v3/testsuite/decimal/comparison.cc > > index cf34c8d74badc..424dd8bd26659 100644 > > --- a/libstdc++-v3/testsuite/decimal/comparison.cc > > +++ b/libstdc++-v3/testsuite/decimal/comparison.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > // ISO/IEC TR 24733 3.2.9 Comparison operators. > > > > diff --git a/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc b/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc > > index 817d4bb10b1e9..d520af9a68d49 100644 > > --- a/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc > > +++ b/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > // ISO/IEC TR 24733 3.2.2.6 Compound assignment (decimal32). > > // ISO/IEC TR 24733 3.2.3.6 Compound assignment (decimal64). > > diff --git a/libstdc++-v3/testsuite/decimal/compound-assignment.cc b/libstdc++-v3/testsuite/decimal/compound-assignment.cc > > index 2d3e325856988..5aa87e78a739a 100644 > > --- a/libstdc++-v3/testsuite/decimal/compound-assignment.cc > > +++ b/libstdc++-v3/testsuite/decimal/compound-assignment.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > // ISO/IEC TR 24733 3.2.2.6 Compound assignment (decimal32). > > // ISO/IEC TR 24733 3.2.3.6 Compound assignment (decimal64). > > diff --git a/libstdc++-v3/testsuite/decimal/make-decimal.cc b/libstdc++-v3/testsuite/decimal/make-decimal.cc > > index aa75ac89d4792..560196cb305e1 100644 > > --- a/libstdc++-v3/testsuite/decimal/make-decimal.cc > > +++ b/libstdc++-v3/testsuite/decimal/make-decimal.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > // { dg-options "-Wno-pedantic" } > > > > // ISO/IEC TR 24733 3.2.5 Initialization from coefficient and exponent. > > diff --git a/libstdc++-v3/testsuite/decimal/pr54036-1.cc b/libstdc++-v3/testsuite/decimal/pr54036-1.cc > > index 508738701ca01..a07e4c351651c 100644 > > --- a/libstdc++-v3/testsuite/decimal/pr54036-1.cc > > +++ b/libstdc++-v3/testsuite/decimal/pr54036-1.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > #include <decimal/decimal> > > #include <testsuite_hooks.h> > > diff --git a/libstdc++-v3/testsuite/decimal/pr54036-2.cc b/libstdc++-v3/testsuite/decimal/pr54036-2.cc > > index cb9e8c5932adb..e0a5797a25d49 100644 > > --- a/libstdc++-v3/testsuite/decimal/pr54036-2.cc > > +++ b/libstdc++-v3/testsuite/decimal/pr54036-2.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > #include <decimal/decimal> > > #include <testsuite_hooks.h> > > diff --git a/libstdc++-v3/testsuite/decimal/pr54036-3.cc b/libstdc++-v3/testsuite/decimal/pr54036-3.cc > > index f27b48991c85e..75fcb2f27bed0 100644 > > --- a/libstdc++-v3/testsuite/decimal/pr54036-3.cc > > +++ b/libstdc++-v3/testsuite/decimal/pr54036-3.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > #include <decimal/decimal> > > #include <testsuite_hooks.h> > > diff --git a/libstdc++-v3/testsuite/decimal/unary-arith.cc b/libstdc++-v3/testsuite/decimal/unary-arith.cc > > index b3352ac3656d4..5f75af1439b87 100644 > > --- a/libstdc++-v3/testsuite/decimal/unary-arith.cc > > +++ b/libstdc++-v3/testsuite/decimal/unary-arith.cc > > @@ -15,7 +15,7 @@ > > // with this library; see the file COPYING3. If not see > > // <http://www.gnu.org/licenses/>. > > > > -// { dg-require-effective-target dfp } > > +// { dg-require-effective-target dfprt } > > > > // ISO/IEC TR 24733 3.2.7 Unary arithmetic operators. > > > > > > > > -- > > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > > Free Software Activist GNU Toolchain Engineer > > More tolerance and less prejudice are key for inclusion and diversity > > Excluding neuro-others for not behaving ""normal"" is *not* inclusive > >
On Jul 11, 2024, Jonathan Wakely <jwakely@redhat.com> wrote:
> btw, you touched it last, so now you own the decimal floating-point code ;-)
Heh. Yet another reason ["why software shouldn't have owners"]
(https://www.gnu.org/philosophy/why-free.en.html) :-)
On Jul 11, 2024, Jonathan Wakely <jwakely@redhat.com> wrote:
>> * testsuite/decimal/compound-assignment-memfunc.cc: Likewise.
The following file was missing from the ChangeLog. Added before pushing:
* testsuite/decimal/compound-assignment.cc: Likewise.
diff --git a/libstdc++-v3/testsuite/decimal/binary-arith.cc b/libstdc++-v3/testsuite/decimal/binary-arith.cc index c10a8b6466cb0..3eeed7ea97501 100644 --- a/libstdc++-v3/testsuite/decimal/binary-arith.cc +++ b/libstdc++-v3/testsuite/decimal/binary-arith.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } // ISO/IEC TR 24733 3.2.8 Binary arithmetic operators. diff --git a/libstdc++-v3/testsuite/decimal/comparison.cc b/libstdc++-v3/testsuite/decimal/comparison.cc index cf34c8d74badc..424dd8bd26659 100644 --- a/libstdc++-v3/testsuite/decimal/comparison.cc +++ b/libstdc++-v3/testsuite/decimal/comparison.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } // ISO/IEC TR 24733 3.2.9 Comparison operators. diff --git a/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc b/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc index 817d4bb10b1e9..d520af9a68d49 100644 --- a/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc +++ b/libstdc++-v3/testsuite/decimal/compound-assignment-memfunc.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } // ISO/IEC TR 24733 3.2.2.6 Compound assignment (decimal32). // ISO/IEC TR 24733 3.2.3.6 Compound assignment (decimal64). diff --git a/libstdc++-v3/testsuite/decimal/compound-assignment.cc b/libstdc++-v3/testsuite/decimal/compound-assignment.cc index 2d3e325856988..5aa87e78a739a 100644 --- a/libstdc++-v3/testsuite/decimal/compound-assignment.cc +++ b/libstdc++-v3/testsuite/decimal/compound-assignment.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } // ISO/IEC TR 24733 3.2.2.6 Compound assignment (decimal32). // ISO/IEC TR 24733 3.2.3.6 Compound assignment (decimal64). diff --git a/libstdc++-v3/testsuite/decimal/make-decimal.cc b/libstdc++-v3/testsuite/decimal/make-decimal.cc index aa75ac89d4792..560196cb305e1 100644 --- a/libstdc++-v3/testsuite/decimal/make-decimal.cc +++ b/libstdc++-v3/testsuite/decimal/make-decimal.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } // { dg-options "-Wno-pedantic" } // ISO/IEC TR 24733 3.2.5 Initialization from coefficient and exponent. diff --git a/libstdc++-v3/testsuite/decimal/pr54036-1.cc b/libstdc++-v3/testsuite/decimal/pr54036-1.cc index 508738701ca01..a07e4c351651c 100644 --- a/libstdc++-v3/testsuite/decimal/pr54036-1.cc +++ b/libstdc++-v3/testsuite/decimal/pr54036-1.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } #include <decimal/decimal> #include <testsuite_hooks.h> diff --git a/libstdc++-v3/testsuite/decimal/pr54036-2.cc b/libstdc++-v3/testsuite/decimal/pr54036-2.cc index cb9e8c5932adb..e0a5797a25d49 100644 --- a/libstdc++-v3/testsuite/decimal/pr54036-2.cc +++ b/libstdc++-v3/testsuite/decimal/pr54036-2.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } #include <decimal/decimal> #include <testsuite_hooks.h> diff --git a/libstdc++-v3/testsuite/decimal/pr54036-3.cc b/libstdc++-v3/testsuite/decimal/pr54036-3.cc index f27b48991c85e..75fcb2f27bed0 100644 --- a/libstdc++-v3/testsuite/decimal/pr54036-3.cc +++ b/libstdc++-v3/testsuite/decimal/pr54036-3.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } #include <decimal/decimal> #include <testsuite_hooks.h> diff --git a/libstdc++-v3/testsuite/decimal/unary-arith.cc b/libstdc++-v3/testsuite/decimal/unary-arith.cc index b3352ac3656d4..5f75af1439b87 100644 --- a/libstdc++-v3/testsuite/decimal/unary-arith.cc +++ b/libstdc++-v3/testsuite/decimal/unary-arith.cc @@ -15,7 +15,7 @@ // with this library; see the file COPYING3. If not see // <http://www.gnu.org/licenses/>. -// { dg-require-effective-target dfp } +// { dg-require-effective-target dfprt } // ISO/IEC TR 24733 3.2.7 Unary arithmetic operators.