| Message ID | 88769e54-d3b9-0357-ac81-94f8f72bd0ae@e124511.cambridge.arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | aarch64: Extend aarch64_feature_flags to 128 bits | expand |
> On 11 Jul 2024, at 14:12, Andrew Carlotti <andrew.carlotti@arm.com> wrote: > > External email: Use caution opening links or attachments > > > The name would become misleading in a later commit anyway, and I think > this is marginally more readable. > > gcc/ChangeLog: > > * config/aarch64/aarch64.cc > (aarch64_override_options): Remove temporary variable. > Ok. Thanks, Kyrill > > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc > index 2a67383bf9d21631664aba82e753120a0173efcf..67c97569b7d4b5502e8dfc111eced65d2aee5cb2 100644 > --- a/gcc/config/aarch64/aarch64.cc > +++ b/gcc/config/aarch64/aarch64.cc > @@ -18856,7 +18856,6 @@ aarch64_override_options (void) > SUBTARGET_OVERRIDE_OPTIONS; > #endif > > - auto isa_mode = AARCH64_FL_DEFAULT_ISA_MODE; > if (cpu && arch) > { > /* If both -mcpu and -march are specified, warn if they are not > @@ -18879,25 +18878,25 @@ aarch64_override_options (void) > } > > selected_arch = arch->arch; > - aarch64_set_asm_isa_flags (arch_isa | isa_mode); > + aarch64_set_asm_isa_flags (arch_isa | AARCH64_FL_DEFAULT_ISA_MODE); > } > else if (cpu) > { > selected_arch = cpu->arch; > - aarch64_set_asm_isa_flags (cpu_isa | isa_mode); > + aarch64_set_asm_isa_flags (cpu_isa | AARCH64_FL_DEFAULT_ISA_MODE); > } > else if (arch) > { > cpu = &all_cores[arch->ident]; > selected_arch = arch->arch; > - aarch64_set_asm_isa_flags (arch_isa | isa_mode); > + aarch64_set_asm_isa_flags (arch_isa | AARCH64_FL_DEFAULT_ISA_MODE); > } > else > { > /* No -mcpu or -march specified, so use the default CPU. */ > cpu = &all_cores[TARGET_CPU_DEFAULT]; > selected_arch = cpu->arch; > - aarch64_set_asm_isa_flags (cpu->flags | isa_mode); > + aarch64_set_asm_isa_flags (cpu->flags | AARCH64_FL_DEFAULT_ISA_MODE); > } > > selected_tune = tune ? tune->ident : cpu->ident;
diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index 2a67383bf9d21631664aba82e753120a0173efcf..67c97569b7d4b5502e8dfc111eced65d2aee5cb2 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -18856,7 +18856,6 @@ aarch64_override_options (void) SUBTARGET_OVERRIDE_OPTIONS; #endif - auto isa_mode = AARCH64_FL_DEFAULT_ISA_MODE; if (cpu && arch) { /* If both -mcpu and -march are specified, warn if they are not @@ -18879,25 +18878,25 @@ aarch64_override_options (void) } selected_arch = arch->arch; - aarch64_set_asm_isa_flags (arch_isa | isa_mode); + aarch64_set_asm_isa_flags (arch_isa | AARCH64_FL_DEFAULT_ISA_MODE); } else if (cpu) { selected_arch = cpu->arch; - aarch64_set_asm_isa_flags (cpu_isa | isa_mode); + aarch64_set_asm_isa_flags (cpu_isa | AARCH64_FL_DEFAULT_ISA_MODE); } else if (arch) { cpu = &all_cores[arch->ident]; selected_arch = arch->arch; - aarch64_set_asm_isa_flags (arch_isa | isa_mode); + aarch64_set_asm_isa_flags (arch_isa | AARCH64_FL_DEFAULT_ISA_MODE); } else { /* No -mcpu or -march specified, so use the default CPU. */ cpu = &all_cores[TARGET_CPU_DEFAULT]; selected_arch = cpu->arch; - aarch64_set_asm_isa_flags (cpu->flags | isa_mode); + aarch64_set_asm_isa_flags (cpu->flags | AARCH64_FL_DEFAULT_ISA_MODE); } selected_tune = tune ? tune->ident : cpu->ident;