diff mbox series

[v2,01/11] aarch64: Remove unused global aarch64_tune_flags

Message ID 9aefffcf-c12f-760a-3d1f-bdcdae5c20f3@e124511.cambridge.arm.com
State New
Headers show
Series aarch64: Extend aarch64_feature_flags to 128 bits | expand

Commit Message

Andrew Carlotti July 11, 2024, 12:11 p.m. UTC
gcc/ChangeLog:

	* config/aarch64/aarch64.cc
	(aarch64_tune_flags): Remove unused global variable.
	(aarch64_override_options_internal): Remove dead assignment.

Comments

Kyrylo Tkachov July 11, 2024, 3:32 p.m. UTC | #1
Hi Andrew,

> On 11 Jul 2024, at 14:11, Andrew Carlotti <andrew.carlotti@arm.com> wrote:
> 
> External email: Use caution opening links or attachments
> 
> 
> gcc/ChangeLog:
> 
>        * config/aarch64/aarch64.cc
>        (aarch64_tune_flags): Remove unused global variable.
>        (aarch64_override_options_internal): Remove dead assignment.
> 
> 

Ok. I’d consider it obvious even.
Thanks,
Kyrill

> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> index 7f0cc47d0f071de9297068baa85c6d5fc4d7fa5b..2a67383bf9d21631664aba82e753120a0173efcf 100644
> --- a/gcc/config/aarch64/aarch64.cc
> +++ b/gcc/config/aarch64/aarch64.cc
> @@ -349,9 +349,6 @@ static bool aarch64_print_address_internal (FILE*, machine_mode, rtx,
> /* The processor for which instructions should be scheduled.  */
> enum aarch64_processor aarch64_tune = cortexa53;
> 
> -/* Mask to specify which instruction scheduling options should be used.  */
> -uint64_t aarch64_tune_flags = 0;
> -
> /* Global flag for PC relative loads.  */
> bool aarch64_pcrelative_literal_loads;
> 
> @@ -18273,7 +18270,6 @@ void
> aarch64_override_options_internal (struct gcc_options *opts)
> {
>   const struct processor *tune = aarch64_get_tune_cpu (opts->x_selected_tune);
> -  aarch64_tune_flags = tune->flags;
>   aarch64_tune = tune->sched_core;
>   /* Make a copy of the tuning parameters attached to the core, which
>      we may later overwrite.  */
diff mbox series

Patch

diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
index 7f0cc47d0f071de9297068baa85c6d5fc4d7fa5b..2a67383bf9d21631664aba82e753120a0173efcf 100644
--- a/gcc/config/aarch64/aarch64.cc
+++ b/gcc/config/aarch64/aarch64.cc
@@ -349,9 +349,6 @@  static bool aarch64_print_address_internal (FILE*, machine_mode, rtx,
 /* The processor for which instructions should be scheduled.  */
 enum aarch64_processor aarch64_tune = cortexa53;
 
-/* Mask to specify which instruction scheduling options should be used.  */
-uint64_t aarch64_tune_flags = 0;
-
 /* Global flag for PC relative loads.  */
 bool aarch64_pcrelative_literal_loads;
 
@@ -18273,7 +18270,6 @@  void
 aarch64_override_options_internal (struct gcc_options *opts)
 {
   const struct processor *tune = aarch64_get_tune_cpu (opts->x_selected_tune);
-  aarch64_tune_flags = tune->flags;
   aarch64_tune = tune->sched_core;
   /* Make a copy of the tuning parameters attached to the core, which
      we may later overwrite.  */