| Message ID | 20240709202438.27298-1-heiko.thiery@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/libssh: select BR2_PACKAGE_LIBOPENSSL_ENGINES | expand |
On Tue, 9 Jul 2024 22:24:39 +0200 Heiko Thiery <heiko.thiery@gmail.com> wrote: > This fixes link time errors, undefined references to various ENGINE_* > functions in case libopenssl backend is used. > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> Is this fixing http://autobuild.buildroot.net/results/5bb/5bb845be7f861dc3540a8dc618ccd1a0a759f2d5/build-end.log and similar build issues ? Thanks! Thomas
Hi, Am Mi., 10. Juli 2024 um 16:51 Uhr schrieb Thomas Petazzoni <thomas.petazzoni@bootlin.com>: > > On Tue, 9 Jul 2024 22:24:39 +0200 > Heiko Thiery <heiko.thiery@gmail.com> wrote: > > > This fixes link time errors, undefined references to various ENGINE_* > > functions in case libopenssl backend is used. > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > Is this > fixing http://autobuild.buildroot.net/results/5bb/5bb845be7f861dc3540a8dc618ccd1a0a759f2d5/build-end.log > and similar build issues ? Yes this looks like the issue I had.
On Tue, 9 Jul 2024 22:24:39 +0200 Heiko Thiery <heiko.thiery@gmail.com> wrote: > This fixes link time errors, undefined references to various ENGINE_* > functions in case libopenssl backend is used. > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > package/libssh/Config.in | 1 + > 1 file changed, 1 insertion(+) Applied to master, after adding a reference to the autobuilder build failure. Thanks! Thomas
On Wed, 2024-07-10 at 16:51 +0200, Thomas Petazzoni via buildroot wrote: > On Tue, 9 Jul 2024 22:24:39 +0200 > Heiko Thiery <heiko.thiery@gmail.com> wrote: > > This fixes link time errors, undefined references to various > > ENGINE_* functions in case libopenssl backend is used. > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > Is this fixing > http://autobuild.buildroot.net/results/5bb/5bb845be7f861dc3540a8dc618ccd1a0a759f2d5/build-end.log > and similar build issues ? > Indeed it is. Same issue also on 2024.02.x (ping Peter) It seems to have accidentally worked after the upgrade from OpenSSL 1.x to 3.x, but broke either in 8fed480 or 1899589 (also on 2024.02.x) Tested-by: Joachim Wiberg <troglobit@gmail.com>
Hi, just a friendly reminder. Maybe my initial reply got lost in all the noise and summer vacation. On 2024-07-10 at 23:13 +0200, Thomas Petazzoni wrote: > Heiko Thiery <heiko.thiery@gmail.com> wrote: > > This fixes link time errors, undefined references to various > > ENGINE_* functions in case libopenssl backend is used. > Applied to master, after adding a reference to the autobuilder build > failure. Thanks! We have the same issue also on 2024.02.x, as of 2024.02.4 builds with libssh break unless you update your defconfig. So it would be great if 62103be918e7a155749b1b3b680a9e4ecba6af87 could be cherry picked for the next LTS patch release. Best regards /Joachim
Hi Joachim, On Tue, Jul 16 2024, Joachim Wiberg wrote: > On 2024-07-10 at 23:13 +0200, Thomas Petazzoni wrote: >> Heiko Thiery <heiko.thiery@gmail.com> wrote: >> > This fixes link time errors, undefined references to various >> > ENGINE_* functions in case libopenssl backend is used. >> Applied to master, after adding a reference to the autobuilder build >> failure. Thanks! > > We have the same issue also on 2024.02.x, as of 2024.02.4 builds with > libssh break unless you update your defconfig. So it would be great if > 62103be918e7a155749b1b3b680a9e4ecba6af87 could be cherry picked for the > next LTS patch release. Commit fed58dac5dea (Revert "package/libopenssl: no-engine") should have fixed that in 2024.02.4. Are you sure libssh build is still broken? baruch
Hi Baruch, On Tue, 2024-07-16 at 12:21 +0300, Baruch Siach wrote: > Hi Joachim, > > On Tue, Jul 16 2024, Joachim Wiberg wrote: > > On 2024-07-10 at 23:13 +0200, Thomas Petazzoni wrote: > > > Applied to master, after adding a reference to the autobuilder > > > build failure. Thanks! > > We have the same issue also on 2024.02.x, as of 2024.02.4 builds > > with libssh break unless you update your defconfig. > Commit fed58dac5dea (Revert "package/libopenssl: no-engine") should > have fixed that in 2024.02.4. Are you sure libssh build is still > broken? Just retested, and you are 100% correct, the libssh build on 2024.02.x is *not broken*. So sorry having wasted everyone's time! All the best /Joachim
diff --git a/package/libssh/Config.in b/package/libssh/Config.in index 1f271a692e..eaec754414 100644 --- a/package/libssh/Config.in +++ b/package/libssh/Config.in @@ -36,6 +36,7 @@ config BR2_PACKAGE_LIBSSH_LIBGCRYPT config BR2_PACKAGE_LIBSSH_OPENSSL bool "openssl" depends on BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_LIBOPENSSL_ENGINES endchoice
This fixes link time errors, undefined references to various ENGINE_* functions in case libopenssl backend is used. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- package/libssh/Config.in | 1 + 1 file changed, 1 insertion(+)