| Message ID | 20240707082848.5424-4-wsa+renesas@sang-engineering.com |
|---|---|
| State | Accepted |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | i2c: rcar: avoid spurious irqs | expand |
> A newline was missing and closing braces of functions do not need a > semicolon. Can there be a need to offer such changes by separate update steps? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n81 … > +++ b/drivers/i2c/busses/i2c-rcar.c > @@ -192,7 +192,7 @@ static int rcar_i2c_get_scl(struct i2c_adapter *adap) > > return !!(rcar_i2c_read(priv, ICMCR) & FSCL); > > -}; > +} … How do you think about to omit any blank lines at such source code places? Regards, Markus
On Sun, Jul 07, 2024 at 12:34:36PM +0200, Markus Elfring wrote: > > A newline was missing and closing braces of functions do not need a > > semicolon. > > Can there be a need to offer such changes by separate update steps? That would be too fine grained in my book. > > return !!(rcar_i2c_read(priv, ICMCR) & FSCL); > > > > -}; > > +} > … > > How do you think about to omit any blank lines at such source code places? Oh yes, that newline should go as well. Thanks!
> > > -}; > > > +} > > … > > > > How do you think about to omit any blank lines at such source code places? > > Oh yes, that newline should go as well. Thanks! Andi, is it okay if I only resend this patch?
Hi Wolfram, On Mon, Jul 08, 2024 at 11:50:59AM GMT, Wolfram Sang wrote: > > > > > -}; > > > > +} > > > … > > > > > > How do you think about to omit any blank lines at such source code places? > > > > Oh yes, that newline should go as well. Thanks! > > Andi, is it okay if I only resend this patch? That's OK... if you want I can remove those blank lines before applying them, it's just two cases in your patch. Andi
> That's OK... if you want I can remove those blank lines before > applying them, it's just two cases in your patch. Then, please do that. Thanks!
Hi Wolfram, > > That's OK... if you want I can remove those blank lines before > > applying them, it's just two cases in your patch. > > Then, please do that. Thanks! done! Applied 2 and 3 to i2c/i2c-host. Thanks, Andi
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index d7688d702b65..29c7fafeb8a9 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -192,7 +192,7 @@ static int rcar_i2c_get_scl(struct i2c_adapter *adap) return !!(rcar_i2c_read(priv, ICMCR) & FSCL); -}; +} static void rcar_i2c_set_scl(struct i2c_adapter *adap, int val) { @@ -204,7 +204,7 @@ static void rcar_i2c_set_scl(struct i2c_adapter *adap, int val) priv->recovery_icmcr &= ~FSCL; rcar_i2c_write(priv, ICMCR, priv->recovery_icmcr); -}; +} static void rcar_i2c_set_sda(struct i2c_adapter *adap, int val) { @@ -216,7 +216,7 @@ static void rcar_i2c_set_sda(struct i2c_adapter *adap, int val) priv->recovery_icmcr &= ~FSDA; rcar_i2c_write(priv, ICMCR, priv->recovery_icmcr); -}; +} static int rcar_i2c_get_bus_free(struct i2c_adapter *adap) { @@ -224,7 +224,7 @@ static int rcar_i2c_get_bus_free(struct i2c_adapter *adap) return !(rcar_i2c_read(priv, ICMCR) & FSDA); -}; +} static struct i2c_bus_recovery_info rcar_i2c_bri = { .get_scl = rcar_i2c_get_scl, @@ -233,6 +233,7 @@ static struct i2c_bus_recovery_info rcar_i2c_bri = { .get_bus_free = rcar_i2c_get_bus_free, .recover_bus = i2c_generic_scl_recovery, }; + static void rcar_i2c_init(struct rcar_i2c_priv *priv) { /* reset master mode */
A newline was missing and closing braces of functions do not need a semicolon. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Should go to for-next. Changes since v1: * new patch drivers/i2c/busses/i2c-rcar.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)