diff mbox series

[libgpiod,v2] README: list the development packages required to build the library

Message ID 20240705073314.5728-1-brgl@bgdev.pl
State New
Headers show
Series [libgpiod,v2] README: list the development packages required to build the library | expand

Commit Message

Bartosz Golaszewski July 5, 2024, 7:33 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The error messages emitted by configure when either libtool, pkg-config
or autoconf-archive packages are missing on the host are not very clear
and seem to cause confusion among users building the project from
sources. List the required packages in the README.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Changes since v1:
- reword the part about missing libraries

 README | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Kent Gibson July 6, 2024, 2:34 a.m. UTC | #1
On Fri, Jul 05, 2024 at 09:33:14AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The error messages emitted by configure when either libtool, pkg-config
> or autoconf-archive packages are missing on the host are not very clear
> and seem to cause confusion among users building the project from
> sources. List the required packages in the README.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Changes since v1:
> - reword the part about missing libraries
>
>  README | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/README b/README
> index a6f24d1..a01cfc5 100644
> --- a/README
> +++ b/README
> @@ -34,6 +34,11 @@ BUILDING
>  This is a pretty standard autotools project. The core C library does not have
>  any external dependencies other than the standard C library with GNU extensions.
>
> +The build system requires autotools, autoconf-archive, libtool and pkg-config
> +to be installed on the host system for the basic build. Development files for
> +additional libraries may be required depending on selected options. The
> +configure script will report any missing additional required dependencies.
> +
>  The command-line tools optionally depend on libedit for the interactive feature.
>
>  To build the project (including command-line utilities) run:
> --
> 2.43.0
>

Reviewed-by: Kent Gibson <warthog618@gmail.com>
Bartosz Golaszewski July 8, 2024, 8:27 a.m. UTC | #2
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Fri, 05 Jul 2024 09:33:14 +0200, Bartosz Golaszewski wrote:
> The error messages emitted by configure when either libtool, pkg-config
> or autoconf-archive packages are missing on the host are not very clear
> and seem to cause confusion among users building the project from
> sources. List the required packages in the README.
> 
> 

Applied, thanks!

[1/1] README: list the development packages required to build the library
      commit: 099697530033ceec583b67abfda1df152430fae3

Best regards,
diff mbox series

Patch

diff --git a/README b/README
index a6f24d1..a01cfc5 100644
--- a/README
+++ b/README
@@ -34,6 +34,11 @@  BUILDING
 This is a pretty standard autotools project. The core C library does not have
 any external dependencies other than the standard C library with GNU extensions.
 
+The build system requires autotools, autoconf-archive, libtool and pkg-config
+to be installed on the host system for the basic build. Development files for
+additional libraries may be required depending on selected options. The
+configure script will report any missing additional required dependencies.
+
 The command-line tools optionally depend on libedit for the interactive feature.
 
 To build the project (including command-line utilities) run: