Message ID | 20240617-ep93xx-v10-0-662e640ed811@maquefel.me |
---|---|
Headers | show |
Series | ep93xx device tree conversion | expand |
On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay <devnull+nikita.shubin.maquefel.me@kernel.org> wrote: > > The goal is to recieve ACKs for all patches in series to merge it via Arnd branch. 'receive' > Unfortunately, CLK subsystem suddenly went silent on clk portion of series V2 reroll, > tried to ping them for about a month but no luck. > > Link: https://lore.kernel.org/r/20240408-ep93xx-clk-v2-1-adcd68c13753@maquefel.me > > Some changes since last version (v9) - see "Changes in v10", mostly > cosmetic. ... > Patches should be formated with '--histogram' 'formatted' ... > Changes in v10: > > Reordered SoB tags to make sure they appear before Rb and Acked tags. This is not required. The importance is only the order of SoBs themselves. If they are interleaved with other tags, it's fine. ... Hopefully to see this series being eventually applied soon. Arnd? (Do we have all necessary subsystem maintainers' tags, btw?)
On Mon, 17 Jun 2024 12:36:34 +0300 Nikita Shubin via B4 Relay wrote:
> The goal is to recieve ACKs for all patches in series to merge it via Arnd branch.
Why? The usual process is for every subsystem to accept the relevant
patches, and then they converge during the merge window.
Hello Andy! On Mon, 2024-06-17 at 12:58 +0200, Andy Shevchenko wrote: > On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay > <devnull+nikita.shubin.maquefel.me@kernel.org> wrote: > > > > The goal is to recieve ACKs for all patches in series to merge it > > via Arnd branch. > > 'receive' > > > Unfortunately, CLK subsystem suddenly went silent on clk portion of > > series V2 reroll, > > tried to ping them for about a month but no luck. > > > > Link: > > https://lore.kernel.org/r/20240408-ep93xx-clk-v2-1-adcd68c13753@maquefel.me > > > > Some changes since last version (v9) - see "Changes in v10", mostly > > cosmetic. > > ... > > > Patches should be formated with '--histogram' > > 'formatted' > > ... > > > Changes in v10: > > > > Reordered SoB tags to make sure they appear before Rb and Acked > > tags. > > This is not required. The importance is only the order of SoBs > themselves. If they are interleaved with other tags, it's fine. Ah - ok. Just saw someone was complaining about b4 reordering them. > > ... > > > Hopefully to see this series being eventually applied soon. > Arnd? (Do we have all necessary subsystem maintainers' tags, btw?) > > As i see from my perspective only three left: Clk subsystem: - clk: ep93xx: add DT support for Cirrus EP93xx DMA subsystem (but the only request from Vinod, as far as i remember, was fixing commits titles): - dmaengine: cirrus: Convert to DT for Cirrus EP93xx - dmaengine: cirrus: remove platform code Beside that tags missing on platform code removal (which can be Acked by Arnd himself i believe) and dtsi/dts files (same ?).
On Tue, 2024-06-18 at 07:33 -0700, Jakub Kicinski wrote: > On Mon, 17 Jun 2024 12:36:34 +0300 Nikita Shubin via B4 Relay wrote: > > The goal is to recieve ACKs for all patches in series to merge it > > via Arnd branch. > > Why? The usual process is for every subsystem to accept the relevant > patches, and then they converge during the merge window. It was decided from the very beginning of these series, mostly because it's a full conversion of platform code to DT and it seemed not convenient to maintain compatibility with both platform and DT. Generally i think it's too late to ask such a question, when just a few patches left.
On Tue, 18 Jun 2024 19:33:49 +0300 Nikita Shubin wrote: > On Tue, 2024-06-18 at 07:33 -0700, Jakub Kicinski wrote: > > On Mon, 17 Jun 2024 12:36:34 +0300 Nikita Shubin via B4 Relay wrote: > > > The goal is to recieve ACKs for all patches in series to merge it > > > via Arnd branch. > > > > Why? The usual process is for every subsystem to accept the relevant > > patches, and then they converge during the merge window. > > It was decided from the very beginning of these series, mostly because > it's a full conversion of platform code to DT and it seemed not > convenient to maintain compatibility with both platform and DT. > > Generally i think it's too late to ask such a question, when just a few > patches left. Put the relevant information in the cover letter. Justification why you can't follow normal merging rules is very relevant.
On Tue, 2024-06-18 at 19:20 +0300, Nikita Shubin wrote: > Hello Andy! > On Mon, 2024-06-17 at 12:58 +0200, Andy Shevchenko wrote: > > On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay > > <devnull+nikita.shubin.maquefel.me@kernel.org> wrote: > > > > > > The goal is to recieve ACKs for all patches in series to merge it > > > via Arnd branch. > > > > 'receive' > > > > > Unfortunately, CLK subsystem suddenly went silent on clk portion > > > of > > > series V2 reroll, > > > tried to ping them for about a month but no luck. > > > > > > Link: > > > https://lore.kernel.org/r/20240408-ep93xx-clk-v2-1-adcd68c13753@maquefel.me > > > > > > Some changes since last version (v9) - see "Changes in v10", > > > mostly > > > cosmetic. > > > > ... > > > > > Patches should be formated with '--histogram' > > > > 'formatted' > > > > ... > > > > > Changes in v10: > > > > > > Reordered SoB tags to make sure they appear before Rb and Acked > > > tags. > > > > This is not required. The importance is only the order of SoBs > > themselves. If they are interleaved with other tags, it's fine. > > Ah - ok. Just saw someone was complaining about b4 reordering them. > > > > > ... > > > > > > Hopefully to see this series being eventually applied soon. > > Arnd? (Do we have all necessary subsystem maintainers' tags, btw?) > > > > > > As i see from my perspective only three left: > > Clk subsystem: > > - clk: ep93xx: add DT support for Cirrus EP93xx > > DMA subsystem (but the only request from Vinod, as far as i remember, > was fixing commits titles): > > - dmaengine: cirrus: Convert to DT for Cirrus EP93xx > - dmaengine: cirrus: remove platform code > > Beside that tags missing on platform code removal (which can be Acked > by Arnd himself i believe) and dtsi/dts files (same ?). Vinod acked the above two patches: https://lore.kernel.org/all/ZnkIp8bOcZK3yVKP@matsya/ https://lore.kernel.org/all/ZnkImp8BtTdxl7O3@matsya/ so only: - clk: ep93xx: add DT support for Cirrus EP93xx https://lore.kernel.org/all/20240617-ep93xx-v10-3-662e640ed811@maquefel.me/ left. Hope Stephen will find some time for this one.
Hello, On Thu, Jun 27, 2024 at 11:29:44AM +0300, Nikita Shubin wrote: > On Tue, 2024-06-18 at 19:20 +0300, Nikita Shubin wrote: > > Hello Andy! > > On Mon, 2024-06-17 at 12:58 +0200, Andy Shevchenko wrote: > > > On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay > > > <devnull+nikita.shubin.maquefel.me@kernel.org> wrote: > > > > > > > > The goal is to recieve ACKs for all patches in series to merge it > > > > via Arnd branch. > > > > > > 'receive' > > > > > > > Unfortunately, CLK subsystem suddenly went silent on clk portion > > > > of > > > > series V2 reroll, > > > > tried to ping them for about a month but no luck. > > > > > > > > Link: > > > > https://lore.kernel.org/r/20240408-ep93xx-clk-v2-1-adcd68c13753@maquefel.me > > > > > > > > Some changes since last version (v9) - see "Changes in v10", > > > > mostly > > > > cosmetic. > > > > > > ... > > > > > > > Patches should be formated with '--histogram' > > > > > > 'formatted' > > > > > > ... > > > > > > > Changes in v10: > > > > > > > > Reordered SoB tags to make sure they appear before Rb and Acked > > > > tags. > > > > > > This is not required. The importance is only the order of SoBs > > > themselves. If they are interleaved with other tags, it's fine. > > > > Ah - ok. Just saw someone was complaining about b4 reordering them. > > > > > > > > ... > > > > > > > > > Hopefully to see this series being eventually applied soon. > > > Arnd? (Do we have all necessary subsystem maintainers' tags, btw?) > > > > > > > > > > As i see from my perspective only three left: > > > > Clk subsystem: > > > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > DMA subsystem (but the only request from Vinod, as far as i remember, > > was fixing commits titles): > > > > - dmaengine: cirrus: Convert to DT for Cirrus EP93xx > > - dmaengine: cirrus: remove platform code > > > > Beside that tags missing on platform code removal (which can be Acked > > by Arnd himself i believe) and dtsi/dts files (same ?). > > Vinod acked the above two patches: > > https://lore.kernel.org/all/ZnkIp8bOcZK3yVKP@matsya/ > https://lore.kernel.org/all/ZnkImp8BtTdxl7O3@matsya/ > > so only: > > - clk: ep93xx: add DT support for Cirrus EP93xx > > https://lore.kernel.org/all/20240617-ep93xx-v10-3-662e640ed811@maquefel.me/ > > left. > > Hope Stephen will find some time for this one. As we're approaching the merge window and this is still unclear, I applied the pwm bits (i.e. patches 12, 13). If I understand correctly, patch 33 isn't suitable for application yet as it has a dependency on pinctrl changes in that series. (side note: Your patches are signed, but that doesn't bring any benefit if the receivers don't have your key. I didn't find it neither on keys.openpgp.org nor in the kernel pgp key collection.) Best regards Uwe
Arnd, Are we continuing this patch series ? You are silent since last version submit, which makes me a bit worried. If you suddenly changed your mind please let us know, cause anyway we have no possibility to merge these series without you. On Fri, 2024-07-05 at 11:21 +0200, Uwe Kleine-König wrote: > Hello, > > On Thu, Jun 27, 2024 at 11:29:44AM +0300, Nikita Shubin wrote: > > On Tue, 2024-06-18 at 19:20 +0300, Nikita Shubin wrote: > > > Hello Andy! > > > On Mon, 2024-06-17 at 12:58 +0200, Andy Shevchenko wrote: > > > > On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay > > > > <devnull+nikita.shubin.maquefel.me@kernel.org> wrote: > > > > > > > > > > The goal is to recieve ACKs for all patches in series to > > > > > merge it > > > > > via Arnd branch. > > > > > > > > 'receive' > > > > > > > > > Unfortunately, CLK subsystem suddenly went silent on clk > > > > > portion > > > > > of > > > > > series V2 reroll, > > > > > tried to ping them for about a month but no luck. > > > > > > > > > > Link: > > > > > https://lore.kernel.org/r/20240408-ep93xx-clk-v2-1-adcd68c13753@maquefel.me > > > > > > > > > > Some changes since last version (v9) - see "Changes in v10", > > > > > mostly > > > > > cosmetic. > > > > > > > > ... > > > > > > > > > Patches should be formated with '--histogram' > > > > > > > > 'formatted' > > > > > > > > ... > > > > > > > > > Changes in v10: > > > > > > > > > > Reordered SoB tags to make sure they appear before Rb and > > > > > Acked > > > > > tags. > > > > > > > > This is not required. The importance is only the order of SoBs > > > > themselves. If they are interleaved with other tags, it's fine. > > > > > > Ah - ok. Just saw someone was complaining about b4 reordering > > > them. > > > > > > > > > > > ... > > > > > > > > > > > > Hopefully to see this series being eventually applied soon. > > > > Arnd? (Do we have all necessary subsystem maintainers' tags, > > > > btw?) > > > > > > > > > > > > > > As i see from my perspective only three left: > > > > > > Clk subsystem: > > > > > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > > > DMA subsystem (but the only request from Vinod, as far as i > > > remember, > > > was fixing commits titles): > > > > > > - dmaengine: cirrus: Convert to DT for Cirrus EP93xx > > > - dmaengine: cirrus: remove platform code > > > > > > Beside that tags missing on platform code removal (which can be > > > Acked > > > by Arnd himself i believe) and dtsi/dts files (same ?). > > > > Vinod acked the above two patches: > > > > https://lore.kernel.org/all/ZnkIp8bOcZK3yVKP@matsya/ > > https://lore.kernel.org/all/ZnkImp8BtTdxl7O3@matsya/ > > > > so only: > > > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > https://lore.kernel.org/all/20240617-ep93xx-v10-3-662e640ed811@maquefel.me/ > > > > left. > > > > Hope Stephen will find some time for this one. > > As we're approaching the merge window and this is still unclear, I > applied the pwm bits (i.e. patches 12, 13). If I understand > correctly, > patch 33 isn't suitable for application yet as it has a dependency on > pinctrl changes in that series. > > (side note: Your patches are signed, but that doesn't bring any > benefit > if the receivers don't have your key. I didn't find it neither on > keys.openpgp.org nor in the kernel pgp key collection.) > > Best regards > Uwe
On Fri, Jul 5, 2024 at 3:21 AM Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote: > > Hello, > > On Thu, Jun 27, 2024 at 11:29:44AM +0300, Nikita Shubin wrote: > > On Tue, 2024-06-18 at 19:20 +0300, Nikita Shubin wrote: > > > Hello Andy! > > > On Mon, 2024-06-17 at 12:58 +0200, Andy Shevchenko wrote: > > > > On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay > > > > <devnull+nikita.shubin.maquefel.me@kernel.org> wrote: > > > > > > > > > > The goal is to recieve ACKs for all patches in series to merge it > > > > > via Arnd branch. > > > > > > > > 'receive' > > > > > > > > > Unfortunately, CLK subsystem suddenly went silent on clk portion > > > > > of > > > > > series V2 reroll, > > > > > tried to ping them for about a month but no luck. > > > > > > > > > > Link: > > > > > https://lore.kernel.org/r/20240408-ep93xx-clk-v2-1-adcd68c13753@maquefel.me > > > > > > > > > > Some changes since last version (v9) - see "Changes in v10", > > > > > mostly > > > > > cosmetic. > > > > > > > > ... > > > > > > > > > Patches should be formated with '--histogram' > > > > > > > > 'formatted' > > > > > > > > ... > > > > > > > > > Changes in v10: > > > > > > > > > > Reordered SoB tags to make sure they appear before Rb and Acked > > > > > tags. > > > > > > > > This is not required. The importance is only the order of SoBs > > > > themselves. If they are interleaved with other tags, it's fine. > > > > > > Ah - ok. Just saw someone was complaining about b4 reordering them. > > > > > > > > > > > ... > > > > > > > > > > > > Hopefully to see this series being eventually applied soon. > > > > Arnd? (Do we have all necessary subsystem maintainers' tags, btw?) > > > > > > > > > > > > > > As i see from my perspective only three left: > > > > > > Clk subsystem: > > > > > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > > > DMA subsystem (but the only request from Vinod, as far as i remember, > > > was fixing commits titles): > > > > > > - dmaengine: cirrus: Convert to DT for Cirrus EP93xx > > > - dmaengine: cirrus: remove platform code > > > > > > Beside that tags missing on platform code removal (which can be Acked > > > by Arnd himself i believe) and dtsi/dts files (same ?). > > > > Vinod acked the above two patches: > > > > https://lore.kernel.org/all/ZnkIp8bOcZK3yVKP@matsya/ > > https://lore.kernel.org/all/ZnkImp8BtTdxl7O3@matsya/ > > > > so only: > > > > - clk: ep93xx: add DT support for Cirrus EP93xx > > > > https://lore.kernel.org/all/20240617-ep93xx-v10-3-662e640ed811@maquefel.me/ > > > > left. > > > > Hope Stephen will find some time for this one. > > As we're approaching the merge window and this is still unclear, I > applied the pwm bits (i.e. patches 12, 13). If I understand correctly, > patch 33 isn't suitable for application yet as it has a dependency on > pinctrl changes in that series. Now causing an error in linux-next: Documentation/devicetree/bindings/pwm/cirrus,ep9301-pwm.example.dts:18:18: fatal error: dt-bindings/clock/cirrus,ep9301-syscon.h: No such file or directory 18 | #include <dt-bindings/clock/cirrus,ep9301-syscon.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [scripts/Makefile.lib:442: Documentation/devicetree/bindings/pwm/cirrus,ep9301-pwm.example.dtb] Error 1
Hello Rob, On Tue, Jul 09, 2024 at 07:58:42AM -0600, Rob Herring wrote: > On Fri, Jul 5, 2024 at 3:21 AM Uwe Kleine-König > <u.kleine-koenig@baylibre.com> wrote: > > As we're approaching the merge window and this is still unclear, I > > applied the pwm bits (i.e. patches 12, 13). If I understand correctly, > > patch 33 isn't suitable for application yet as it has a dependency on > > pinctrl changes in that series. > > Now causing an error in linux-next: > > Documentation/devicetree/bindings/pwm/cirrus,ep9301-pwm.example.dts:18:18: > fatal error: dt-bindings/clock/cirrus,ep9301-syscon.h: No such file or > directory > 18 | #include <dt-bindings/clock/cirrus,ep9301-syscon.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[2]: *** [scripts/Makefile.lib:442: > Documentation/devicetree/bindings/pwm/cirrus,ep9301-pwm.example.dtb] > Error 1 Oh, I thought I had tested that, but obviously I didn't. I'll drop them again. Thanks for letting me know. Best regards Uwe
On Mon, Jul 8, 2024, at 09:34, Nikita Shubin wrote: > Arnd, > > Are we continuing this patch series ? > > You are silent since last version submit, which makes me a bit worried. > > If you suddenly changed your mind please let us know, cause anyway we > have no possibility to merge these series without you. Hi Nikita, I definitely still want to merge your work, I was just not paying attention while there were others commenting on it, and I don't know what the current state is. If you are ready to have some or all of the patches included in the next merge window, can you send either the set of patches that were reviewed to soc@kernel.org for me to pick up, or prepare a pull request to that address? Arnd
Hello Arnd! On Wed, 2024-07-10 at 14:31 +0200, Arnd Bergmann wrote: > On Mon, Jul 8, 2024, at 09:34, Nikita Shubin wrote: > > Arnd, > > > > Are we continuing this patch series ? > > > > You are silent since last version submit, which makes me a bit > > worried. > > > > If you suddenly changed your mind please let us know, cause anyway > > we > > have no possibility to merge these series without you. > > Hi Nikita, > > I definitely still want to merge your work, I was just not paying > attention while there were others commenting on it, and I don't > know what the current state is. If you are ready to have some > or all of the patches included in the next merge window, can > you send either the set of patches that were reviewed to > soc@kernel.org for me to pick up, or prepare a pull request > to that address? > > Arnd Thanks for support! We still have a minor issue but AFAIS only a single patch left, but hoping to settle this one with Stephen soon.