diff mbox series

[1/4] package/python-sdbus: new package

Message ID 20240701145708.2886402-1-raphael.melotte@mind.be
State Superseded
Headers show
Series [1/4] package/python-sdbus: new package | expand

Commit Message

Raphaël Mélotte July 1, 2024, 2:57 p.m. UTC
Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
---
 DEVELOPERS                             |  1 +
 package/Config.in                      |  1 +
 package/python-sdbus/Config.in         |  8 ++++++++
 package/python-sdbus/python-sdbus.hash |  5 +++++
 package/python-sdbus/python-sdbus.mk   | 19 +++++++++++++++++++
 5 files changed, 34 insertions(+)
 create mode 100644 package/python-sdbus/Config.in
 create mode 100644 package/python-sdbus/python-sdbus.hash
 create mode 100644 package/python-sdbus/python-sdbus.mk

Comments

Romain Naour July 3, 2024, 9:32 p.m. UTC | #1
Hello Raphaël, All,

Le 01/07/2024 à 16:57, Raphaël Mélotte via buildroot a écrit :
> Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
> ---
>  DEVELOPERS                             |  1 +
>  package/Config.in                      |  1 +
>  package/python-sdbus/Config.in         |  8 ++++++++
>  package/python-sdbus/python-sdbus.hash |  5 +++++
>  package/python-sdbus/python-sdbus.mk   | 19 +++++++++++++++++++
>  5 files changed, 34 insertions(+)
>  create mode 100644 package/python-sdbus/Config.in
>  create mode 100644 package/python-sdbus/python-sdbus.hash
>  create mode 100644 package/python-sdbus/python-sdbus.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 8a5cceba78..0d58df7d50 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2668,6 +2668,7 @@ F:	package/python-jmespath/
>  F:	package/python-pymupdf/
>  F:	package/python-rsa/
>  F:	package/python-s3transfer/
> +F:	package/python-sdbus/
>  F:	support/testing/tests/package/sample_python_jmespath.py
>  F:	support/testing/tests/package/sample_python_rsa.py
>  F:	support/testing/tests/package/sample_python_s3transfer.py
> diff --git a/package/Config.in b/package/Config.in
> index 550fdc1f41..45d8a8c7ec 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1334,6 +1334,7 @@ menu "External python modules"
>  	source "package/python-scapy/Config.in"
>  	source "package/python-schedule/Config.in"
>  	source "package/python-scipy/Config.in"
> +	source "package/python-sdbus/Config.in"
>  	source "package/python-sdnotify/Config.in"
>  	source "package/python-secretstorage/Config.in"
>  	source "package/python-see/Config.in"
> diff --git a/package/python-sdbus/Config.in b/package/python-sdbus/Config.in
> new file mode 100644
> index 0000000000..b5762f5130
> --- /dev/null
> +++ b/package/python-sdbus/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PYTHON_SDBUS
> +	bool "python-sdbus"
> +	depends on BR2_PACKAGE_SYSTEMD # required to get sd-bus
> +	help
> +	  Modern Python D-Bus library. Based on sd-bus from
> +	  libsystemd.
> +
> +	  https://github.com/igo95862/python-sdbus

Please, add a comment when systemd is disabled:

comment "python-sdbus needs systemd"
	depends on !BR2_PACKAGE_SYSTEMD

> diff --git a/package/python-sdbus/python-sdbus.hash b/package/python-sdbus/python-sdbus.hash
> new file mode 100644
> index 0000000000..13c8c2bb5f
> --- /dev/null
> +++ b/package/python-sdbus/python-sdbus.hash
> @@ -0,0 +1,5 @@
> +# md5, sha256 from https://pypi.org/pypi/sdbus/json
> +md5  46d3ea00a491c2eec2a25ccf61b8a77a  sdbus-0.12.0.tar.gz
> +sha256  c3692d75704438a78adc1439350bc32f30d6b38ad344cfc94773db89c6ce4a89  sdbus-0.12.0.tar.gz
> +# Locally computed sha256 checksums
> +sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> diff --git a/package/python-sdbus/python-sdbus.mk b/package/python-sdbus/python-sdbus.mk
> new file mode 100644
> index 0000000000..e4be6efef4
> --- /dev/null
> +++ b/package/python-sdbus/python-sdbus.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# python-sdbus
> +#
> +################################################################################
> +
> +PYTHON_SDBUS_VERSION = 0.12.0
> +PYTHON_SDBUS_SOURCE = sdbus-$(PYTHON_SDBUS_VERSION).tar.gz
> +PYTHON_SDBUS_SITE = https://files.pythonhosted.org/packages/8e/39/3d49f0d18dcba3344af756f31e4408e7de50b3df86fa3f3ea6f604402f16
> +PYTHON_SDBUS_SETUP_TYPE = setuptools
> +PYTHON_SDBUS_LICENSE = GNU Lesser General Public License v2 or later (LGPLv2+)

Use SPDX license format: LGPL-2.0+

> +PYTHON_SDBUS_LICENSE_FILES = COPYING
> +PYTHON_SDBUS_DEPENDENCIES = systemd

Interesting, last time I considered sdbus I was looking for something like
Yocto's dbus-wait.

https://git.yoctoproject.org/dbus-wait

Best regards,
Romain


> +
> +ifeq ($(BR2_STATIC_LIBS),y)
> +PYTHON_SDBUS_ENV += PYTHON_SDBUS_USE_STATIC_LINK=1
> +endif
> +
> +$(eval $(python-package))
Raphaël Mélotte July 5, 2024, 9:18 a.m. UTC | #2
Hello Romain, all,

On 7/3/24 23:32, Romain Naour wrote:
[...]
>> +################################################################################
>> +
>> +PYTHON_SDBUS_VERSION = 0.12.0
>> +PYTHON_SDBUS_SOURCE = sdbus-$(PYTHON_SDBUS_VERSION).tar.gz
>> +PYTHON_SDBUS_SITE = https://files.pythonhosted.org/packages/8e/39/3d49f0d18dcba3344af756f31e4408e7de50b3df86fa3f3ea6f604402f16
>> +PYTHON_SDBUS_SETUP_TYPE = setuptools
>> +PYTHON_SDBUS_LICENSE = GNU Lesser General Public License v2 or later (LGPLv2+)
> 
> Use SPDX license format: LGPL-2.0+

Indeed, I missed the warning about spdx_lookup not being installed when I used scanpypi..

Actually, it looks like in this case, even with spdx_lookup, scanpypi detects it incorrectly (it detects GPL-2.0 but it's actually LGPL-2.1+ for both of them).

Thanks for the review!

I sent a v2: https://patchwork.ozlabs.org/project/buildroot/patch/20240705091409.3370272-1-raphael.melotte@mind.be/


Kind regards,

Raphaël
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 8a5cceba78..0d58df7d50 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2668,6 +2668,7 @@  F:	package/python-jmespath/
 F:	package/python-pymupdf/
 F:	package/python-rsa/
 F:	package/python-s3transfer/
+F:	package/python-sdbus/
 F:	support/testing/tests/package/sample_python_jmespath.py
 F:	support/testing/tests/package/sample_python_rsa.py
 F:	support/testing/tests/package/sample_python_s3transfer.py
diff --git a/package/Config.in b/package/Config.in
index 550fdc1f41..45d8a8c7ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1334,6 +1334,7 @@  menu "External python modules"
 	source "package/python-scapy/Config.in"
 	source "package/python-schedule/Config.in"
 	source "package/python-scipy/Config.in"
+	source "package/python-sdbus/Config.in"
 	source "package/python-sdnotify/Config.in"
 	source "package/python-secretstorage/Config.in"
 	source "package/python-see/Config.in"
diff --git a/package/python-sdbus/Config.in b/package/python-sdbus/Config.in
new file mode 100644
index 0000000000..b5762f5130
--- /dev/null
+++ b/package/python-sdbus/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_PYTHON_SDBUS
+	bool "python-sdbus"
+	depends on BR2_PACKAGE_SYSTEMD # required to get sd-bus
+	help
+	  Modern Python D-Bus library. Based on sd-bus from
+	  libsystemd.
+
+	  https://github.com/igo95862/python-sdbus
diff --git a/package/python-sdbus/python-sdbus.hash b/package/python-sdbus/python-sdbus.hash
new file mode 100644
index 0000000000..13c8c2bb5f
--- /dev/null
+++ b/package/python-sdbus/python-sdbus.hash
@@ -0,0 +1,5 @@ 
+# md5, sha256 from https://pypi.org/pypi/sdbus/json
+md5  46d3ea00a491c2eec2a25ccf61b8a77a  sdbus-0.12.0.tar.gz
+sha256  c3692d75704438a78adc1439350bc32f30d6b38ad344cfc94773db89c6ce4a89  sdbus-0.12.0.tar.gz
+# Locally computed sha256 checksums
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/python-sdbus/python-sdbus.mk b/package/python-sdbus/python-sdbus.mk
new file mode 100644
index 0000000000..e4be6efef4
--- /dev/null
+++ b/package/python-sdbus/python-sdbus.mk
@@ -0,0 +1,19 @@ 
+################################################################################
+#
+# python-sdbus
+#
+################################################################################
+
+PYTHON_SDBUS_VERSION = 0.12.0
+PYTHON_SDBUS_SOURCE = sdbus-$(PYTHON_SDBUS_VERSION).tar.gz
+PYTHON_SDBUS_SITE = https://files.pythonhosted.org/packages/8e/39/3d49f0d18dcba3344af756f31e4408e7de50b3df86fa3f3ea6f604402f16
+PYTHON_SDBUS_SETUP_TYPE = setuptools
+PYTHON_SDBUS_LICENSE = GNU Lesser General Public License v2 or later (LGPLv2+)
+PYTHON_SDBUS_LICENSE_FILES = COPYING
+PYTHON_SDBUS_DEPENDENCIES = systemd
+
+ifeq ($(BR2_STATIC_LIBS),y)
+PYTHON_SDBUS_ENV += PYTHON_SDBUS_USE_STATIC_LINK=1
+endif
+
+$(eval $(python-package))