mbox series

[ovs-dev,0/4] Fix issues reported by coverity

Message ID 20240626133007.694177-1-amusil@redhat.com
Headers show
Series Fix issues reported by coverity | expand

Message

Ales Musil June 26, 2024, 1:30 p.m. UTC 
Coverity discovered a couple of isse that and dead code. The series
aims to fix some of them.

Ales Musil (4):
  treewide: Remove dead code.
  northd: Fix potential overflow
  ovn-nbctl: Avoid uninitialized value for mirror index.
  treewide: Prevent potential NULL ptr deref.

 controller/binding.c        | 2 +-
 controller/lflow.c          | 5 +----
 controller/lflow.h          | 3 +--
 controller/ovn-controller.c | 3 +--
 controller/pinctrl.c        | 8 +-------
 lib/inc-proc-eng.c          | 8 ++------
 lib/lex.c                   | 1 -
 northd/aging.c              | 3 ++-
 northd/northd.c             | 2 +-
 northd/test-ipam.c          | 4 ----
 tests/ovn-nbctl.at          | 9 +++++++++
 utilities/ovn-ic-nbctl.c    | 2 +-
 utilities/ovn-nbctl.c       | 8 +++++---
 13 files changed, 25 insertions(+), 33 deletions(-)

Comments

Numan Siddique July 4, 2024, 9:45 p.m. UTC | #1 
On Wed, Jun 26, 2024 at 9:30 AM Ales Musil <amusil@redhat.com> wrote:
>
> Coverity discovered a couple of isse that and dead code. The series
> aims to fix some of them.
>
> Ales Musil (4):
>   treewide: Remove dead code.
>   northd: Fix potential overflow
>   ovn-nbctl: Avoid uninitialized value for mirror index.
>   treewide: Prevent potential NULL ptr deref.

Thanks for the fixes.  I applied the series to the main branch.

Numan

>
>  controller/binding.c        | 2 +-
>  controller/lflow.c          | 5 +----
>  controller/lflow.h          | 3 +--
>  controller/ovn-controller.c | 3 +--
>  controller/pinctrl.c        | 8 +-------
>  lib/inc-proc-eng.c          | 8 ++------
>  lib/lex.c                   | 1 -
>  northd/aging.c              | 3 ++-
>  northd/northd.c             | 2 +-
>  northd/test-ipam.c          | 4 ----
>  tests/ovn-nbctl.at          | 9 +++++++++
>  utilities/ovn-ic-nbctl.c    | 2 +-
>  utilities/ovn-nbctl.c       | 8 +++++---
>  13 files changed, 25 insertions(+), 33 deletions(-)
>
> --
> 2.45.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>