diff mbox series

test/py/tests: Update some network dependencies

Message ID 20240618202343.3332529-1-trini@konsulko.com
State Accepted
Commit 98506897513718b7a47150b260eaa4638ce6c202
Delegated to: Tom Rini
Headers show
Series test/py/tests: Update some network dependencies | expand

Commit Message

Tom Rini June 18, 2024, 8:23 p.m. UTC 
On tests which require "tftpboot" we need to depend not on cmd_net but
rather cmd_tftpboot. And on tests which require cmd_pxe we do not need
to also depend on cmd_net as this should be handled already via Kconfig
logic.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 test/py/tests/test_net.py      | 5 ++---
 test/py/tests/test_net_boot.py | 5 +----
 2 files changed, 3 insertions(+), 7 deletions(-)

Comments

Tom Rini July 4, 2024, 6:50 p.m. UTC | #1 
On Tue, 18 Jun 2024 14:23:43 -0600, Tom Rini wrote:

> On tests which require "tftpboot" we need to depend not on cmd_net but
> rather cmd_tftpboot. And on tests which require cmd_pxe we do not need
> to also depend on cmd_net as this should be handled already via Kconfig
> logic.
> 
> 

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py
index 038a473b2394..ad143c19b0d2 100644
--- a/test/py/tests/test_net.py
+++ b/test/py/tests/test_net.py
@@ -254,7 +254,7 @@  def test_net_network_discovery(u_boot_console):
     assert 'Set gatewayip6:' in output
     assert '0000:0000:0000:0000:0000:0000:0000:0000' not in output
 
-@pytest.mark.buildconfigspec('cmd_net')
+@pytest.mark.buildconfigspec('cmd_tftpboot')
 def test_net_tftpboot(u_boot_console):
     """Test the tftpboot command.
 
@@ -335,7 +335,6 @@  def test_net_nfs(u_boot_console):
     output = u_boot_console.run_command('crc32 %x $filesize' % addr)
     assert expected_crc in output
 
-@pytest.mark.buildconfigspec("cmd_net")
 @pytest.mark.buildconfigspec("cmd_pxe")
 def test_net_pxe_get(u_boot_console):
     """Test the pxe get command.
@@ -391,7 +390,7 @@  def test_net_pxe_get(u_boot_console):
     assert "Config file 'default.boot' found" in output
 
 @pytest.mark.buildconfigspec("cmd_crc32")
-@pytest.mark.buildconfigspec("cmd_net")
+@pytest.mark.buildconfigspec("cmd_tftpboot")
 @pytest.mark.buildconfigspec("cmd_tftpput")
 def test_net_tftpput(u_boot_console):
     """Test the tftpput command.
diff --git a/test/py/tests/test_net_boot.py b/test/py/tests/test_net_boot.py
index 4729ccf07feb..63309fe82e12 100644
--- a/test/py/tests/test_net_boot.py
+++ b/test/py/tests/test_net_boot.py
@@ -156,7 +156,7 @@  def setup_tftpboot_boot(u_boot_console):
 
     return addr, timeout, pattern, chk_type, chk_pattern, config
 
-@pytest.mark.buildconfigspec('cmd_net')
+@pytest.mark.buildconfigspec('cmd_tftpboot')
 def test_net_tftpboot_boot(u_boot_console):
     """Boot the loaded image
 
@@ -209,7 +209,6 @@  def setup_pxe_boot(u_boot_console):
 
     return f, bootfile
 
-@pytest.mark.buildconfigspec('cmd_net')
 @pytest.mark.buildconfigspec('cmd_pxe')
 def test_net_pxe_boot(u_boot_console):
     """Test the pxe boot command.
@@ -261,7 +260,6 @@  def test_net_pxe_boot(u_boot_console):
             u_boot_console.drain_console()
             u_boot_console.cleanup_spawn()
 
-@pytest.mark.buildconfigspec('cmd_net')
 @pytest.mark.buildconfigspec('cmd_pxe')
 def test_net_pxe_boot_config(u_boot_console):
     """Test the pxe boot command by selecting different combination of labels
@@ -341,7 +339,6 @@  def test_net_pxe_boot_config(u_boot_console):
             u_boot_console.drain_console()
             u_boot_console.cleanup_spawn()
 
-@pytest.mark.buildconfigspec('cmd_net')
 @pytest.mark.buildconfigspec('cmd_pxe')
 def test_net_pxe_boot_config_invalid(u_boot_console):
     """Test the pxe boot command by selecting invalid label