diff mbox series

[4/5] Add chmod08 test

Message ID 20240702-stat04-v1-4-e27d9953210d@suse.com
State Accepted
Headers show
Series symlink01 split | expand

Commit Message

Andrea Cervesato July 2, 2024, 2:12 p.m. UTC
From: Andrea Cervesato <andrea.cervesato@suse.com>

This test has been extracted from symlink01 and it verifies that
chmod() is working correctly on symlink() generated files.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/syscalls                           |  1 +
 testcases/kernel/syscalls/chmod/.gitignore |  1 +
 testcases/kernel/syscalls/chmod/chmod08.c  | 45 ++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+)

Comments

Li Wang July 4, 2024, 7:12 a.m. UTC | #1
On Tue, Jul 2, 2024 at 10:15 PM Andrea Cervesato <andrea.cervesato@suse.de>
wrote:

> From: Andrea Cervesato <andrea.cervesato@suse.com>
>
> This test has been extracted from symlink01 and it verifies that
> chmod() is working correctly on symlink() generated files.
>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
>

Reviewed-by: Li Wang <liwang@redhat.com>

---
>  runtest/syscalls                           |  1 +
>  testcases/kernel/syscalls/chmod/.gitignore |  1 +
>  testcases/kernel/syscalls/chmod/chmod08.c  | 45
> ++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+)
>
> diff --git a/runtest/syscalls b/runtest/syscalls
> index d78b6822b..928e75f9b 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -72,6 +72,7 @@ chmod03 chmod03
>  chmod05 chmod05
>  chmod06 chmod06
>  chmod07 chmod07
> +chmod08 chmod08
>
>  chown01 chown01
>  chown01_16 chown01_16
> diff --git a/testcases/kernel/syscalls/chmod/.gitignore
> b/testcases/kernel/syscalls/chmod/.gitignore
> index 27ddfce16..f295f4dcb 100644
> --- a/testcases/kernel/syscalls/chmod/.gitignore
> +++ b/testcases/kernel/syscalls/chmod/.gitignore
> @@ -3,3 +3,4 @@
>  /chmod05
>  /chmod06
>  /chmod07
> +/chmod08
> diff --git a/testcases/kernel/syscalls/chmod/chmod08.c
> b/testcases/kernel/syscalls/chmod/chmod08.c
> new file mode 100644
> index 000000000..7ef396348
> --- /dev/null
> +++ b/testcases/kernel/syscalls/chmod/chmod08.c
> @@ -0,0 +1,45 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
> + *    Author: David Fenner
> + *    Copilot: Jon Hendrickson
> + * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that chmod() is working correctly on symlink()
> + * generated files.
> + */
> +
> +#include "tst_test.h"
> +
> +#define PERMS 01777
> +#define TESTFILE "myobject"
> +
> +static void run(void)
> +{
> +       char *symname = "my_symlink0";
> +       struct stat oldsym_stat;
> +       struct stat newsym_stat;
> +
> +       SAFE_TOUCH(TESTFILE, 0644, NULL);
> +       SAFE_SYMLINK(TESTFILE, symname);
> +       SAFE_STAT(symname, &oldsym_stat);
> +
> +       TST_EXP_PASS(chmod(symname, PERMS));
> +       SAFE_STAT(symname, &newsym_stat);
> +
> +       TST_EXP_EQ_LI(newsym_stat.st_mode & PERMS, PERMS);
> +       TST_EXP_EXPR(oldsym_stat.st_mode != newsym_stat.st_mode,
> +               "file mode has changed");
> +
> +       SAFE_UNLINK(symname);
> +       SAFE_UNLINK(TESTFILE);
> +}
> +
> +static struct tst_test test = {
> +       .test_all = run,
> +       .needs_tmpdir = 1,
> +};
>
> --
> 2.43.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
diff mbox series

Patch

diff --git a/runtest/syscalls b/runtest/syscalls
index d78b6822b..928e75f9b 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -72,6 +72,7 @@  chmod03 chmod03
 chmod05 chmod05
 chmod06 chmod06
 chmod07 chmod07
+chmod08 chmod08
 
 chown01 chown01
 chown01_16 chown01_16
diff --git a/testcases/kernel/syscalls/chmod/.gitignore b/testcases/kernel/syscalls/chmod/.gitignore
index 27ddfce16..f295f4dcb 100644
--- a/testcases/kernel/syscalls/chmod/.gitignore
+++ b/testcases/kernel/syscalls/chmod/.gitignore
@@ -3,3 +3,4 @@ 
 /chmod05
 /chmod06
 /chmod07
+/chmod08
diff --git a/testcases/kernel/syscalls/chmod/chmod08.c b/testcases/kernel/syscalls/chmod/chmod08.c
new file mode 100644
index 000000000..7ef396348
--- /dev/null
+++ b/testcases/kernel/syscalls/chmod/chmod08.c
@@ -0,0 +1,45 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
+ *    Author: David Fenner
+ *    Copilot: Jon Hendrickson
+ * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
+ */
+
+/*\
+ * [Description]
+ *
+ * This test verifies that chmod() is working correctly on symlink()
+ * generated files.
+ */
+
+#include "tst_test.h"
+
+#define PERMS 01777
+#define TESTFILE "myobject"
+
+static void run(void)
+{
+	char *symname = "my_symlink0";
+	struct stat oldsym_stat;
+	struct stat newsym_stat;
+
+	SAFE_TOUCH(TESTFILE, 0644, NULL);
+	SAFE_SYMLINK(TESTFILE, symname);
+	SAFE_STAT(symname, &oldsym_stat);
+
+	TST_EXP_PASS(chmod(symname, PERMS));
+	SAFE_STAT(symname, &newsym_stat);
+
+	TST_EXP_EQ_LI(newsym_stat.st_mode & PERMS, PERMS);
+	TST_EXP_EXPR(oldsym_stat.st_mode != newsym_stat.st_mode,
+		"file mode has changed");
+
+	SAFE_UNLINK(symname);
+	SAFE_UNLINK(TESTFILE);
+}
+
+static struct tst_test test = {
+	.test_all = run,
+	.needs_tmpdir = 1,
+};