| Message ID | 20240628-mbly-clk-v1-1-edb1e29ea4c1@bootlin.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add Mobileye EyeQ clock support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 0 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 28/06/2024 18:10, Théo Lebrun wrote: > Switch from one sub-node per functionality in the system-controller to a > single node representing the entire OLB instance. This is the > recommended approach for controllers handling many different > functionalities; it is a single controller and should be represented by > a single devicetree node. > > The clock bindings is removed and all properties will be described by: > soc/mobileye/mobileye,eyeq5-olb.yaml > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> This is v1, so where did this happen? Best regards, Krzysztof
Hello Krzysztof, On Mon Jul 1, 2024 at 11:14 AM CEST, Krzysztof Kozlowski wrote: > On 28/06/2024 18:10, Théo Lebrun wrote: > > Switch from one sub-node per functionality in the system-controller to a > > single node representing the entire OLB instance. This is the > > recommended approach for controllers handling many different > > functionalities; it is a single controller and should be represented by > > a single devicetree node. > > > > The clock bindings is removed and all properties will be described by: > > soc/mobileye/mobileye,eyeq5-olb.yaml > > > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > This is v1, so where did this happen? This is a split of the previous Mobileye EyeQ5 system-controller series. I started my cover letter [4] by mentioning it. I should most probably have kept incrementing on the previous version number, sorry about that. Relevant extract from this series' cover letter: On Fri Jun 28, 2024 at 6:10 PM CEST, Théo Lebrun wrote: > This is a new iteration on the Mobileye system-controller series [0]. > It has been split into separate series to facilitate merging. [...] > Related series are targeted at reset [1], pinctrl [2] and MIPS [3]. [...] > [0]: https://lore.kernel.org/lkml/20240620-mbly-olb-v3-0-5f29f8ca289c@bootlin.com/ > [1]: https://lore.kernel.org/lkml/20240628-mbly-reset-v1-0-2a8294fd4392@bootlin.com/ > [2]: https://lore.kernel.org/lkml/20240628-mbly-pinctrl-v1-0-c878192d6b0a@bootlin.com/ > [3]: https://lore.kernel.org/lkml/20240628-mbly-mips-v1-0-f53f5e4c422b@bootlin.com/ Regards, [4]: https://lore.kernel.org/lkml/20240628-mbly-clk-v1-0-edb1e29ea4c1@bootlin.com/ -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml b/Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml deleted file mode 100644 index 2d4f2cde1e58..000000000000 --- a/Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml +++ /dev/null @@ -1,51 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/clock/mobileye,eyeq5-clk.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Mobileye EyeQ5 clock controller - -description: - The EyeQ5 clock controller handles 10 read-only PLLs derived from the main - crystal clock. It also exposes one divider clock, a child of one of the PLLs. - Its registers live in a shared region called OLB. - -maintainers: - - Grégory Clement <gregory.clement@bootlin.com> - - Théo Lebrun <theo.lebrun@bootlin.com> - - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> - -properties: - compatible: - const: mobileye,eyeq5-clk - - reg: - maxItems: 2 - - reg-names: - items: - - const: plls - - const: ospi - - "#clock-cells": - const: 1 - - clocks: - maxItems: 1 - description: - Input parent clock to all PLLs. Expected to be the main crystal. - - clock-names: - items: - - const: ref - -required: - - compatible - - reg - - reg-names - - "#clock-cells" - - clocks - - clock-names - -additionalProperties: false