Message ID | 20240630212754.207691-1-cassel@kernel.org |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] ata fixes for 6.10-rc6 | expand |
On Sun, 30 Jun 2024 at 14:28, Niklas Cassel <cassel@kernel.org> wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux tags/ata-6.10-rc6 So I've pulled these, but I'm not happy with how they seem to be _very_ recent. Yes, they all look trivial, but even trivial commits have bugs, and it looks like they have had absolutely zero testing. Four out of five commits were committed about an hour ago. So please - don't do this. I was close to just unpulling it all again, and if this had been some final -rc, that's what I would have done. This kind of "last-minute commits in last-minute pull request" is not ok. Linus
The pull request you sent on Sun, 30 Jun 2024 23:27:54 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux tags/ata-6.10-rc6
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/aca7c377d8cacc1d2181345fafa94f63ab1ff39f
Thank you!
On Sun, Jun 30, 2024 at 02:40:07PM -0700, Linus Torvalds wrote: > On Sun, 30 Jun 2024 at 14:28, Niklas Cassel <cassel@kernel.org> wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux tags/ata-6.10-rc6 > > So I've pulled these, but I'm not happy with how they seem to be _very_ recent. > > Yes, they all look trivial, but even trivial commits have bugs, and it > looks like they have had absolutely zero testing. Four out of five > commits were committed about an hour ago. The four out of five patches were originally part of a larger series, sent out on Wednesday: https://lore.kernel.org/linux-ide/20240626180031.4050226-15-cassel@kernel.org/ They have been tested using: rmmod + modprobe + rmmod + modprobe on: -AMD AHCI controller -QEMU AHCI controller -pm8001 SAS (libsas) controller Both with a debug patch that forced an error, and without any additional debug patch. Ensuring that: -The error/crash was fixed (in case of forced error) -That all devices show up as intended (in case of no forced error) So it probably looks worse than it is. > So please - don't do this. I was close to just unpulling it all again, > and if this had been some final -rc, that's what I would have done. > This kind of "last-minute commits in last-minute pull request" is not > ok. Understood! FWIW, even with the testing done, I would never even have considered doing the same if we were later in the release cycle. Kind regards, Niklas