| Message ID | 20240627-san-v2-1-750bb0946dbd@daynix.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix check-qtest-ppc64 sanitizer errors | expand |
On Thu, 27 Jun 2024 at 14:39, Akihiko Odaki <akihiko.odaki@daynix.com> wrote: > > This fixes LeakSanitizer warnings. > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> > --- > hw/core/cpu-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c > index f131cde2c038..a3073c17d098 100644 > --- a/hw/core/cpu-common.c > +++ b/hw/core/cpu-common.c > @@ -289,6 +289,7 @@ static void cpu_common_finalize(Object *obj) > qemu_cond_destroy(cpu->halt_cond); > g_free(cpu->halt_cond); > g_free(cpu->thread); > + g_free(cpu->cpu_ases); I think this is likely not sufficient. There's a patch lurking in the vcpu-hotplug series: https://lore.kernel.org/qemu-devel/20240607115649.214622-7-salil.mehta@huawei.com/ which adds a cpu_address_space_destroy() function, which is probably what we need to have happen on CPU unrealize. NB that that patch isn't actually sufficient, though: see discussion here on previous version of patchset https://lore.kernel.org/qemu-devel/CAFEAcA92nCPPk0Qa6XjRqRGTq_XDyRSVVaz67WgJBEZcxoEtOQ@mail.gmail.com/ and the link from there to a different earlier patch from Philippe. thanks -- PMM
diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index f131cde2c038..a3073c17d098 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -289,6 +289,7 @@ static void cpu_common_finalize(Object *obj) qemu_cond_destroy(cpu->halt_cond); g_free(cpu->halt_cond); g_free(cpu->thread); + g_free(cpu->cpu_ases); } static int64_t cpu_common_get_arch_id(CPUState *cpu)
This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- hw/core/cpu-common.c | 1 + 1 file changed, 1 insertion(+)