mbox series

[0/3] Fix findfdt for j722s and am62p

Message ID 20240628-b4-upstream-streamline-platform-v1-0-17659af992c1@ti.com
Headers show
Series Fix findfdt for j722s and am62p | expand

Message

Manorit Chawdhry June 28, 2024, 8:23 a.m. UTC 
findfdt wasn't being populated in these boards, add the code in evm.c
for the same.

Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
Manorit Chawdhry (3):
      include: env: ti: mmc: Change name_fdt usage to fdtfile
      board: ti: am62p|j722s: Add ti_set_fdt_env for findfdt
      configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT

 board/ti/am62px/evm.c            | 9 +++++++++
 board/ti/j722s/evm.c             | 9 +++++++++
 configs/am62px_evm_a53_defconfig | 1 +
 configs/j722s_evm_a53_defconfig  | 1 +
 include/env/ti/mmc.env           | 2 +-
 5 files changed, 21 insertions(+), 1 deletion(-)
---
base-commit: 899b088674b6905710ce546f0a8848662904852a
change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2

Best regards,

Comments

Nishanth Menon June 28, 2024, 1:06 p.m. UTC | #1 
On 13:53-20240628, Manorit Chawdhry wrote:
> findfdt wasn't being populated in these boards, add the code in evm.c
> for the same.

why not just drop findfdt? I am ok with #2,3 more or less, but keeping
findfdt alive is just a bad direction when we are moving to stdboot
flow.


> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
> Manorit Chawdhry (3):
>       include: env: ti: mmc: Change name_fdt usage to fdtfile
>       board: ti: am62p|j722s: Add ti_set_fdt_env for findfdt
>       configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT
> 
>  board/ti/am62px/evm.c            | 9 +++++++++
>  board/ti/j722s/evm.c             | 9 +++++++++
>  configs/am62px_evm_a53_defconfig | 1 +
>  configs/j722s_evm_a53_defconfig  | 1 +
>  include/env/ti/mmc.env           | 2 +-
>  5 files changed, 21 insertions(+), 1 deletion(-)
> ---
> base-commit: 899b088674b6905710ce546f0a8848662904852a
> change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2
> 
> Best regards,
> -- 
> Manorit Chawdhry <m-chawdhry@ti.com>
>
Manorit Chawdhry July 1, 2024, 5 a.m. UTC | #2 
Hi Nishanth,

On 08:06-20240628, Nishanth Menon wrote:
> On 13:53-20240628, Manorit Chawdhry wrote:
> > findfdt wasn't being populated in these boards, add the code in evm.c
> > for the same.
> 
> why not just drop findfdt? I am ok with #2,3 more or less, but keeping

typo... should've written fdtfile. When all the boards migrate to your
series for pulling in fdtfile from ti_set_fdt_env itself, I think findfdt can
be dropped for k3 boards at that point. This series moves am62px and
j722s to that.

Regards,
Manorit

> findfdt alive is just a bad direction when we are moving to stdboot
> flow.
> 
> 
> > 
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > ---
> > Manorit Chawdhry (3):
> >       include: env: ti: mmc: Change name_fdt usage to fdtfile
> >       board: ti: am62p|j722s: Add ti_set_fdt_env for findfdt
> >       configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT
> > 
> >  board/ti/am62px/evm.c            | 9 +++++++++
> >  board/ti/j722s/evm.c             | 9 +++++++++
> >  configs/am62px_evm_a53_defconfig | 1 +
> >  configs/j722s_evm_a53_defconfig  | 1 +
> >  include/env/ti/mmc.env           | 2 +-
> >  5 files changed, 21 insertions(+), 1 deletion(-)
> > ---
> > base-commit: 899b088674b6905710ce546f0a8848662904852a
> > change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2
> > 
> > Best regards,
> > -- 
> > Manorit Chawdhry <m-chawdhry@ti.com>
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D