mbox series

[ovs-dev,v6,0/2] Add support to disable VXLAN mode.

Message ID 20240607135404.758245-1-odivlad@gmail.com
Headers show
Series Add support to disable VXLAN mode. | expand

Message

Vladislav Odintsov June 7, 2024, 1:54 p.m. UTC 
v6:
  - Addressed Mark's review comments:
    1. Removed global variable "vxlan_mode" change from "global" engine node.
    2. Configuration knob "disable_vxlan_mode" was renamed to "vxlan_mode"
v5:
  - Addressed Ihar's review comments:
    1. fixed errors after incorrect conflicts solving on rebase;
    2. changed VXLAN mode naming to capitalized;
    3. clarified VXLAN mode in ovn-architecture man page.
v4:
  - Addressed Dumitru's and Ihar's review comments;
  - single patch was split into two:
    1. function call replaced with a global variable `vxlan_mode`;
    2. introduced `disable_vxlan_mode` configuration knob;
  - rebased onto latest main branch.
v3:
  - Removed accidental ovs submodule change.
v2:
  - Added NEWS item.

Vladislav Odintsov (2):
  northd: Make `vxlan_mode` a global variable.
  northd: Add support for disabling vxlan mode.

 NEWS                      |  4 ++
 northd/en-global-config.c |  9 ++++-
 northd/northd.c           | 84 +++++++++++++++++----------------------
 northd/northd.h           |  6 ++-
 ovn-architecture.7.xml    | 16 +++++---
 ovn-nb.xml                | 10 +++++
 tests/ovn-northd.at       | 29 ++++++++++++++
 7 files changed, 104 insertions(+), 54 deletions(-)

Comments

Dumitru Ceara June 28, 2024, 9:02 a.m. UTC | #1 
On 6/7/24 15:54, Vladislav Odintsov wrote:
> v6:
>   - Addressed Mark's review comments:
>     1. Removed global variable "vxlan_mode" change from "global" engine node.
>     2. Configuration knob "disable_vxlan_mode" was renamed to "vxlan_mode"
> v5:
>   - Addressed Ihar's review comments:
>     1. fixed errors after incorrect conflicts solving on rebase;
>     2. changed VXLAN mode naming to capitalized;
>     3. clarified VXLAN mode in ovn-architecture man page.
> v4:
>   - Addressed Dumitru's and Ihar's review comments;
>   - single patch was split into two:
>     1. function call replaced with a global variable `vxlan_mode`;
>     2. introduced `disable_vxlan_mode` configuration knob;
>   - rebased onto latest main branch.
> v3:
>   - Removed accidental ovs submodule change.
> v2:
>   - Added NEWS item.
> 
> Vladislav Odintsov (2):
>   northd: Make `vxlan_mode` a global variable.
>   northd: Add support for disabling vxlan mode.
> 

Thanks, Vladislav, Ihar and Ales!

I applied this series to main.

Best regards,
Dumitru
Vladislav Odintsov June 28, 2024, 10:54 a.m. UTC | #2 
Thank you all!

regards,
 
Vladislav Odintsov

-----Original Message-----
From: dev <ovs-dev-bounces@openvswitch.org> on behalf of Dumitru Ceara <dceara@redhat.com>
Date: Friday, 28 June 2024 at 12:03
To: Vladislav Odintsov <odivlad@gmail.com>, "dev@openvswitch.org" <dev@openvswitch.org>
Subject: Re: [ovs-dev] [PATCH ovn v6 0/2] Add support to disable VXLAN mode.

    On 6/7/24 15:54, Vladislav Odintsov wrote:
    > v6:
    >   - Addressed Mark's review comments:
    >     1. Removed global variable "vxlan_mode" change from "global" engine node.
    >     2. Configuration knob "disable_vxlan_mode" was renamed to "vxlan_mode"
    > v5:
    >   - Addressed Ihar's review comments:
    >     1. fixed errors after incorrect conflicts solving on rebase;
    >     2. changed VXLAN mode naming to capitalized;
    >     3. clarified VXLAN mode in ovn-architecture man page.
    > v4:
    >   - Addressed Dumitru's and Ihar's review comments;
    >   - single patch was split into two:
    >     1. function call replaced with a global variable `vxlan_mode`;
    >     2. introduced `disable_vxlan_mode` configuration knob;
    >   - rebased onto latest main branch.
    > v3:
    >   - Removed accidental ovs submodule change.
    > v2:
    >   - Added NEWS item.
    > 
    > Vladislav Odintsov (2):
    >   northd: Make `vxlan_mode` a global variable.
    >   northd: Add support for disabling vxlan mode.
    > 

    Thanks, Vladislav, Ihar and Ales!

    I applied this series to main.

    Best regards,
    Dumitru

    _______________________________________________
    dev mailing list
    dev@openvswitch.org
    https://mail.openvswitch.org/mailman/listinfo/ovs-dev