| Message ID | 87jzi9apcd.wl-kuninori.morimoto.gx@renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: simple-audio-mux: add state-labels | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, 28 Jun 2024 00:22:10 +0000, Kuninori Morimoto wrote: > simple-audio-mux is designed to be used generally, thus "Input 1" or > "Input 2" are used to selecting MUX input. This numbered inputs would > work, but might be not user friendly in some case, for example in case > of system hardware design has some clear labels. > Adds new "state-labels" property and enable to select MUX by own state > names. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/sound/simple-audio-mux.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml: state-labels: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/87jzi9apcd.wl-kuninori.morimoto.gx@renesas.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi > > simple-audio-mux is designed to be used generally, thus "Input 1" or > > "Input 2" are used to selecting MUX input. This numbered inputs would > > work, but might be not user friendly in some case, for example in case > > of system hardware design has some clear labels. > > Adds new "state-labels" property and enable to select MUX by own state > > names. > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > --- > > .../devicetree/bindings/sound/simple-audio-mux.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: Grr. Thank you for pointing it. will post v4 patch Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml index 9f319caf3db74..ce722babfe540 100644 --- a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml +++ b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml @@ -24,6 +24,10 @@ properties: description: | GPIOs used to select the input line. + state-labels: + description: | + State of input line. default is "Input 1", "Input 2" + sound-name-prefix: true required: @@ -37,4 +41,5 @@ examples: mux { compatible = "simple-audio-mux"; mux-gpios = <&gpio 3 0>; + state-labels = "Label_A", "Label_B"; };
simple-audio-mux is designed to be used generally, thus "Input 1" or "Input 2" are used to selecting MUX input. This numbered inputs would work, but might be not user friendly in some case, for example in case of system hardware design has some clear labels. Adds new "state-labels" property and enable to select MUX by own state names. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- .../devicetree/bindings/sound/simple-audio-mux.yaml | 5 +++++ 1 file changed, 5 insertions(+)