mbox series

[0/4,SRU,Noble] Update amd_sfh for AMD strix series

Message ID 20240625065702.3341835-1-vicamo.yang@canonical.com
Headers show
Series Update amd_sfh for AMD strix series | expand

Message

You-Sheng Yang June 25, 2024, 6:56 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2058331

[Impact]

AMD MP2 controller not correctly enabled on new processors and thus the
associated sensors.

  pcie_mp2_amd: probe of 0000:c4:00.7 failed with error -12

[Fix]

6 upstream commits from v6.9-rc1. 2 already in linux-6.8 stable.

[Test Case]

The MP2 shall ben enabled correctly with:

  c4:00.7 MP2 I2C controller: Advanced Micro Devices, Inc. [AMD] Device 15e6

[Where problems could occur]

No. This enables MP2 on new processor families with backward support.

[Other Info]

While this is on v6.9-rc1 only, Noble and oem-6.8 will be nominated for fix.

Basavaraj Natikar (4):
  HID: amd_sfh: Increase sensor command timeout
  HID: amd_sfh: Improve boot time when SFH is available
  HID: amd_sfh: Extend MP2 register access to SFH
  HID: amd_sfh: Set the AMD SFH driver to depend on x86

 drivers/hid/amd-sfh-hid/Kconfig               |  1 +
 drivers/hid/amd-sfh-hid/amd_sfh_common.h      | 16 ++++
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        | 88 +++++++++++++++----
 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c |  2 +-
 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c |  4 +-
 .../amd-sfh-hid/sfh1_1/amd_sfh_interface.c    | 10 +--
 6 files changed, 95 insertions(+), 26 deletions(-)

Comments

Timo Aaltonen June 27, 2024, 2:43 p.m. UTC | #1
You-Sheng Yang kirjoitti 25.6.2024 klo 9.56:
> BugLink: https://bugs.launchpad.net/bugs/2058331
> 
> [Impact]
> 
> AMD MP2 controller not correctly enabled on new processors and thus the
> associated sensors.
> 
>    pcie_mp2_amd: probe of 0000:c4:00.7 failed with error -12
> 
> [Fix]
> 
> 6 upstream commits from v6.9-rc1. 2 already in linux-6.8 stable.
> 
> [Test Case]
> 
> The MP2 shall ben enabled correctly with:
> 
>    c4:00.7 MP2 I2C controller: Advanced Micro Devices, Inc. [AMD] Device 15e6
> 
> [Where problems could occur]
> 
> No. This enables MP2 on new processor families with backward support.
> 
> [Other Info]
> 
> While this is on v6.9-rc1 only, Noble and oem-6.8 will be nominated for fix.
> 
> Basavaraj Natikar (4):
>    HID: amd_sfh: Increase sensor command timeout
>    HID: amd_sfh: Improve boot time when SFH is available
>    HID: amd_sfh: Extend MP2 register access to SFH
>    HID: amd_sfh: Set the AMD SFH driver to depend on x86
> 
>   drivers/hid/amd-sfh-hid/Kconfig               |  1 +
>   drivers/hid/amd-sfh-hid/amd_sfh_common.h      | 16 ++++
>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        | 88 +++++++++++++++----
>   drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c |  2 +-
>   drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c |  4 +-
>   .../amd-sfh-hid/sfh1_1/amd_sfh_interface.c    | 10 +--
>   6 files changed, 95 insertions(+), 26 deletions(-)
> 

Acked-by: Timo Aaltonen <timo.aaltonen@canonical.com>
Manuel Diewald June 28, 2024, 3:30 p.m. UTC | #2
On Tue, Jun 25, 2024 at 02:56:57PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2058331
> 
> [Impact]
> 
> AMD MP2 controller not correctly enabled on new processors and thus the
> associated sensors.
> 
>   pcie_mp2_amd: probe of 0000:c4:00.7 failed with error -12
> 
> [Fix]
> 
> 6 upstream commits from v6.9-rc1. 2 already in linux-6.8 stable.
> 
> [Test Case]
> 
> The MP2 shall ben enabled correctly with:
> 
>   c4:00.7 MP2 I2C controller: Advanced Micro Devices, Inc. [AMD] Device 15e6
> 
> [Where problems could occur]
> 
> No. This enables MP2 on new processor families with backward support.
> 
> [Other Info]
> 
> While this is on v6.9-rc1 only, Noble and oem-6.8 will be nominated for fix.
> 
> Basavaraj Natikar (4):
>   HID: amd_sfh: Increase sensor command timeout
>   HID: amd_sfh: Improve boot time when SFH is available
>   HID: amd_sfh: Extend MP2 register access to SFH
>   HID: amd_sfh: Set the AMD SFH driver to depend on x86
> 
>  drivers/hid/amd-sfh-hid/Kconfig               |  1 +
>  drivers/hid/amd-sfh-hid/amd_sfh_common.h      | 16 ++++
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        | 88 +++++++++++++++----
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c |  2 +-
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c |  4 +-
>  .../amd-sfh-hid/sfh1_1/amd_sfh_interface.c    | 10 +--
>  6 files changed, 95 insertions(+), 26 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Stefan Bader July 4, 2024, 5:51 p.m. UTC | #3
On 25.06.24 08:56, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2058331
> 
> [Impact]
> 
> AMD MP2 controller not correctly enabled on new processors and thus the
> associated sensors.
> 
>    pcie_mp2_amd: probe of 0000:c4:00.7 failed with error -12
> 
> [Fix]
> 
> 6 upstream commits from v6.9-rc1. 2 already in linux-6.8 stable.
> 
> [Test Case]
> 
> The MP2 shall ben enabled correctly with:
> 
>    c4:00.7 MP2 I2C controller: Advanced Micro Devices, Inc. [AMD] Device 15e6
> 
> [Where problems could occur]
> 
> No. This enables MP2 on new processor families with backward support.
> 
> [Other Info]
> 
> While this is on v6.9-rc1 only, Noble and oem-6.8 will be nominated for fix.
> 
> Basavaraj Natikar (4):
>    HID: amd_sfh: Increase sensor command timeout
>    HID: amd_sfh: Improve boot time when SFH is available
>    HID: amd_sfh: Extend MP2 register access to SFH
>    HID: amd_sfh: Set the AMD SFH driver to depend on x86
> 
>   drivers/hid/amd-sfh-hid/Kconfig               |  1 +
>   drivers/hid/amd-sfh-hid/amd_sfh_common.h      | 16 ++++
>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        | 88 +++++++++++++++----
>   drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c |  2 +-
>   drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c |  4 +-
>   .../amd-sfh-hid/sfh1_1/amd_sfh_interface.c    | 10 +--
>   6 files changed, 95 insertions(+), 26 deletions(-)
> 

Applied to noble:linux/master-next. Thanks.

-Stefan