mbox series

[v5,00/16] Bug-fixes for a few boards

Message ID 20240626155945.278640-1-sjg@chromium.org
Headers show
Series Bug-fixes for a few boards | expand

Message

Simon Glass June 26, 2024, 3:59 p.m. UTC
This series includes fixes to get some rockchip and nvidia boards
working again. It also drops the broken Beaglebone Black config and
provides a devicetree fix for coral (x86).

Note that since this series fixes bugs, it is targeted at -master

Changes in v5:
- Move setting of pmugrf into the probe() function

Changes in v4:
- Drop Fixes tag
- Add new patch to set a board-size limit for chromebook_link
- Fix 'stating' typo
- Move Binman size feature to a separate series

Changes in v3:
- Use BLOBLIST instead of OF_BLOBLIST
- Cut the patch down to bare bones
- Split out the refactoring into a separate patch

Changes in v2:
- Put the conditions under EFI_TCG2_PROTOCOL
- Consider MEASURED_BOOT too
- Remove the superfluous if() and drop the debug() as well
- Use 'phase' instead of 'stage'
- Add new patch to correct memory size in SPL
- Drop patch "regulator: rk8xx: Fix incorrect parameter"
- Rewrite boneblack patch to onstead drop the target and update docs

Simon Glass (16):
  mkeficapsule: Add a --version argument
  binman: Collect the version number for mkeficapsule
  binman: Deal with mkeficapsule being missing
  binman: Return failure when a usage() message is generated
  binman: Keep the efi_capsule input file
  nvidia: nyan-big: Disable debug UART
  tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL
  x86: Set a board-size limit for chromebook_link
  rockchip: veyron: Add logging for power init
  power: regulator: Handle autoset in regulators_enable_boot_on()
  fdt: Correct condition for bloblist existing
  spl: Allow ATF to work when dcache is disabled
  rockchip: Ensure memory size is available in RK3399 SPL
  rockchip: Avoid #ifdefs in RK3399 SPL
  rockchip: bob: kevin: Disable dcache in SPL
  Drop the special am335x_boneblack_vboot target

 board/google/veyron/veyron.c               | 30 +++----
 board/ti/am335x/MAINTAINERS                |  1 -
 boot/Kconfig                               |  4 +
 common/spl/spl_atf.c                       |  3 +-
 configs/am335x_boneblack_vboot_defconfig   | 94 ----------------------
 configs/am335x_evm_defconfig               |  3 +-
 configs/chromebook_bob_defconfig           |  1 +
 configs/chromebook_kevin_defconfig         |  1 +
 configs/chromebook_link_defconfig          |  2 +
 configs/nyan-big_defconfig                 |  1 -
 doc/mkeficapsule.1                         |  4 +
 doc/usage/fit/beaglebone_vboot.rst         | 21 +++--
 drivers/power/regulator/regulator-uclass.c |  2 +-
 drivers/ram/rockchip/sdram_rk3399.c        | 35 ++++----
 lib/Kconfig                                |  4 -
 lib/fdtdec.c                               | 12 ++-
 tools/binman/btool/mkeficapsule.py         |  3 +-
 tools/binman/etype/efi_capsule.py          |  5 +-
 tools/mkeficapsule.c                       | 10 ++-
 19 files changed, 80 insertions(+), 156 deletions(-)
 delete mode 100644 configs/am335x_boneblack_vboot_defconfig

Comments

Tom Rini June 26, 2024, 4:34 p.m. UTC | #1
On Wed, Jun 26, 2024 at 04:59:29PM +0100, Simon Glass wrote:

> This series includes fixes to get some rockchip and nvidia boards
> working again. It also drops the broken Beaglebone Black config and
> provides a devicetree fix for coral (x86).
> 
> Note that since this series fixes bugs, it is targeted at -master
[snip]
> Simon Glass (16):
>   mkeficapsule: Add a --version argument
>   binman: Collect the version number for mkeficapsule
>   binman: Deal with mkeficapsule being missing
>   binman: Return failure when a usage() message is generated
>   binman: Keep the efi_capsule input file

Can you please split these out from this series? At this point in the
cycle I just want obvious regression fixes.

>   nvidia: nyan-big: Disable debug UART

This is fine.

>   tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL
>   x86: Set a board-size limit for chromebook_link

These two combined are fine.

>   rockchip: veyron: Add logging for power init
>   power: regulator: Handle autoset in regulators_enable_boot_on()

These have acks and are fine.

>   fdt: Correct condition for bloblist existing

I'm waiting for review tags on this one.

>   spl: Allow ATF to work when dcache is disabled

This is fine.

>   rockchip: Ensure memory size is available in RK3399 SPL
>   rockchip: Avoid #ifdefs in RK3399 SPL
>   rockchip: bob: kevin: Disable dcache in SPL

These keep being iterated on?

>   Drop the special am335x_boneblack_vboot target

This is fine.

It might be best for right now to split out the patches that I've listed
as fine above, to one series that I'll pick up today after my current
queue of next testing is done, another of the binman/mkeficapsule
changes, and another of the remaining fixes. Thanks.
Simon Glass June 27, 2024, 8:31 a.m. UTC | #2
Hi Tom,

On Wed, 26 Jun 2024 at 17:34, Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, Jun 26, 2024 at 04:59:29PM +0100, Simon Glass wrote:
>
> > This series includes fixes to get some rockchip and nvidia boards
> > working again. It also drops the broken Beaglebone Black config and
> > provides a devicetree fix for coral (x86).
> >
> > Note that since this series fixes bugs, it is targeted at -master
> [snip]
> > Simon Glass (16):
> >   mkeficapsule: Add a --version argument
> >   binman: Collect the version number for mkeficapsule
> >   binman: Deal with mkeficapsule being missing
> >   binman: Return failure when a usage() message is generated
> >   binman: Keep the efi_capsule input file
>
> Can you please split these out from this series? At this point in the
> cycle I just want obvious regression fixes.
>
> >   nvidia: nyan-big: Disable debug UART
>
> This is fine.
>
> >   tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL
> >   x86: Set a board-size limit for chromebook_link
>
> These two combined are fine.
>
> >   rockchip: veyron: Add logging for power init
> >   power: regulator: Handle autoset in regulators_enable_boot_on()
>
> These have acks and are fine.
>
> >   fdt: Correct condition for bloblist existing
>
> I'm waiting for review tags on this one.
>
> >   spl: Allow ATF to work when dcache is disabled
>
> This is fine.
>
> >   rockchip: Ensure memory size is available in RK3399 SPL
> >   rockchip: Avoid #ifdefs in RK3399 SPL
> >   rockchip: bob: kevin: Disable dcache in SPL
>
> These keep being iterated on?

I believe the last one is OK...the other two don't help my boards
anyway, but I'll continue trying to figure out what is needed.

>
> >   Drop the special am335x_boneblack_vboot target
>
> This is fine.
>
> It might be best for right now to split out the patches that I've listed
> as fine above, to one series that I'll pick up today after my current
> queue of next testing is done, another of the binman/mkeficapsule
> changes, and another of the remaining fixes. Thanks.

OK done, except I added the 'Disable dcache in SPL' patch.

As noted in the series, I would like the FDT bloblist thing sorted out
/ applied, even if it is a stopgap in -master.

Regards,
Simon