diff mbox series

[05/14] sunxi: Mark scp as optional

Message ID 20240623203033.1566505-6-sjg@chromium.org
State Accepted
Commit 12ecba9627af664cb5f139f4ea9391512dd24e9b
Delegated to: Tom Rini
Headers show
Series testb: Various tweaks and fixes for Labgrid | expand

Commit Message

Simon Glass June 23, 2024, 8:30 p.m. UTC
This binary does not prevent the system from booting. Mark it optional
so that U-Boot can be built without it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 arch/arm/dts/sunxi-u-boot.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Andre Przywara June 24, 2024, 9:36 a.m. UTC | #1
On Sun, 23 Jun 2024 14:30:24 -0600
Simon Glass <sjg@chromium.org> wrote:

> This binary does not prevent the system from booting. Mark it optional
> so that U-Boot can be built without it.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> 
> (no changes since v1)
> 
>  arch/arm/dts/sunxi-u-boot.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/sunxi-u-boot.dtsi
> index 0909a67883e..e1a9a7f5d4c 100644
> --- a/arch/arm/dts/sunxi-u-boot.dtsi
> +++ b/arch/arm/dts/sunxi-u-boot.dtsi
> @@ -90,6 +90,7 @@
>  					scp {
>  						filename = "scp.bin";
>  						missing-msg = "scp-sunxi";
> +						optional;
>  					};
>  				};
>  #endif
Dragan Simic June 24, 2024, 3:50 p.m. UTC | #2
Hello Simon,

On 2024-06-23 22:30, Simon Glass wrote:
> This binary does not prevent the system from booting. Mark it optional
> so that U-Boot can be built without it.

It should read "Lack of this binary..." instead, to properly describe
the background of this patch.

> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> (no changes since v1)
> 
>  arch/arm/dts/sunxi-u-boot.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/sunxi-u-boot.dtsi 
> b/arch/arm/dts/sunxi-u-boot.dtsi
> index 0909a67883e..e1a9a7f5d4c 100644
> --- a/arch/arm/dts/sunxi-u-boot.dtsi
> +++ b/arch/arm/dts/sunxi-u-boot.dtsi
> @@ -90,6 +90,7 @@
>  					scp {
>  						filename = "scp.bin";
>  						missing-msg = "scp-sunxi";
> +						optional;
>  					};
>  				};
>  #endif
diff mbox series

Patch

diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/sunxi-u-boot.dtsi
index 0909a67883e..e1a9a7f5d4c 100644
--- a/arch/arm/dts/sunxi-u-boot.dtsi
+++ b/arch/arm/dts/sunxi-u-boot.dtsi
@@ -90,6 +90,7 @@ 
 					scp {
 						filename = "scp.bin";
 						missing-msg = "scp-sunxi";
+						optional;
 					};
 				};
 #endif