| Message ID | 20240620013018.2283965-1-tharvey@gateworks.com |
|---|---|
| State | Accepted |
| Commit | 8ffd7fb0df6953d8baacef4706f50ca002c519e7 |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | imx8mp-venice-gw702x: Drop EQos clock workaround | expand |
Hi Tim, On Wed, Jun 19, 2024 at 10:30 PM Tim Harvey <tharvey@gateworks.com> wrote: > > The assigned-clock no longer have to be dropped, the clock are now > defined in clk-imx8mp.c and used by DWMAC driver to configure the > DWMAC clock. Drop the workarounds from U-Boot specific DT extras. > > Having the clocks dropped causes the EQoS to be non-functional. > > See commit c7ea9612df0f ("arm64: dts: imx8mp: Drop EQoS clock > workaround"). > > Fixes: 48c6f9777cee ("board: gateworks: venice: add imx8mp-gw7905-2x support") > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Is this targetted for master or next?
On Fri, Jun 21, 2024 at 7:24 AM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Tim, > > On Wed, Jun 19, 2024 at 10:30 PM Tim Harvey <tharvey@gateworks.com> wrote: > > > > The assigned-clock no longer have to be dropped, the clock are now > > defined in clk-imx8mp.c and used by DWMAC driver to configure the > > DWMAC clock. Drop the workarounds from U-Boot specific DT extras. > > > > Having the clocks dropped causes the EQoS to be non-functional. > > > > See commit c7ea9612df0f ("arm64: dts: imx8mp: Drop EQoS clock > > workaround"). > > > > Fixes: 48c6f9777cee ("board: gateworks: venice: add imx8mp-gw7905-2x support") > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > Is this targetted for master or next? Hi Fabio, It doesn't make much difference to me. This is a fix for a board model that was renamed from gw7905 to gw7500 anyway which is a change in dts/upstream I'm going to have to wait for anyway so you can leave it for next if you want. I actually have about 8 patches in my repo to dts/upstream from linux 6.9 and upcoming linux 6.10 as dts/upstream was last merged from v6.8. The set of 5 or so patches I sent in the last few days are all fixes of sorts and they are all isolated to board/gateworks/venice so don't affect anyone else. Best Regards, Tim
Hi Tim, On Fri, Jun 21, 2024 at 12:42 PM Tim Harvey <tharvey@gateworks.com> wrote: > Hi Fabio, > > It doesn't make much difference to me. This is a fix for a board model > that was renamed from gw7905 to gw7500 anyway which is a change in > dts/upstream I'm going to have to wait for anyway so you can leave it > for next if you want. I actually have about 8 patches in my repo to > dts/upstream from linux 6.9 and upcoming linux 6.10 as dts/upstream > was last merged from v6.8. > > The set of 5 or so patches I sent in the last few days are all fixes > of sorts and they are all isolated to board/gateworks/venice so don't > affect anyone else. Applied this one and your other patches to u-boot-imx/next, thanks.
diff --git a/arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi b/arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi index b9e3db7de937..98f71c73c986 100644 --- a/arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi +++ b/arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi @@ -4,9 +4,3 @@ */ #include "imx8mp-venice-u-boot.dtsi" - -&eqos { - /delete-property/ assigned-clocks; - /delete-property/ assigned-clock-parents; - /delete-property/ assigned-clock-rates; -};
The assigned-clock no longer have to be dropped, the clock are now defined in clk-imx8mp.c and used by DWMAC driver to configure the DWMAC clock. Drop the workarounds from U-Boot specific DT extras. Having the clocks dropped causes the EQoS to be non-functional. See commit c7ea9612df0f ("arm64: dts: imx8mp: Drop EQoS clock workaround"). Fixes: 48c6f9777cee ("board: gateworks: venice: add imx8mp-gw7905-2x support") Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- arch/arm/dts/imx8mp-venice-gw702x-u-boot.dtsi | 6 ------ 1 file changed, 6 deletions(-)