mbox series

[v2,0/2] Opt-out static C++ link check and tests

Message ID 20240525122641.3154365-1-hjl.tools@gmail.com
Headers show
Series Opt-out static C++ link check and tests | expand

Message

H.J. Lu May 25, 2024, 12:26 p.m. UTC 
The current glibc build and test will fail if static C++ link doesn't
work.  There are cases where static C++ link is hard to supported:

1. Building i686 glibc with GCC 6.4 on Fedora 40 failed since the C++
header files couldn't be found which was caused by the static C++ link
check failure due to missing __divmoddi4 which was referenced in i686
libc.a and added to GCC 7. 
2. Glibc test won't finish because static C++ tests fail when the C++
toolchain doesn't have necessary static C++ libraries which may not be
easily installed.

Add --disable-static-c++-link-check configure option to disable the static
C++ link check.  Add --disable-static-c++-tests option to skip the static
C++ tests which also implies --disable-static-c++-link-check.

H.J. Lu (2):
  Add --disable-static-c++-link-check option [BZ #31412]
  Add --disable-static-c++-tests option [BZ #31797]

 INSTALL             | 17 +++++++++++++++++
 configure           | 44 ++++++++++++++++++++++++++++++++++++--------
 configure.ac        | 35 +++++++++++++++++++++++++----------
 manual/install.texi | 16 ++++++++++++++++
 nptl/Makefile       |  3 +++
 5 files changed, 97 insertions(+), 18 deletions(-)

Comments

Carlos O'Donell June 20, 2024, 6:23 p.m. UTC | #1 
On 5/25/24 8:26 AM, H.J. Lu wrote:
> The current glibc build and test will fail if static C++ link doesn't
> work.  There are cases where static C++ link is hard to supported:

OK.

> 1. Building i686 glibc with GCC 6.4 on Fedora 40 failed since the C++
> header files couldn't be found which was caused by the static C++ link
> check failure due to missing __divmoddi4 which was referenced in i686
> libc.a and added to GCC 7. 

OK.

> 2. Glibc test won't finish because static C++ tests fail when the C++
> toolchain doesn't have necessary static C++ libraries which may not be
> easily installed.

OK.

> Add --disable-static-c++-link-check configure option to disable the static
> C++ link check.  Add --disable-static-c++-tests option to skip the static
> C++ tests which also implies --disable-static-c++-link-check.

OK.
 
> H.J. Lu (2):
>   Add --disable-static-c++-link-check option [BZ #31412]
>   Add --disable-static-c++-tests option [BZ #31797]

Overall they look OK to me, but text needed a little updating to avoid
the double negative.

Reviews provided for both.

> 
>  INSTALL             | 17 +++++++++++++++++
>  configure           | 44 ++++++++++++++++++++++++++++++++++++--------
>  configure.ac        | 35 +++++++++++++++++++++++++----------
>  manual/install.texi | 16 ++++++++++++++++
>  nptl/Makefile       |  3 +++
>  5 files changed, 97 insertions(+), 18 deletions(-)
>