| Message ID | 20240620100750.1075790-5-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | MediaTek CMDQ - drop clock-names and refactor clock probe | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Jun 20, 2024 at 12:07:50PM +0200, AngeloGioacchino Del Regno wrote: > On all MediaTek SoCs, each GCE Mailbox have got only one single > clock, and this is true in both SoCs with a single mailbox and > ones with multiple mailboxes. > > Stop requiring clock-names on all GCEs, as there is and there > will always be only one CMDQ clock per HW instance. I'd like the commit message here to mention that there are no users outside of Linux for this before making the property non-required. And obviously you can only say that if it is true - although I think you said to me earlier today that U-Boot etc don't support this device, only Linux. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/mailbox/mediatek,gce-mailbox.yaml | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml > index cef9d7601398..ff5d010fbcf0 100644 > --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml > @@ -56,17 +56,6 @@ required: > - interrupts > - clocks > > -allOf: > - - if: > - not: > - properties: > - compatible: > - contains: > - const: mediatek,mt8195-gce > - then: > - required: > - - clock-names > - > additionalProperties: false > > examples: > -- > 2.45.2 >
diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml index cef9d7601398..ff5d010fbcf0 100644 --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml @@ -56,17 +56,6 @@ required: - interrupts - clocks -allOf: - - if: - not: - properties: - compatible: - contains: - const: mediatek,mt8195-gce - then: - required: - - clock-names - additionalProperties: false examples:
On all MediaTek SoCs, each GCE Mailbox have got only one single clock, and this is true in both SoCs with a single mailbox and ones with multiple mailboxes. Stop requiring clock-names on all GCEs, as there is and there will always be only one CMDQ clock per HW instance. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../bindings/mailbox/mediatek,gce-mailbox.yaml | 11 ----------- 1 file changed, 11 deletions(-)