| Message ID | 20240619-play-fdt-fixup-v1-1-18e2a728ca45@ti.com |
|---|---|
| State | Accepted |
| Commit | c53b344475734d0d29f522b7b1d80c5b8204442d |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | board: beagle: beagleplay: enable OF_SYSTEM_SETUP | expand |
On 6/19/24 2:12 PM, Bryan Brattlof wrote: > Unfortunately when enabling FDT fixups for the AM62x family of SoCs and > moving TF-A to the bottom of RAM we missed the BeaglePlay. This is > causing Linux's memory allocator to clobber TF-A and break its boot. > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > actual location of the firmware > > CC: Andrew Davis <afd@ti.com> > CC: Nishanth Menon <nm@ti.com> > CC: Robert Nelson <robertcnelson@gmail.com> > Reported-by: Dhruva Gole <d-gole@ti.com> > Signed-off-by: Bryan Brattlof <bb@ti.com> > --- Acked-by: Andrew Davis <afd@ti.com> > Hello everyone, > > Fair warning, this may turn into a philosophical discussion about the > role of device-tree with SystemReady and U-Boot's role in enabling true > distribution to be completely agnostic of the board it's running on. > > However substantively this is simply fixing a boot regression Dhruva > found while testing out the beagleplay. > > Happy reviewing > ~Bryan > --- > board/beagle/beagleplay/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig > index 7dbd833acb4cc..896a1c1be3010 100644 > --- a/board/beagle/beagleplay/Kconfig > +++ b/board/beagle/beagleplay/Kconfig > @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY > bool "BeagleBoard.org AM625 BeaglePlay running on A53" > select ARM64 > select BINMAN > + select OF_SYSTEM_SETUP > > config TARGET_AM625_R5_BEAGLEPLAY > bool "BeagleBoard.org AM625 BeaglePlay running on R5" > > --- > base-commit: fe2ce09a0753634543c32cafe85eb87a625f76ca > change-id: 20240619-play-fdt-fixup-a92e1ab872fc > > Best regards,
On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote: > On 6/19/24 2:12 PM, Bryan Brattlof wrote: > > Unfortunately when enabling FDT fixups for the AM62x family of SoCs and > > moving TF-A to the bottom of RAM we missed the BeaglePlay. This is > > causing Linux's memory allocator to clobber TF-A and break its boot. > > > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > > actual location of the firmware > > > > CC: Andrew Davis <afd@ti.com> > > CC: Nishanth Menon <nm@ti.com> > > CC: Robert Nelson <robertcnelson@gmail.com> > > Reported-by: Dhruva Gole <d-gole@ti.com> > > Signed-off-by: Bryan Brattlof <bb@ti.com> > > --- > > Acked-by: Andrew Davis <afd@ti.com> > > > Hello everyone, > > > > Fair warning, this may turn into a philosophical discussion about the > > role of device-tree with SystemReady and U-Boot's role in enabling true > > distribution to be completely agnostic of the board it's running on. > > > > However substantively this is simply fixing a boot regression Dhruva > > found while testing out the beagleplay. > > > > Happy reviewing > > ~Bryan > > --- > > board/beagle/beagleplay/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig > > index 7dbd833acb4cc..896a1c1be3010 100644 > > --- a/board/beagle/beagleplay/Kconfig > > +++ b/board/beagle/beagleplay/Kconfig > > @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY > > bool "BeagleBoard.org AM625 BeaglePlay running on A53" > > select ARM64 > > select BINMAN > > + select OF_SYSTEM_SETUP Thanks for the quick fix, Tested-by: Dhruva Gole <d-gole@ti.com> Boot logs upto kernel prompt: https://gist.github.com/DhruvaG2000/4dc1c1e42207dd98a144f27cc9dff177
On 20/06/24 11:21, Dhruva Gole wrote: > On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote: >> On 6/19/24 2:12 PM, Bryan Brattlof wrote: >>> Unfortunately when enabling FDT fixups for the AM62x family of SoCs and >>> moving TF-A to the bottom of RAM we missed the BeaglePlay. This is >>> causing Linux's memory allocator to clobber TF-A and break its boot. >>> >>> Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the >>> actual location of the firmware >>> >>> CC: Andrew Davis <afd@ti.com> >>> CC: Nishanth Menon <nm@ti.com> >>> CC: Robert Nelson <robertcnelson@gmail.com> >>> Reported-by: Dhruva Gole <d-gole@ti.com> >>> Signed-off-by: Bryan Brattlof <bb@ti.com> >>> --- >> Acked-by: Andrew Davis <afd@ti.com> Acked-by: Chirag Shilwant <c-shilwant@ti.com> >>> Hello everyone, >>> >>> Fair warning, this may turn into a philosophical discussion about the >>> role of device-tree with SystemReady and U-Boot's role in enabling true >>> distribution to be completely agnostic of the board it's running on. >>> >>> However substantively this is simply fixing a boot regression Dhruva >>> found while testing out the beagleplay. >>> >>> Happy reviewing >>> ~Bryan >>> --- >>> board/beagle/beagleplay/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig >>> index 7dbd833acb4cc..896a1c1be3010 100644 >>> --- a/board/beagle/beagleplay/Kconfig >>> +++ b/board/beagle/beagleplay/Kconfig >>> @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY >>> bool "BeagleBoard.org AM625 BeaglePlay running on A53" >>> select ARM64 >>> select BINMAN >>> + select OF_SYSTEM_SETUP > Thanks for the quick fix, > Tested-by: Dhruva Gole <d-gole@ti.com> > > Boot logs upto kernel prompt: > https://gist.github.com/DhruvaG2000/4dc1c1e42207dd98a144f27cc9dff177 >
On 11:55-20240620, Chirag Shilwant wrote: > > On 20/06/24 11:21, Dhruva Gole wrote: > > On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote: > > > On 6/19/24 2:12 PM, Bryan Brattlof wrote: > > > > Unfortunately when enabling FDT fixups for the AM62x family of SoCs and > > > > moving TF-A to the bottom of RAM we missed the BeaglePlay. This is > > > > causing Linux's memory allocator to clobber TF-A and break its boot. > > > > > > > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > > > > actual location of the firmware > > > > > > > > CC: Andrew Davis <afd@ti.com> > > > > CC: Nishanth Menon <nm@ti.com> > > > > CC: Robert Nelson <robertcnelson@gmail.com> > > > > Reported-by: Dhruva Gole <d-gole@ti.com> > > > > Signed-off-by: Bryan Brattlof <bb@ti.com> > > > > --- > > > Acked-by: Andrew Davis <afd@ti.com> > > > Acked-by: Chirag Shilwant <c-shilwant@ti.com> > > > > > > > Hello everyone, > > > > > > > > Fair warning, this may turn into a philosophical discussion about the > > > > role of device-tree with SystemReady and U-Boot's role in enabling true > > > > distribution to be completely agnostic of the board it's running on. > > > > > > > > However substantively this is simply fixing a boot regression Dhruva > > > > found while testing out the beagleplay. > > > > > > > > Happy reviewing > > > > ~Bryan > > > > --- > > > > board/beagle/beagleplay/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig > > > > index 7dbd833acb4cc..896a1c1be3010 100644 > > > > --- a/board/beagle/beagleplay/Kconfig > > > > +++ b/board/beagle/beagleplay/Kconfig > > > > @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY > > > > bool "BeagleBoard.org AM625 BeaglePlay running on A53" > > > > select ARM64 > > > > select BINMAN > > > > + select OF_SYSTEM_SETUP > > Thanks for the quick fix, > > Tested-by: Dhruva Gole <d-gole@ti.com> > > > > Boot logs upto kernel prompt: > > https://gist.github.com/DhruvaG2000/4dc1c1e42207dd98a144f27cc9dff177 > > Thanks. Reviewed-by: Nishanth Menon <nm@ti.com> Tom: this is a regression in master and in next - will appreciate if you could merge this..
On Thu, Jun 20, 2024 at 4:15 PM Nishanth Menon <nm@ti.com> wrote: > > On 11:55-20240620, Chirag Shilwant wrote: > > > > On 20/06/24 11:21, Dhruva Gole wrote: > > > On Jun 19, 2024 at 15:44:41 -0500, Andrew Davis wrote: > > > > On 6/19/24 2:12 PM, Bryan Brattlof wrote: > > > > > Unfortunately when enabling FDT fixups for the AM62x family of SoCs and > > > > > moving TF-A to the bottom of RAM we missed the BeaglePlay. This is > > > > > causing Linux's memory allocator to clobber TF-A and break its boot. > > > > > > > > > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > > > > > actual location of the firmware > > > > > > > > > > CC: Andrew Davis <afd@ti.com> > > > > > CC: Nishanth Menon <nm@ti.com> > > > > > CC: Robert Nelson <robertcnelson@gmail.com> > > > > > Reported-by: Dhruva Gole <d-gole@ti.com> > > > > > Signed-off-by: Bryan Brattlof <bb@ti.com> > > > > > --- > > > > Acked-by: Andrew Davis <afd@ti.com> > > > > > > Acked-by: Chirag Shilwant <c-shilwant@ti.com> > > > > > > > > > > > Hello everyone, > > > > > > > > > > Fair warning, this may turn into a philosophical discussion about the > > > > > role of device-tree with SystemReady and U-Boot's role in enabling true > > > > > distribution to be completely agnostic of the board it's running on. > > > > > > > > > > However substantively this is simply fixing a boot regression Dhruva > > > > > found while testing out the beagleplay. > > > > > > > > > > Happy reviewing > > > > > ~Bryan > > > > > --- > > > > > board/beagle/beagleplay/Kconfig | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig > > > > > index 7dbd833acb4cc..896a1c1be3010 100644 > > > > > --- a/board/beagle/beagleplay/Kconfig > > > > > +++ b/board/beagle/beagleplay/Kconfig > > > > > @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY > > > > > bool "BeagleBoard.org AM625 BeaglePlay running on A53" > > > > > select ARM64 > > > > > select BINMAN > > > > > + select OF_SYSTEM_SETUP > > > Thanks for the quick fix, > > > Tested-by: Dhruva Gole <d-gole@ti.com> > > > > > > Boot logs upto kernel prompt: > > > https://gist.github.com/DhruvaG2000/4dc1c1e42207dd98a144f27cc9dff177 > > > > > > Thanks. > > Reviewed-by: Nishanth Menon <nm@ti.com> > > > Tom: this is a regression in master and in next - will appreciate if you > could merge this.. Boot tested on v2024.07-rc4 with my BeaglePlay's.. Tested-by: Robert Nelson <robertcnelson@gmail.com>
On Wed, 19 Jun 2024 14:12:30 -0500, Bryan Brattlof wrote: > Unfortunately when enabling FDT fixups for the AM62x family of SoCs and > moving TF-A to the bottom of RAM we missed the BeaglePlay. This is > causing Linux's memory allocator to clobber TF-A and break its boot. > > Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the > actual location of the firmware > > [...] Applied to u-boot/master, thanks!
diff --git a/board/beagle/beagleplay/Kconfig b/board/beagle/beagleplay/Kconfig index 7dbd833acb4cc..896a1c1be3010 100644 --- a/board/beagle/beagleplay/Kconfig +++ b/board/beagle/beagleplay/Kconfig @@ -12,6 +12,7 @@ config TARGET_AM625_A53_BEAGLEPLAY bool "BeagleBoard.org AM625 BeaglePlay running on A53" select ARM64 select BINMAN + select OF_SYSTEM_SETUP config TARGET_AM625_R5_BEAGLEPLAY bool "BeagleBoard.org AM625 BeaglePlay running on R5"
Unfortunately when enabling FDT fixups for the AM62x family of SoCs and moving TF-A to the bottom of RAM we missed the BeaglePlay. This is causing Linux's memory allocator to clobber TF-A and break its boot. Enable OF_SYSTEM_SETUP to fixup the kernel's FDT to inform it of the actual location of the firmware CC: Andrew Davis <afd@ti.com> CC: Nishanth Menon <nm@ti.com> CC: Robert Nelson <robertcnelson@gmail.com> Reported-by: Dhruva Gole <d-gole@ti.com> Signed-off-by: Bryan Brattlof <bb@ti.com> --- Hello everyone, Fair warning, this may turn into a philosophical discussion about the role of device-tree with SystemReady and U-Boot's role in enabling true distribution to be completely agnostic of the board it's running on. However substantively this is simply fixing a boot regression Dhruva found while testing out the beagleplay. Happy reviewing ~Bryan --- board/beagle/beagleplay/Kconfig | 1 + 1 file changed, 1 insertion(+) --- base-commit: fe2ce09a0753634543c32cafe85eb87a625f76ca change-id: 20240619-play-fdt-fixup-a92e1ab872fc Best regards,