| Message ID | 20240607115330.447412-1-martin.kalcok@canonical.com |
|---|---|
| State | Accepted |
| Commit | 8b405f45d5f1fd112d19526e609e6669038f8974 |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | [ovs-dev] ovsdb-client: Document "--timeout" option in help. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
I made a silly typo in the commit message s/infomration/information. Would it be possible to fix it when the commit is applied, or is it worth posting v2? Thanks, Martin. On Fri, 2024-06-07 at 13:53 +0200, Martin Kalcok wrote: > Add infomration about "-t" and "--timeout" options for ovsdb-client. > The option is documented in the "Other options" section, similar > to how "ovs-appctl" has it. > > Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> > --- > ovsdb/ovsdb-client.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c > index cf2ecfd08..80ef90c82 100644 > --- a/ovsdb/ovsdb-client.c > +++ b/ovsdb/ovsdb-client.c > @@ -474,6 +474,8 @@ usage(void) > vlog_usage(); > ovs_replay_usage(); > printf("\nOther options:\n" > + " -t, --timeout=SECS limits ovsdb-client > runtime to\n" > + " approximately SECS > seconds.\n" > " -h, --help display this help > message\n" > " -V, --version display version > information\n"); > exit(EXIT_SUCCESS);
On Fri, Jun 07, 2024 at 01:58:42PM +0200, martin.kalcok@canonical.com wrote: > I made a silly typo in the commit message s/infomration/information. > Would it be possible to fix it when the commit is applied, or is it > worth posting v2? Thanks Martin, I think we can handle that when applying. Acked-by: Simon Horman <horms@ovn.org>
On Wed, Jun 19, 2024 at 11:54:37AM +0100, Simon Horman wrote: > On Fri, Jun 07, 2024 at 01:58:42PM +0200, martin.kalcok@canonical.com wrote: > > I made a silly typo in the commit message s/infomration/information. > > Would it be possible to fix it when the commit is applied, or is it > > worth posting v2? > > Thanks Martin, > > I think we can handle that when applying. Thanks again Martin, Applied with the typo fixed. - ovsdb-client: Document "--timeout" option in help. https://github.com/openvswitch/ovs/commit/24907bd1bc1a
diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index cf2ecfd08..80ef90c82 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -474,6 +474,8 @@ usage(void) vlog_usage(); ovs_replay_usage(); printf("\nOther options:\n" + " -t, --timeout=SECS limits ovsdb-client runtime to\n" + " approximately SECS seconds.\n" " -h, --help display this help message\n" " -V, --version display version information\n"); exit(EXIT_SUCCESS);
Add infomration about "-t" and "--timeout" options for ovsdb-client. The option is documented in the "Other options" section, similar to how "ovs-appctl" has it. Signed-off-by: Martin Kalcok <martin.kalcok@canonical.com> --- ovsdb/ovsdb-client.c | 2 ++ 1 file changed, 2 insertions(+)